Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion quest/m1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ per-frame CPU growth since #5926.
- [Poll-first async](/quest/m1/poll-first/README.md) - library crates compile no coroutines by default: async wrappers are generated from `poll_*` and gated behind an `async` feature
- [Authored tracks default to a 30 s max-age](/quest/m1/max-age-defaults.md) - raw and media tracks advertise 30 s unless their author chooses otherwise, with explicit unlimited in every binding
- [HLS export lists a same-codec reconfigure's first group under the new init](/quest/m1/hls-reinit-same-codec.md) - the hand-over pick, whichever of the catalog and the records arrives first, after the catalog `hls` removal is planned
- [moq-quic deletes its remaining 0-RTT code](/quest/m1/quic-zero-rtt-leftovers.md) - only the code that drops a 0-RTT packet remains, with a test
- [Gate the no-em-dash rule](/quest/m1/em-dash-gate.md) - `just check` fails on an em dash in any tracked text file
- [The resume model passes its long run again](/quest/m1/resume-model-7542.md) - fix #7542's regression that drops groups a long-budget reader can still get
- [A resume more than one group behind never hangs](/quest/m1/ietf-resume-behind.md) - a resumed read gets every group or a drop on every wire version
Expand Down
20 changes: 0 additions & 20 deletions quest/m1/quic-zero-rtt-leftovers.md

This file was deleted.

5 changes: 0 additions & 5 deletions quest/m2/quic-long-type.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,3 @@ goes with it.

Planned 2026-11-01 (maintainer, follow-up planning after the 2026-11-01 /quest-complete run). A mechanical change in `rs/moq-quic/src/packet.rs`. Keep the packet fuzz
target and its regression seeds passing.
On main, `LongType` still has `ZeroRtt` until #7492 lands.

## Required

- [moq-quic deletes its remaining 0-RTT code](/quest/m1/quic-zero-rtt-leftovers.md) - moves 0-RTT out of `LongType`, in [moq-dev/moq#7492](https://github.com/moq-dev/moq/pull/7492)
3 changes: 0 additions & 3 deletions rs/moq-quic/src/connection/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2998,9 +2998,6 @@ impl Connection {
}
Ok(())
}
Header::Long {
ty: LongType::ZeroRtt, ..
} => Ok(()),
Header::VersionNegotiate { .. } => {
// RFC 9000 6.2: discard once any other packet was processed
if processed_server_packet {
Expand Down
4 changes: 0 additions & 4 deletions rs/moq-quic/src/connection/packet_crypto.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ pub(super) fn unprotect_header(
spaces: &[PacketSpace; 3],
stateless_reset_token: Option<ResetToken>,
) -> Option<UnprotectHeaderResult> {
if partial_decode.is_0rtt() {
trace!("discarding early data");
return None;
}
let header_crypto = if let Some(space) = partial_decode.space() {
if let Some(crypto) = &spaces[space].crypto {
Some(&*crypto.header.remote)
Expand Down
16 changes: 1 addition & 15 deletions rs/moq-quic/src/endpoint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ impl Endpoint {
} = received;
// Partially decode packet or short-circuit if unable
let datagram_len = data.len();
let mut event = match PartialDecode::new(
let event = match PartialDecode::new(
data,
&FixedLengthConnectionIdParser::new(self.local_cid_generator.cid_len()),
self.config.grease_quic_bit,
Expand Down Expand Up @@ -214,20 +214,6 @@ impl Endpoint {
}
};

// Drop leading early packets before routing or buffering, preserving a coalesced
// handshake packet after them.
while event.first_decode.is_0rtt() {
let data = event.remaining.take()?;
let (first_decode, remaining) = PartialDecode::new(
data,
&FixedLengthConnectionIdParser::new(self.local_cid_generator.cid_len()),
self.config.grease_quic_bit,
)
.ok()?;
event.first_decode = first_decode;
event.remaining = remaining;
}

let addresses = FourTuple { remote, local_ip };
let dst_cid = event.first_decode.dst_cid();

Expand Down
13 changes: 10 additions & 3 deletions rs/moq-quic/src/fuzz.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ pub const TARGETS: &[(&str, Target)] = &[

/// A cid length byte, a grease byte, and a datagram: the unprotected packet header.
///
/// A decoded packet and the coalesced remainder together account for every input byte.
/// The decoded packet is the bytes just before the coalesced remainder, and any bytes before
/// it start with a 0-RTT packet, which the decode skips.
pub fn packet(data: &[u8]) -> bool {
let [cid_len, grease, packet @ ..] = data else {
return false;
Expand All @@ -68,8 +69,14 @@ pub fn packet(data: &[u8]) -> bool {
return false;
};

let rest = rest.map_or(0, |rest| rest.len());
assert_eq!(len, decoded.len() + rest, "the decode lost bytes");
let end = len - rest.map_or(0, |rest| rest.len());
let skipped = end.checked_sub(decoded.len()).expect("the decode invented bytes");
assert_eq!(decoded.data(), &packet[skipped..end], "the decode moved bytes");
// A long header (0x80) with the 0-RTT type (0x10 of the type bits 0x30)
assert!(
skipped == 0 || packet[0] & 0xb0 == 0x90,
"the decode skipped a packet that is not 0-RTT"
);
true
}

Expand Down
Loading
Loading