Repository navigation
docs(quest): retire the superseded unknown-range marker quest - #7503
Conversation
Quest-Claim: 6d36e2006157c151
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
The maintainer retired it on 2026-11-01. #7204 removed the listed-group loops it targeted: FETCH buffers its one group before FETCH_OK, and Rust and JS fills reset their stream on failure instead of skipping silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 218ecef85e4b4a463b650214cc616dc003e08730.
No actionable bugs found. Retiring the obsolete quest and removing its milestone link is the simpler direction: the current Rust FETCH path prepares and owns the group's frames before FETCH_OK, while failed fills reset their stream rather than silently skipping data. The corresponding JS paths follow the same policy. Given the recorded maintainer decision to retain that policy, adding unknown-range handling would introduce unnecessary scope; this deletion changes no API or wire behavior.
Verification: inspected the complete two-file diff, milestone context, and relevant Rust/JS publisher paths through GitHub. Did not run quest validation or tests; the PR's reported checks were not independently reproduced.
(Written by OpenAI)
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run reviewed the head 218ecef85 in full: a quest-deletion PR with no production code and no wire or public-API impact.
- Deletes
quest/m1/ietf-publisher-unknown-range.md— retires the quest that asked the Rust IETF publisher to send End of Unknown Range (0x10C) for a group listed in a FETCH answer or draft-22 fill that it could no longer serve, instead of skipping it silently. - Removes its single index bullet from
quest/m1/README.md— the standardquest rmdeletion convention, covered byquest check.
Verification
The clearing condition holds. The superseding PR #7204 ("refactor(net): limit IETF publishers to one-group history") is merged, and the current rs/moq-net/src/ietf/publisher.rs no longer has the skip the quest targeted: serve_fetch_stream prepares the single group via prepare_fetch before FETCH_OK and rejects the FETCH on any error, while run_fill resets its stream on failure rather than skipping a listed group. With one-group history and owned frames surviving eviction, no listing-then-unservable race remains, and the Unsupported/NotFetchable cases are known failures, not "unknown". A repo-wide search finds no remaining reference to the deleted filename, so no dangling prose links are left behind.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

Problem
The quest
quest/m1/ietf-publisher-unknown-range.mdasked the Rust IETF publisher to send End of Unknown Range (0x10C) for a group it had listed in a FETCH answer or draft-22 fill but could no longer serve, instead of silently skipping it. moq-dev/moq#7204 removed the code that skipped:Approach
Retire the quest as superseded, following the quest guide's Deletion section.
quest rmdeleted the file and its single link fromquest/m1/README.md. A search of the tracked files finds no other link.Superseded by: the one-group FETCH/fill implementation from moq-dev/moq#7204, along with its fill-failure policy (the stream resets).
Decisions
## Decisions neededitem.Impact
Validation
quest check --base origin/main: passed, 612 documents.diff --checkagainstorigin/main: passed.origin/main(merge commit). No conflicts.Review
Local review skipped on head
218ecef85e: the change touches only quests. Under the quest guide's simple-review rule (moq-dev/quest#364), the online reviewers cover it. No online-reviewer findings were posted on earlier heads.Follow-ups
None.
(Written by Claude Opus 5.5)