Skip to content

docs(quest): retire the superseded unknown-range marker quest - #7503

Merged
kixelated merged 4 commits into
mainfrom
quest/m1/ietf-publisher-unknown-range
Nov 2, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m1/ietf-publisher-unknown-range

Conversation

@kixelated

@kixelated kixelated commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The quest quest/m1/ietf-publisher-unknown-range.md asked the Rust IETF publisher to send End of Unknown Range (0x10C) for a group it had listed in a FETCH answer or draft-22 fill but could no longer serve, instead of silently skipping it. moq-dev/moq#7204 removed the code that skipped:

Approach

Retire the quest as superseded, following the quest guide's Deletion section. quest rm deleted the file and its single link from quest/m1/README.md. A search of the tracked files finds no other link.

Superseded by: the one-group FETCH/fill implementation from moq-dev/moq#7204, along with its fill-failure policy (the stream resets).

Decisions

  • Maintainer decision (2026-11-01): retire the quest as superseded. Do not rescope it to switch Rust and JS fill failure from a reset to an unknown-range marker. This settles the earlier ## Decisions needed item.

Impact

  • Public API: none.
  • Wire: none.
  • Quests only. No production code changed.

Validation

  • quest check --base origin/main: passed, 612 documents.
  • diff --check against origin/main: passed.
  • Merged origin/main (merge commit). No conflicts.

Review

Local review skipped on head 218ecef85e: the change touches only quests. Under the quest guide's simple-review rule (moq-dev/quest#364), the online reviewers cover it. No online-reviewer findings were posted on earlier heads.

Follow-ups

None.

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 31, 2026 23:27
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@kixelated kixelated changed the title The Rust IETF publisher marks a lost listed group unknown docs(quest): reassess the superseded unknown-range marker plan Nov 1, 2026
kixelated and others added 2 commits November 1, 2026 10:15
The maintainer retired it on 2026-11-01. #7204 removed the
listed-group loops it targeted: FETCH buffers its one group before
FETCH_OK, and Rust and JS fills reset their stream on failure instead of
skipping silently.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title docs(quest): reassess the superseded unknown-range marker plan docs(quest): retire the superseded unknown-range marker quest Nov 1, 2026
@kixelated
kixelated marked this pull request as ready for review November 1, 2026 18:16
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2efc1f03-2dc0-4767-b9ab-b3027b6a3a7b
Commits

Reviewing files that changed from the base of the PR and between 951cca6 and 218ecef.

Files selected for processing: 2
  • quest/m1/README.md
  • quest/m1/ietf-publisher-unknown-range.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 218ecef85e4b4a463b650214cc616dc003e08730.

No actionable bugs found. Retiring the obsolete quest and removing its milestone link is the simpler direction: the current Rust FETCH path prepares and owns the group's frames before FETCH_OK, while failed fills reset their stream rather than silently skipping data. The corresponding JS paths follow the same policy. Given the recorded maintainer decision to retain that policy, adding unknown-range handling would introduce unnecessary scope; this deletion changes no API or wire behavior.

Verification: inspected the complete two-file diff, milestone context, and relevant Rust/JS publisher paths through GitHub. Did not run quest validation or tests; the PR's reported checks were not independently reproduced.

(Written by OpenAI)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This run reviewed the head 218ecef85 in full: a quest-deletion PR with no production code and no wire or public-API impact.

  • Deletes quest/m1/ietf-publisher-unknown-range.md — retires the quest that asked the Rust IETF publisher to send End of Unknown Range (0x10C) for a group listed in a FETCH answer or draft-22 fill that it could no longer serve, instead of skipping it silently.
  • Removes its single index bullet from quest/m1/README.md — the standard quest rm deletion convention, covered by quest check.

Verification

The clearing condition holds. The superseding PR #7204 ("refactor(net): limit IETF publishers to one-group history") is merged, and the current rs/moq-net/src/ietf/publisher.rs no longer has the skip the quest targeted: serve_fetch_stream prepares the single group via prepare_fetch before FETCH_OK and rejects the FETCH on any error, while run_fill resets its stream on failure rather than skipping a listed group. With one-group history and owned frames surviving eviction, no listing-then-unservable race remains, and the Unsupported/NotFetchable cases are known failures, not "unknown". A repo-wide search finds no remaining reference to the deleted filename, so no dangling prose links are left behind.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated enabled auto-merge (squash) November 1, 2026 18:21
@kixelated
kixelated added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit b8f13fa Nov 2, 2026
7 checks passed
@kixelated
kixelated deleted the quest/m1/ietf-publisher-unknown-range branch November 2, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant