Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m0/ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,4 +166,5 @@ The historical samples locate candidates; they are not controlled benchmarks.
- [The queue host keeps the queue's disk](/quest/m0/ci/queue-host-disk.md) - agent sessions can't starve the queue runner of disk, and a crashed runner restarts
- [The next test-CPU cuts](/quest/m0/ci/test-cost-followups.md) - the slow-test leftovers from #6987, cut at their source
- [Biome checks every file it can parse](/quest/m0/ci/biome-whole-repo.md) - Biome runs over the whole repository and main is clean under it
- [dispatch.sh's tests pass without KVM](/quest/m0/ci/dispatch-test-kvm.md) - `sh/dispatch-query.test.py` fakes the KVM probe instead of failing 20 tests on hosts without `/dev/kvm`
- [mbx launches Cargo with any argument length](/quest/m0/ci/mbx-arg-max.md) - no "Argument list too long" in `sh/rs/select.test.py`'s recipe test
22 changes: 22 additions & 0 deletions quest/m0/ci/dispatch-test-kvm.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# [XS] dispatch.sh's tests pass without KVM

## Goal

`sh/dispatch-query.test.py` passes on a Linux x86_64 host without
`/dev/kvm`, as it does on CI's KVM runners. dispatch.sh still refuses
`check flake` on a host without KVM, the refusal that
[moq-dev/moq#7281](https://github.com/moq-dev/moq/pull/7281) added.

## Plan

Decided by the maintainer on 2026-11-01: plan it in m0 ✅ / m1 / drop.

- Today 20 of its 30 tests fail on such a host. Every run whose selection
includes `check flake` reaches the real `/dev/kvm` probe in
`sh/dispatch.sh`, so the mocked CI run exits 1. `just check` on main
fails locally there too.
- The test harness owns the fix: let it fake the probe's answer, for example
by pointing dispatch.sh at a probe path the test sets. Don't loosen the
refusal, and don't skip the tests when KVM is missing.
- Add a case for the refusal itself: with the probe reporting no KVM, a run
selecting `check flake` fails and names the missing `/dev/kvm`.