Skip to content
Merged
1 change: 0 additions & 1 deletion quest/m1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ per-frame CPU growth since #5926.
- [Main is no slower than release](/quest/m1/release-perf/README.md) - every benchmark where main is slower than release is fixed or accepted with a reason, checked by a final paired run before the cut
- [Interop coverage](/quest/m1/interop-coverage/README.md) - the riskiest moq-transport features moq-net exposes get cross-implementation tests over drafts 18 and 22
- [Calibrate the paired nightly benchmarks](/quest/m1/bench-ci.md) - A/A and deliberately slowed Nightly runs set the paired comparison's threshold, so its regression alerts can be trusted
- [The shared pacer holds its rate under 2 Mbit/s](/quest/m1/pacer-low-rate.md) - a rate-paced controller stops sending up to twice its pacing rate at low rates, landed with a BBR3 retune that keeps the probe budgets
- [HLS and DASH segment conformance](/quest/m1/hls-conformance.md) - nightly ffprobe checks that advertised timing, sync flags, and bytes match the media served
- [Unbounded groups](/quest/m1/unbounded-groups/README.md) - groups and frames lose their size caps; a group keeps a 32 MB tail, and readers behind it replay through paced flights or refresh
- [A follower is told when the serving epochless route leaves](/quest/m1/epochless-leave-restart.md) - wire-level tests pin the restart a follower gets when the serving epochless route is withdrawn or dies while another remains
Expand Down
23 changes: 0 additions & 23 deletions quest/m1/pacer-low-rate.md

This file was deleted.

12 changes: 11 additions & 1 deletion quest/m2/quic-realtime/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,17 @@ spike assumed no consumer; teleoperation uplinks are one):
- Docs: inline only. The congestion-control lines in `doc/bin/cli.md` and
`doc/lib/*` gain the new variant; no new page.

The shared pacer's low-rate correction and BBR3's one-datagram minimum send
quantum are implemented together in [moq-dev/moq#7606](https://github.com/moq-dev/moq/pull/7606).
GCC ([moq-dev/moq#7546](https://github.com/moq-dev/moq/pull/7546)) landed first,
so #7606 reran its in-tree row, `rises_to_target_under_gcc` (1 Mbit/s start, a
3 Mbit/s path opening to 12 Mbit/s), on all 8 seeds. The correction left it
unchanged: 1 late frame probing and baseline, the same p99, and the target
reached 5 s (1x) and 9 s (2x) after the path opened on every seed. The bake-off
must use the corrected pacer: earlier candidate rows below 2 Mbit/s, including
GCC's out-of-tree `tests::realtime` rows in #7546, can include up to 2x pacing
overshoot.

Remaining work once the candidates finish (this README's own job):

- Run the shared comparison on the uplink presets: queuing delay p50/p95/p99,
Expand Down Expand Up @@ -112,7 +123,6 @@ owns that feedback.

## Related

- [The shared pacer holds its rate under 2 Mbit/s](/quest/m1/pacer-low-rate.md) - every candidate paces through it, so its fix shifts their low-rate rows
- [Per-stream and per-datagram deadlines](/quest/m2/quic-deadline.md) - also consumes the forward-delay estimate
- [BBR media study](/quest/m2/quic-bbr-study.md) - BBR3 behavior under media, the baseline here
- [Measure ECN on the backbone](/quest/m2/quic-ecn-measure.md) - decides whether SCReAMv2's L4S path is worth porting
Expand Down
14 changes: 9 additions & 5 deletions rs/moq-congestion/src/bbr3/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,8 @@ impl Bbr3 {
init.max_pacing_rate,
init.now,
),
send_quantum: 2 * smss, /* we start high, but it will be adjusted in set_send_quantum <https://www.ietf.org/archive/id/draft-ietf-ccwg-bbr-06.html#section-5.6.3> */
// Keep the first flight conservative until an ACK measures the path's RTT.
send_quantum: smss,
pacing_gain: startup_pacing_gain,
startup_pacing_gain,
default_pacing_gain,
Expand Down Expand Up @@ -1585,7 +1586,9 @@ impl Bbr3 {
// C.pacing_rate is in bytes/sec, so multiplying by 1ms is dividing by 1000.
let mut quantum = (self.pacing_rate / 1000.0) as u64;
quantum = Ord::min(quantum, HIGH_PACE_MAX_QUANTUM);
quantum = Ord::max(quantum, 2 * self.smss);
// One datagram is enough at low rates. A two-datagram floor forces packet pairs
// even when earning that pair takes longer than the RTT.
quantum = Ord::max(quantum, self.smss);
self.send_quantum = quantum;
}

Expand Down Expand Up @@ -4746,7 +4749,7 @@ mod test {
/// packet size in bytes
const MSS: u64 = 1200;
/// bottleneck bandwidth: 8 Mbit/s (1 MB/s) in bytes/sec. Two constraints pin this:
/// - cruise pacing (~0.99*BW) times 1ms (~990 B) must stay under the `2*SMSS`
/// - cruise pacing (~0.99*BW) times 1ms (~990 B) must stay under the `SMSS`
/// `set_send_quantum` floor, so `send_quantum` sits at that floor and `offload_budget`
/// (send_quantum + delayed-ACK term) stays below `MinPipeCwnd` (4*SMSS); otherwise the
/// floor can't bind.
Expand Down Expand Up @@ -7234,14 +7237,15 @@ mod test {
/// as the transport does until after the ACK callbacks.
#[test]
fn first_rtt_recalibrates_startup_pacing() {
for rtt_ns in [10 * MS, MS / 5] {
for rtt_ns in [MS / 5, 10 * MS, 100 * MS, 1000 * MS] {
let mut sim = scripted();
assert_eq!(sim.bbr.burst(), Some(sim.bbr.smss));
sim.round(0, 1, rtt_ns);
assert_eq!(sim.bbr.pacing_rate, startup_rate(rtt_ns));
let quantum = (sim.bbr.pacing_rate / 1000.0) as u64;
assert_eq!(
sim.bbr.send_quantum,
quantum.clamp(2400, HIGH_PACE_MAX_QUANTUM)
quantum.clamp(1200, HIGH_PACE_MAX_QUANTUM)
);
}
}
Expand Down
Loading
Loading