Skip to content

fix(gst): install and smoke-test packaged plugins on release (backport #5216) - #7647

Merged
kixelated merged 1 commit into
releasefrom
backport/gst-plugin-install
Nov 3, 2026
Merged

kixelated merged 1 commit into
releasefrom
backport/gst-plugin-install

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

The moq-gst Homebrew formula on the tap (0.4.20, rendered from release) installs Dir["lib/libgstmoq.*"], but the release tarball puts the plugin under lib/gstreamer-1.0/. The glob is empty, so brew install moq-dev/tap/moq-gst installs no plugin. moq-dev/moq#5216 fixed this on main on 2026-10-11; release never got it, and release-brew.yml renders the formula from the tagged commit, so the next moq-gst release would ship the broken formula again.

Approach

Cherry-pick of 98d2c0872 (-x). The formula installs the exact platform library into its own lib/gstreamer-1.0/, its brew test uses an isolated registry and checks gst-inspect loads that file, and the macOS tarball job installs and tests the rendered formula before release. The Nix moq-gst wrapper gains gst-plugins-ugly and gst-libav and checks moq, x264enc, avenc_aac, and avdec_h264 in postBuild.

Conflicts, resolved by hand:

  • .github/justfile: kept release's ffi recipe beside the new gst-formula recipe, and dropped main-only sh/changed.test.py from test.
  • quest/m1/README.md: kept release's; it never listed the deleted gst-brew-path quest.

Impact

  • No library API, ABI, or wire change. Packaging only: Homebrew installs the plugin at $(brew --prefix moq-gst)/lib/gstreamer-1.0, which users add to GST_PLUGIN_PATH_1_0 (documented in doc/bin/gstreamer.md and the formula caveats).
  • A malformed archive now fails the install instead of producing an empty formula.

Releasing moq-gst

Nothing here publishes or tags. After this merges into release:

  1. The push touches rs/moq-gst/README.md (under rs/**), so Release RS runs just rs release. Its release-plz release-pr refreshes the open chore: release PR, moq-dev/moq#7325, which already bumps moq-gst 0.4.20 to 0.4.21. If that run is skipped, dispatch release-rs.yml on release.
  2. Merge moq-dev/moq#7325. The next Release RS run's release-plz release publishes the crates it bumps, including moq-gst 0.4.21, and pushes tag moq-gst-v0.4.21 with the moq-bot token.
  3. The tag runs moq-gst.yml: the tarballs build, the new macOS step installs and tests the rendered formula against the real archive, then the moq-gst v0.4.21 GitHub release is created and apt/rpm publishing is triggered.
  4. Its success triggers release-brew.yml, which checks out the tag, renders .github/homebrew/Formula/moq-gst.rb.tmpl from it, and pushes the formula to moq-dev/homebrew-tap.
  5. Verify: the tap's Formula/moq-gst.rb installs lib/gstreamer-1.0/libgstmoq.*, and brew install moq-dev/tap/moq-gst && brew test moq-gst passes on Apple Silicon.

moq-dev/moq#7325 bundles every crate bump pending on release, so step 2 releases all of them, not only moq-gst.

Alternatives

  • Waiting for the next breaking cut from main: leaves the tap installing nothing until then.
  • Hand-editing the tap's formula: release-brew would overwrite it from release's template at the next moq-gst release.

Follow-ups

None.

Checks

  • just check origin/release: pass. An unscoped just check on release fails at tsc with TS5112 in TypeScript this diff does not touch.
  • python3 sh/gh/gst-formula.test.py: 3 tests pass.
  • nix build .#moq-gst: pass; postBuild finds moq, x264enc, avenc_aac, and avdec_h264.
  • The macOS formula install step runs only on a moq-gst-v* tag or a dispatch of moq-gst.yml; not run locally (Linux host).

Review

  • Reviewer: Codex, gpt-6.1-sol, medium effort (quest review --base origin/release, round 1)
  • Head: be7f785
  • Findings: none

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Backport to release. Conflicts in .github/justfile (kept release's ffi
recipe beside gst-formula, dropped main-only sh/changed.test.py) and
quest/m1/README.md (kept release's; it never listed gst-brew-path).

(cherry picked from commit 98d2c08)

Co-authored-by: GPT-6 <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This is a git cherry-pick -x of main's 98d2c0872 (#5216) onto release, fixing the Homebrew formula that installed Dir["lib/libgstmoq.*"] (an empty glob) while the release tarball keeps the plugin at lib/gstreamer-1.0/. Packaging-only; no library API/ABI/wire change.

  • Formula template (.github/homebrew/Formula/moq-gst.rb.tmpl): installs the platform library from lib/gstreamer-1.0/, caveats switch to GST_PLUGIN_PATH_1_0, and test do uses an isolated GST_REGISTRY, a scoped GST_PLUGIN_PATH_1_0, an emptied GST_PLUGIN_SYSTEM_PATH_1_0, then asserts gst-inspect-1.0 moq names the installed file.
  • CI installer (sh/gh/gst-formula.py, new): refuses non-aarch64-apple-darwin, renders the template with the local tarball's sha and a file:// URI, fails if moq-gst is already installed, taps moq-dev/ci-gst, installs + brew test, and in finally uninstalls + untaps only what it created.
  • Unit tests (sh/gh/gst-formula.test.py, new): three cases over the ownership boundary (existing install refused, non-macOS refused before brew, failed test cleans only the created tap/install). I ran python3 sh/gh/gst-formula.test.py — 3 tests pass.
  • Workflow (.github/workflows/moq-gst.yml): a macOS-only build step installs and smoke-tests the rendered formula against the just-built tarball.
  • Nix (nix/overlay.nix): the moq-gst wrapper adds gst-plugins-ugly + gst-libav and postBuild checks moq, x264enc, avenc_aac, avdec_h264.
  • Docs (doc/bin/gstreamer.md, rs/moq-gst/README.md): document the Homebrew install path and the expanded Nix plugin set.

I compared all changed files against the original commit and they match. The two documented backport divergences are sound: the release justfile keeps its own structure, and release carries no gst-brew-path quest to remove (confirmed: file absent, no references). The new workflow step calls a just recipe, so the check-runs guard is satisfied.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: be7f785

No actionable bugs found. This backport fixes the archive/formula path mismatch at its source and retains the original installer’s ownership guard and installed-plugin identity check. Extending the existing Nix wrapper is appropriately scoped; no API or wire changes are introduced. The release-specific justfile resolution preserves existing FFI tooling.

Verification: static comparison with #5216 and inspection of surrounding archive, formula-rendering and release workflow code. I did not run tests or verify a current-head macOS formula installation.

@kixelated
kixelated merged commit 50a28f4 into release Nov 3, 2026
21 checks passed
@kixelated
kixelated deleted the backport/gst-plugin-install branch November 3, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant