Repository navigation
fix(gst): install and smoke-test packaged plugins on release (backport #5216) - #7647
Conversation
Backport to release. Conflicts in .github/justfile (kept release's ffi recipe beside gst-formula, dropped main-only sh/changed.test.py) and quest/m1/README.md (kept release's; it never listed gst-brew-path). (cherry picked from commit 98d2c08) Co-authored-by: GPT-6 <noreply@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This is a git cherry-pick -x of main's 98d2c0872 (#5216) onto release, fixing the Homebrew formula that installed Dir["lib/libgstmoq.*"] (an empty glob) while the release tarball keeps the plugin at lib/gstreamer-1.0/. Packaging-only; no library API/ABI/wire change.
- Formula template (
.github/homebrew/Formula/moq-gst.rb.tmpl): installs the platform library fromlib/gstreamer-1.0/, caveats switch toGST_PLUGIN_PATH_1_0, andtest douses an isolatedGST_REGISTRY, a scopedGST_PLUGIN_PATH_1_0, an emptiedGST_PLUGIN_SYSTEM_PATH_1_0, then assertsgst-inspect-1.0 moqnames the installed file. - CI installer (
sh/gh/gst-formula.py, new): refuses non-aarch64-apple-darwin, renders the template with the local tarball's sha and afile://URI, fails ifmoq-gstis already installed, tapsmoq-dev/ci-gst, installs +brew test, and infinallyuninstalls + untaps only what it created. - Unit tests (
sh/gh/gst-formula.test.py, new): three cases over the ownership boundary (existing install refused, non-macOS refused before brew, failed test cleans only the created tap/install). I ranpython3 sh/gh/gst-formula.test.py— 3 tests pass. - Workflow (
.github/workflows/moq-gst.yml): a macOS-only build step installs and smoke-tests the rendered formula against the just-built tarball. - Nix (
nix/overlay.nix): themoq-gstwrapper addsgst-plugins-ugly+gst-libavandpostBuildchecksmoq,x264enc,avenc_aac,avdec_h264. - Docs (
doc/bin/gstreamer.md,rs/moq-gst/README.md): document the Homebrew install path and the expanded Nix plugin set.
I compared all changed files against the original commit and they match. The two documented backport divergences are sound: the release justfile keeps its own structure, and release carries no gst-brew-path quest to remove (confirmed: file absent, no references). The new workflow step calls a just recipe, so the check-runs guard is satisfied.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: be7f785
No actionable bugs found. This backport fixes the archive/formula path mismatch at its source and retains the original installer’s ownership guard and installed-plugin identity check. Extending the existing Nix wrapper is appropriately scoped; no API or wire changes are introduced. The release-specific justfile resolution preserves existing FFI tooling.
Verification: static comparison with #5216 and inspection of surrounding archive, formula-rendering and release workflow code. I did not run tests or verify a current-head macOS formula installation.

Problem
The
moq-gstHomebrew formula on the tap (0.4.20, rendered fromrelease) installsDir["lib/libgstmoq.*"], but the release tarball puts the plugin underlib/gstreamer-1.0/. The glob is empty, sobrew install moq-dev/tap/moq-gstinstalls no plugin. moq-dev/moq#5216 fixed this onmainon 2026-10-11;releasenever got it, andrelease-brew.ymlrenders the formula from the tagged commit, so the nextmoq-gstrelease would ship the broken formula again.Approach
Cherry-pick of 98d2c0872 (
-x). The formula installs the exact platform library into its ownlib/gstreamer-1.0/, itsbrew testuses an isolated registry and checksgst-inspectloads that file, and the macOS tarball job installs and tests the rendered formula before release. The Nixmoq-gstwrapper gainsgst-plugins-uglyandgst-libavand checksmoq,x264enc,avenc_aac, andavdec_h264inpostBuild.Conflicts, resolved by hand:
.github/justfile: keptrelease'sffirecipe beside the newgst-formularecipe, and droppedmain-onlysh/changed.test.pyfromtest.quest/m1/README.md: keptrelease's; it never listed the deletedgst-brew-pathquest.Impact
$(brew --prefix moq-gst)/lib/gstreamer-1.0, which users add toGST_PLUGIN_PATH_1_0(documented indoc/bin/gstreamer.mdand the formula caveats).Releasing
moq-gstNothing here publishes or tags. After this merges into
release:rs/moq-gst/README.md(underrs/**), so Release RS runsjust rs release. Itsrelease-plz release-prrefreshes the openchore: releasePR, moq-dev/moq#7325, which already bumpsmoq-gst0.4.20 to 0.4.21. If that run is skipped, dispatchrelease-rs.ymlonrelease.release-plz releasepublishes the crates it bumps, includingmoq-gst0.4.21, and pushes tagmoq-gst-v0.4.21with the moq-bot token.moq-gst.yml: the tarballs build, the new macOS step installs and tests the rendered formula against the real archive, then themoq-gst v0.4.21GitHub release is created and apt/rpm publishing is triggered.release-brew.yml, which checks out the tag, renders.github/homebrew/Formula/moq-gst.rb.tmplfrom it, and pushes the formula tomoq-dev/homebrew-tap.Formula/moq-gst.rbinstallslib/gstreamer-1.0/libgstmoq.*, andbrew install moq-dev/tap/moq-gst && brew test moq-gstpasses on Apple Silicon.moq-dev/moq#7325 bundles every crate bump pending on
release, so step 2 releases all of them, not onlymoq-gst.Alternatives
main: leaves the tap installing nothing until then.release's template at the nextmoq-gstrelease.Follow-ups
None.
Checks
just check origin/release: pass. An unscopedjust checkonreleasefails attscwith TS5112 in TypeScript this diff does not touch.python3 sh/gh/gst-formula.test.py: 3 tests pass.nix build .#moq-gst: pass;postBuildfindsmoq,x264enc,avenc_aac, andavdec_h264.moq-gst-v*tag or a dispatch ofmoq-gst.yml; not run locally (Linux host).Review
quest review --base origin/release, round 1)(Written by Claude Opus 5.5)
🤖 Generated with Claude Code