Repository navigation
chore: release - #7651
chore: release#7651
Conversation
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: c76f1c9
P3 — Remove the duplicate release section (rs/moq-tokio/CHANGELOG.md:10–25). The generated 0.19.32 heading and fixed entry appear twice, once in the new block and once already in the release base. Remove the extra block or correct the release-plz base/changelog state before publication.
The web-transport-proto 0.6.4 lockfile refresh adds credential Debug redaction; no other actionable defect found. Verification: static GitHub comparison only; no build, tests or publication checks run.
There was a problem hiding this comment.
Important
The generated moq-tokio changelog now carries two identical ## [0.19.32] sections. Worth resolving before merge: release-plz parses existing entries when it regenerates the file, and this repo has previously had malformed changelogs block the release run.
Reviewed changes
Cargo.lock— updates the externalweb-transport-protocrate from0.6.3to0.6.4(generated).rs/moq-tokio/CHANGELOG.md— prepends a second## [0.19.32]section (with- releaseand- format the release backport) above the identical section already on the base branch.
ℹ️ No version bumps in the diff; every release in the PR body is already on release
The PR body lists 28 crates moving to new versions, but the diff contains no Cargo.toml changes — base release (6e43cd614) is already at those versions, and moq-tokio's Cargo.toml is 0.19.32 on both sides. The matching moq-tokio-v0.19.32 tag does not exist (latest is v0.19.31, while kio-v0.6.4 does exist), so release-plz appears to be re-proposing an already-committed release, which is what yields the duplicated changelog entry. The only substantive effect of this PR is the malformed changelog plus the incidental lockfile bump; worth confirming whether it should merge at all, or whether the earlier release run needs its tag/publish step repaired instead.
Technical details
# Redundant regeneration of an already-committed release
## Affected sites
- rs/moq-tokio/CHANGELOG.md:18-28 — duplicate `## [0.19.32]` block added
- Cargo.lock — `web-transport-proto` 0.6.3 -> 0.6.4, not mentioned in the PR body
## Evidence
- base `6e43cd614` already contains `## [0.19.32]` in `rs/moq-tokio/CHANGELOG.md` and `version = "0.19.32"` in its `Cargo.toml`
- no `Cargo.toml` files appear in the diff
- remote tags: `moq-tokio-v0.19.32` absent; `kio-v0.6.4` present (points at `a15652d42`)
## Open questions for the human
- Is this PR meant to re-trigger publish/tagging for the crates whose tags are missing?
- If so, should the changelog duplicate be cleaned here or left to a corrected `release-plz` run?deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
c76f1c9 to
13c05c4
Compare
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 13c05c4
P2 — Describe the credential-redaction fixes in release notes (rs/moq-auth/CHANGELOG.md:10–15, rs/moq-net/CHANGELOG.md:10–15, rs/moq-relay/CHANGELOG.md:10–15). The new sections list only duplicate merge messages, omitting #7482's security-relevant diagnostic redaction changes. Replace the merge noise with concise fix entries and check the downstream generated release notes so consumers can identify the change.
The prior duplicate moq-tokio 0.19.32 section is fixed. The generated version and lock updates otherwise appear consistent. Verification: static GitHub comparison only; no builds, tests or publication checks run.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
The commit 13c05c4bd turns this into a complete release: it adds the version bumps the PR body had described but the earlier revision did not carry.
- Bumped 26 workspace crates'
Cargo.tomlversions (moq-net0.3.19 → 0.3.20,moq-tokio0.19.32 → 0.19.33,moq-relay0.17.11 → 0.17.12, and the rest of the PR body's list), with the matching internal dependency pins updated in the rootCargo.toml. - Refreshed
Cargo.lockto the same versions; every bumped package matches itsCargo.tomlpin. - Regenerated each crate's
CHANGELOG.mdwith a## [Unreleased]marker and a new version section. - Resolved the prior duplicate in
rs/moq-tokio/CHANGELOG.md; there is now a single## [0.19.32]block plus the new## [0.19.33].
A sweep of every changed changelog found no duplicate full version headings introduced here. The repeated ## [0.19.11] / ## [0.19.12] headings in rs/moq-tokio/CHANGELOG.md are pre-existing artifacts of the moq-native → moq-tokio rename (distinct compare links per heading), not part of this diff.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
13c05c4 to
51e93fc
Compare

🤖 New release
moq-net: 0.3.19 -> 0.3.20 (✓ API compatible changes)moq-tokio: 0.19.32 -> 0.19.33 (✓ API compatible changes)moq-auth: 0.2.3 -> 0.2.4 (✓ API compatible changes)moq-uring: 0.0.21 -> 0.0.22 (✓ API compatible changes)moq-boy: 0.5.21 -> 0.5.22moq-relay: 0.17.11 -> 0.17.12 (✓ API compatible changes)moq-cli: 0.14.11 -> 0.14.12moq-json: 0.5.17 -> 0.5.18hang: 0.21.20 -> 0.21.21moq-binary: 0.1.19 -> 0.1.20moq-loc: 0.2.28 -> 0.2.29moq-mux: 0.10.20 -> 0.10.21moq-audio: 0.1.19 -> 0.1.20moq-video: 0.1.19 -> 0.1.20libmoq: 0.6.21 -> 0.6.22moq-archive: 0.0.20 -> 0.0.21moq-hls: 0.5.20 -> 0.5.21moq-stats: 0.2.21 -> 0.2.22moq-rtc: 0.3.21 -> 0.3.22moq-rtmp: 0.3.20 -> 0.3.21moq-srt: 0.3.20 -> 0.3.21moq-transcode: 0.1.19 -> 0.1.20moq-e2ee: 0.0.20 -> 0.0.21moq-ffi: 0.4.21 -> 0.4.22moq-gst: 0.4.21 -> 0.4.22moq-room: 0.2.20 -> 0.2.21Changelog
moq-netmoq-tokiomoq-authmoq-uringmoq-boymoq-relaymoq-climoq-jsonhangmoq-binarymoq-locmoq-muxmoq-audiomoq-videolibmoqmoq-archivemoq-hlsmoq-statsmoq-rtcmoq-rtmpmoq-srtmoq-transcodemoq-e2eemoq-ffimoq-gstmoq-roomThis PR was generated with release-plz.