Repository navigation
refactor(ffi): poll background work from one runtime root #7720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+631
−190
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6bac229
chore(quest): claim quest/m1/poll-first/no-spawn/ffi.md
kixelated 6affaf0
refactor(ffi): own background work in one runtime driver
kixelated 623aaa5
test(ffi): exercise JVM exit from the shared root callback
kixelated 6b249bf
docs(ffi): clarify poll isolation and driver teardown ownership
kixelated 4438a09
chore(quest): retain callback independence as an open root-driver dec…
kixelated 37f6345
fix(ffi): dispatch host wakes raised by the root off its poll
kixelated 384936c
Merge remote-tracking branch 'origin/main' into t3/da04c47b
kixelated c2682dc
style(ffi): format the continuation dispatch test
kixelated 84d1ca9
chore(quest): finish quest/m1/poll-first/no-spawn/ffi.md
kixelated 89aaf8f
chore(quest): record moq-ffi's wake dispatch among the spawns that stay
kixelated be686ac
fix(ffi): release enrolled children inside the root marker
kixelated 353c869
style(ffi): take the child set with mem::take
kixelated 8b0429e
chore(quest): finish quest/m1/demand-cancel-race.md
kixelated 0c25ceb
Merge base into PR #7720, preserving both appended test groups
16fe7cb
quest land: merge tested base
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 3134
Script executed:
Repository: moq-dev/moq
Length of output: 8777
Script executed:
Repository: moq-dev/moq
Length of output: 1348
Script executed:
Repository: moq-dev/moq
Length of output: 6173
Wrap the warmup rounds in
ROUND_TIMEOUT, as the measured rounds are.Warmup calls
round(n)with no timeout. If a child never acknowledges a pulse, warmup blocks. Nextest then kills the test after about 60 seconds, and theroot wedgedpanic never runs. Apply the same timeout to warmup.Suggested fix
Committable suggestion