Repository navigation
quest: report every group a subscriber gives up on #7890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
77a1848
quest: plan reporting every group a subscriber gives up on
kixelated ceca525
Merge origin/main
kixelated 5a81676
quest: scope group drops to moq-lite, name its measurement, order it …
kixelated 8d233f1
quest: group drops' API impact depends on its shape
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| # [M] A group a subscriber gives up on is always reported | ||
|
|
||
| ## Goal | ||
|
|
||
| Every group a moq-lite subscriber gives up on surfaces to the application: no | ||
| group vanishes because its stream was stopped or evicted before its header was | ||
| read. On the wire, the subscriber always learns the sequence of a group it | ||
| abandoned; moq-transport reports what its wire allows, and the PR records any | ||
| gap there. | ||
| In the API, `track::Subscriber`'s drop signal (today the crate-private | ||
| `poll_drop`, which the ordered reader and resume use to skip gaps) is public, | ||
| so the receive-windows benchmark and applications can count losses instead of | ||
| waiting forever. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-04 with the maintainer, from | ||
| [moq-dev/moq#7838](https://github.com/moq-dev/moq/pull/7838). Under that | ||
| benchmark's overload policy, overcommitted cells hang. Sometimes the subscriber | ||
| drops a group without `recv_group` ever returning it: either the group's stream | ||
| was evicted before its header was read, or the group was evicted and so was the | ||
| FETCH that refetched it. No public API reports that group, so a reader that | ||
| paces on delivered-or-evicted groups stalls. The 4 MiB-frame cell hits this on | ||
| every run; the 256-stream cell sometimes does. | ||
|
|
||
| - ✅ **Milestone m1** (maintainer, 2026-11-04): it changes public API and | ||
| possibly lite-07 wire, so it lands before the cut. | ||
| - ✅ **The wire mechanism is this quest's call, with numbers** (maintainer, | ||
| 2026-11-04). Compare: | ||
| - **The publisher answers STOP_SENDING with SUBSCRIBE_DROP.** Lite already | ||
| sends SUBSCRIBE_DROP on the control stream when a group fails at the | ||
| publisher (`GroupServe::settle_failed`, `rs/moq-net/src/lite/publisher.rs`, | ||
| versions with a track stream), but a subscriber's STOP_SENDING doesn't | ||
| produce one. | ||
| - **The subscriber reads a group's header before it stops or evicts that | ||
| stream.** | ||
|
|
||
| Doing both is fine if each is needed. The numbers come from the | ||
| receive-windows benchmark's overcommitted cells (256 streams, 4 MiB frames, | ||
| follow; `rs/moq-tokio/tests/integration/receive_credit.rs`), which | ||
| [moq-dev/moq#7838](https://github.com/moq-dev/moq/pull/7838) skips until | ||
| this lands: each must finish, with `delivered_frames` plus the reported | ||
| drops accounting for every group sent. Compare their throughput and the | ||
| control-stream bytes each mechanism adds. Start with the maintainer's question: | ||
| why does the subscriber stop or evict a stream before reading its header at | ||
| all? If receive-window eviction can wait for the header, the wire half may | ||
| shrink to that. Cover moq-transport too, or say why it differs. | ||
|
kixelated marked this conversation as resolved.
Resolved
|
||
| - **Public drop signal.** Make the drop signal public in Rust. Choose its | ||
| shape here: a separate read named like the existing ones (for example | ||
| `recv_drop` returning the given-up run and its error), or a drop variant on | ||
| `recv_group`, the way container consumers already read `Frame | Gap | End`. | ||
| Prefer folding it into an existing read if that reads as naturally. The | ||
| ordered reader and resume keep using it internally. Its first consumer is | ||
| the receive-windows benchmark. Mirror it in `@moq/net` and the bindings only | ||
| for a named consumer (for example a player or container reader that skips | ||
| gaps), per the [API audit](/quest/m1/api-audit/README.md) rule that new | ||
| surface needs one; name it in the PR or leave the mirror out. | ||
| - **Order with the [drop set](/quest/m1/drop-set.md).** The drop set | ||
| replaces `poll_drop`'s `Delivered` argument and the skipped record, and | ||
| edits the lite-07 SUBSCRIBE_DROP wording. Land the wire half whenever it's | ||
| ready, but publish the API after the drop set, against its final | ||
| disposition record, so the public shape doesn't change twice. | ||
| - The drop set owns the per-cursor drop runs and their reasons. This quest | ||
| reports what a cursor gives up; it doesn't change how a cursor judges a | ||
| missing group. | ||
|
|
||
| Public API: additive for a separate read; breaking if folded into `recv_group` | ||
| (its `Result<Option<group::Consumer>>` return changes for every caller), with | ||
| MIGRATE notes. `@moq/net` and the bindings mirror it only with a named consumer. | ||
| Wire: possibly lite-07 (SUBSCRIBE_DROP for a stopped group), decided here. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Drop set](/quest/m1/drop-set.md) - owns the per-cursor drop runs this reports | ||
| - [The receive-windows benchmark](/quest/m0/nightly/receive-windows-evicted.md) - its overcommitted cells wait on this (skipped by [moq-dev/moq#7838](https://github.com/moq-dev/moq/pull/7838) until it lands) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.