Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ their end report, so an embedder's drain alert pages on real cuts.
- [A job's exact route continues its claim's readers](/quest/m1/announce-takeover.md) - a job's route inherits its claim's instance, replacing the ANNOUNCE_TAKEOVER predecessor design
- [Subscribe ranges](/quest/m1/subscribe-ranges/README.md) - a lite-07 SUBSCRIBE asks for past and live ranges with absolute or relative ends, in either order, and replaces FETCH; merged ranges never starve a subscriber; relays fill misses by range, including over moq-transport
- [Drop set](/quest/m1/drop-set.md) - each cursor judges missing groups against its own budget, so a narrow reader drops promptly and a widening re-offers groups already reported dropped on lite-07
- [A group a subscriber gives up on is always reported](/quest/m1/group-drops.md) - the wire names every abandoned group and the drop signal is public, so readers count losses instead of stalling
- [Datagram tracks](/quest/m1/datagram-tracks/README.md) - a track is datagrams or streams; datagram tracks have their own request and sequence, no ranges, no cache, and map to object ID 0 on moq-transport
- [A routed JS read wakes when its track aborts](/quest/m1/js-follow-abort-wake.md) - a pending `readFrame()` on a group found through `request()`/`follow()` rejects on `track.abort()`
- [Stream credit by priority](/quest/m1/stream-credit/README.md) - every stream opens through one priority entry point, and a higher-priority group takes over or resets a lower one when credit runs out
Expand Down
75 changes: 75 additions & 0 deletions quest/m1/group-drops.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
# [M] A group a subscriber gives up on is always reported

## Goal

Every group a moq-lite subscriber gives up on surfaces to the application: no
group vanishes because its stream was stopped or evicted before its header was
read. On the wire, the subscriber always learns the sequence of a group it
abandoned; moq-transport reports what its wire allows, and the PR records any
gap there.
In the API, `track::Subscriber`'s drop signal (today the crate-private
`poll_drop`, which the ordered reader and resume use to skip gaps) is public,
so the receive-windows benchmark and applications can count losses instead of
waiting forever.

## Plan

Planned 2026-11-04 with the maintainer, from
[moq-dev/moq#7838](https://github.com/moq-dev/moq/pull/7838). Under that
benchmark's overload policy, overcommitted cells hang. Sometimes the subscriber
drops a group without `recv_group` ever returning it: either the group's stream
was evicted before its header was read, or the group was evicted and so was the
FETCH that refetched it. No public API reports that group, so a reader that
paces on delivered-or-evicted groups stalls. The 4 MiB-frame cell hits this on
every run; the 256-stream cell sometimes does.

- ✅ **Milestone m1** (maintainer, 2026-11-04): it changes public API and
possibly lite-07 wire, so it lands before the cut.
- ✅ **The wire mechanism is this quest's call, with numbers** (maintainer,
Comment thread
kixelated marked this conversation as resolved.
Resolved
2026-11-04). Compare:
- **The publisher answers STOP_SENDING with SUBSCRIBE_DROP.** Lite already
sends SUBSCRIBE_DROP on the control stream when a group fails at the
publisher (`GroupServe::settle_failed`, `rs/moq-net/src/lite/publisher.rs`,
versions with a track stream), but a subscriber's STOP_SENDING doesn't
produce one.
- **The subscriber reads a group's header before it stops or evicts that
stream.**

Doing both is fine if each is needed. The numbers come from the
receive-windows benchmark's overcommitted cells (256 streams, 4 MiB frames,
follow; `rs/moq-tokio/tests/integration/receive_credit.rs`), which
[moq-dev/moq#7838](https://github.com/moq-dev/moq/pull/7838) skips until
this lands: each must finish, with `delivered_frames` plus the reported
drops accounting for every group sent. Compare their throughput and the
control-stream bytes each mechanism adds. Start with the maintainer's question:
why does the subscriber stop or evict a stream before reading its header at
all? If receive-window eviction can wait for the header, the wire half may
shrink to that. Cover moq-transport too, or say why it differs.
Comment thread
kixelated marked this conversation as resolved.
Resolved
- **Public drop signal.** Make the drop signal public in Rust. Choose its
shape here: a separate read named like the existing ones (for example
`recv_drop` returning the given-up run and its error), or a drop variant on
`recv_group`, the way container consumers already read `Frame | Gap | End`.
Prefer folding it into an existing read if that reads as naturally. The
ordered reader and resume keep using it internally. Its first consumer is
the receive-windows benchmark. Mirror it in `@moq/net` and the bindings only
for a named consumer (for example a player or container reader that skips
gaps), per the [API audit](/quest/m1/api-audit/README.md) rule that new
surface needs one; name it in the PR or leave the mirror out.
- **Order with the [drop set](/quest/m1/drop-set.md).** The drop set
replaces `poll_drop`'s `Delivered` argument and the skipped record, and
edits the lite-07 SUBSCRIBE_DROP wording. Land the wire half whenever it's
ready, but publish the API after the drop set, against its final
disposition record, so the public shape doesn't change twice.
- The drop set owns the per-cursor drop runs and their reasons. This quest
reports what a cursor gives up; it doesn't change how a cursor judges a
missing group.

Public API: additive for a separate read; breaking if folded into `recv_group`
(its `Result<Option<group::Consumer>>` return changes for every caller), with
MIGRATE notes. `@moq/net` and the bindings mirror it only with a named consumer.
Wire: possibly lite-07 (SUBSCRIBE_DROP for a stopped group), decided here.

## Related

- [Drop set](/quest/m1/drop-set.md) - owns the per-cursor drop runs this reports
- [The receive-windows benchmark](/quest/m0/nightly/receive-windows-evicted.md) - its overcommitted cells wait on this (skipped by [moq-dev/moq#7838](https://github.com/moq-dev/moq/pull/7838) until it lands)
Loading