Repository navigation
quest: plan follow-ups from the 2026-11-05 merge batch #7930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # [XS] macOS CI runs kio's tests | ||
|
|
||
| ## Goal | ||
|
|
||
| The macOS test job runs `kio`'s tests, so platform-dependent kio failures, | ||
| such as the `Mutex` size assumption | ||
| [moq-dev/moq#7914](https://github.com/moq-dev/moq/pull/7914) fixed, fail CI | ||
| instead of reaching main. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-11-05 (maintainer, follow-up from #7914): ✅ m0. | ||
|
|
||
| `just rs macos-test` (`rs/justfile`) tests hang, moq-tokio, moq-sock, | ||
| moq-video, and moq-auth, but not kio. Add it, and check the job's time stays | ||
| reasonable. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # [S] The desktop host's Nix builders may map user namespaces | ||
|
|
||
| ## Goal | ||
|
|
||
| On the desktop host, where agents run their local gates, `just ci` builds the | ||
| flake's runner image instead of failing `check flake`, and `just check` runs | ||
| it instead of skipping. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-11-05 (maintainer, follow-up seen in | ||
| [moq-dev/moq#7918](https://github.com/moq-dev/moq/pull/7918), | ||
| [moq-dev/moq#7684](https://github.com/moq-dev/moq/pull/7684), | ||
| [moq-dev/moq#7858](https://github.com/moq-dev/moq/pull/7858), and | ||
| [moq-dev/moq#7883](https://github.com/moq-dev/moq/pull/7883)): ✅ m0. | ||
|
|
||
| Each of those gates failed `check flake` while building `github-runner`, with | ||
| `unshare: write failed /proc/self/uid_map: Operation not permitted`. `just ci` | ||
| sets `CI_STRICT`, so the check fails there; without it, | ||
| `nix/runner/userns-probe.nix` and `sh/dispatch.sh` detect the refusal and skip, | ||
| which is why [moq-dev/moq#7763](https://github.com/moq-dev/moq/pull/7763) | ||
| retired the earlier quest. This quest fixes the host instead, so nothing fails | ||
| or skips. | ||
|
|
||
| As of 2026-11-05 the probe fails on the desktop host (Ubuntu 26.04, where | ||
| `kernel.apparmor_restrict_unprivileged_userns = 1` and even a plain | ||
| `unshare --map-root-user true` is refused) and passes on `nixos`. Lift | ||
| AppArmor's restriction for Nix builds there, persistently and as narrowly as | ||
| works, apply it when no gate is running, and check that the probe succeeds and | ||
| `just ci` passes `check flake`. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # [S] moq-ffi's datagram tests don't hinge on one datagram | ||
|
|
||
| ## Goal | ||
|
|
||
| `datagrams_cross_a_default_connection` and its `requested_` sibling | ||
| (`rs/moq-ffi/src/test.rs`) pass reliably under CI load, without depending on | ||
| a single unreliable datagram arriving. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-11-05 (maintainer, follow-up from | ||
| [moq-dev/moq#7914](https://github.com/moq-dev/moq/pull/7914)): ✅ m0. | ||
|
|
||
| The test sends one datagram over a real connection and waits 10 s for it; | ||
| it timed out in Check on #7914 while passing 30 of 30 runs on an idle host. | ||
| Confirm the cause first. If it's loss, keep writing datagrams until the first | ||
| arrives and assert on what arrives, rather than waiting longer. If it's the | ||
| datagram answer race planned in | ||
| [moq-dev/moq#7929](https://github.com/moq-dev/moq/pull/7929) | ||
| (`quest/m1/datagram-tracks/answer-race.md`), say so here and wait on that | ||
| quest instead. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # [XS] release.test.ts never reaches the network | ||
|
|
||
| ## Goal | ||
|
|
||
| `js/common/release.test.ts` runs without network access and never times out | ||
| on a live registry lookup, so it can't drop an unrelated PR from the merge | ||
| queue. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-11-05 (maintainer, follow-up from the queue drop of | ||
| [moq-dev/moq#7867](https://github.com/moq-dev/moq/pull/7867)): ✅ m0. | ||
|
|
||
| `the JSR token reaches only deno publish` timed out at 5 s in a | ||
| `merge_group` build: its fixture runs `release.ts` with `jsr=true` and | ||
| `dryRun=false`, which makes a live jsr.io metadata lookup. The land fixer | ||
| reproduced the timeout under `unshare -rn`. Inject that lookup, the way the | ||
| test already fakes the publish commands, so the whole suite passes offline. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # [M] A collapsing uplink lowers the bandwidth estimate promptly | ||
|
|
||
| ## Goal | ||
|
|
||
| When a path's capacity collapses, the bandwidth estimate a sender reports | ||
| (the grant simulcast rungs follow) falls as soon as BBR3's own loss response | ||
| cuts, instead of holding the old rate for seconds. A before-and-after | ||
| measurement with the sparse-sender shaper harness shows the drop. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-11-05 (maintainer, follow-up from | ||
| [moq-dev/moq#7671](https://github.com/moq-dev/moq/pull/7671)): ✅ the | ||
| reported estimate also honors BBR3's loss-driven bound; m1, beside the native | ||
| rung-disable proof. Not chosen: m2, or an investigation-only quest. | ||
|
|
||
| Evidence from #7671's sparse harness: after the path fell from 2 Mbit/s to | ||
| 100 kbit/s, the estimate held 1.32 Mbit/s for about 11 s, and in the FFI run | ||
| the top rung disabled 5.6 s after the 500 kbit/s step. The probe idles while | ||
| the estimate covers the target, and the reported estimate | ||
| (`max_bw.min(bw_delay)` in `metrics`, `rs/moq-congestion/src/bbr3/mod.rs`) | ||
| ignores the loss bounds BBR3 keeps: `bw_shortterm`, which | ||
| `bound_bw_for_model` already folds into the model's `bw`, and the inflight | ||
| bounds `inflight_longterm` and `inflight_shortterm`. Measure first, change | ||
| second, and record both runs. Keep the change inside the reported estimate | ||
| unless the measurement shows the control loop itself is late. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # [M] A replacement that fails before delivering never ends a live track | ||
|
|
||
| ## Goal | ||
|
|
||
| When a route change splices a replacement source under a front, and the | ||
| replacement answers with metadata and then aborts before delivering any | ||
| group, readers keep receiving from the source that was serving before. The | ||
| track ends only when no source is left to serve it. | ||
|
|
||
| Not in scope: the producer-replacement redesign | ||
| ([Resume as producer replacement](/quest/m2/resume-redesign.md)), which | ||
| replaces this machinery later. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-11-05 (maintainer, follow-up from | ||
| [moq-dev/moq#7789](https://github.com/moq-dev/moq/pull/7789)): ✅ its own m1 | ||
| quest, fixed now. Not chosen: leaving it to the m2 redesign. | ||
|
|
||
| #7789 fixed the case where the replacement aborts before the front reads its | ||
| answer, which now counts as a refusal. The remaining race is an abort after | ||
| the front's poll. `Front::track_info` (`rs/moq-net/src/model/front.rs`) | ||
| clears `draining` on splice, so the later `track_ended` refusal has no | ||
| incumbent to return to, and the track ends with the replacement's error. | ||
| Main has it too. Recommended fix: keep the incumbent's copy until the | ||
| replacement delivers its first group, then release it. Reproduce it first | ||
| with a test beside #7789's | ||
| `a_replacement_aborted_without_history_keeps_the_incumbent` | ||
| (`rs/moq-net/src/model/origin.rs`), and check whether `js/net` has the same | ||
| race. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # [S] TLS reload follows symlinked certificate files | ||
|
|
||
| ## Goal | ||
|
|
||
| Rewriting a certificate or key in place reloads it when the configured path | ||
| is a symlink whose target lives outside the configured file's directory. This | ||
| covers roots, served chains, and client certificates. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-11-05 (maintainer, follow-up from | ||
| [moq-dev/moq#7906](https://github.com/moq-dev/moq/pull/7906)): ✅ m2. | ||
|
|
||
| `watch::callback` (`rs/moq-tokio/src/watch.rs`) watches each configured | ||
| file's directory. Its filter already reloads when a path resolves somewhere | ||
| new, which covers a Kubernetes `..data` swap and a repointed link, but an | ||
| in-place write to a target in an unwatched directory raises no event. Also | ||
| watch the directories the configured paths resolve to, and move those watches | ||
| when a resolution changes. Tests drive the watcher with controlled events, not | ||
|
Comment on lines
+15
to
+19
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| wall-clock waits. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 20377
Script executed:
Repository: moq-dev/moq
Length of output: 20620
Script executed:
Repository: moq-dev/moq
Length of output: 11893
Script executed:
Repository: moq-dev/moq
Length of output: 1494
Script executed:
Repository: moq-dev/moq
Length of output: 21394
Correct the macOS kio goal: this change does not catch regressions before merge to main.
The goal says macOS kio failures "fail CI instead of reaching main." Main PRs run no macOS job before merge. Adding kio to
macos-testruns only nightly on main and on release PRs. State this coverage in the goal, or add a pre-merge macOS job.