Repository navigation
fix(mux)!: flag PCR discontinuities only when the clock jumps #7981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0f802b9
chore(quest): claim quest/m1/ts-reliability/pcr-jump-flag.md
kixelated 33e929a
fix(mux): flag PCR discontinuities when the schedule skips slots
kixelated 3f948f4
fix(mux): derive the PCR flag from scheduled clock jumps
kixelated 8f532eb
test(mux): grade PCR values independently of VBR packet density
kixelated b0b8834
chore(quest): retain the interop tooling blocker
kixelated 5084a12
fix(mux): retain send-ahead after timestamp gaps
kixelated c6a41e4
chore: merge main for interop validation
kixelated cdda973
chore(quest): finish PCR jump flag quest
kixelated f6c945b
chore(quest): size remaining TS guide work
kixelated b224cf3
test(ffi): quarantine flaky concurrent ready wake test
kixelated 86d658d
docs(mux): clarify when PCR clock jumps are flagged
kixelated faf8418
chore: move FFI quarantine ownership to separate PR
kixelated 1191cc6
Merge remote-tracking branch 'origin/main' into iterate-7981
kixelated 15d8466
test(mux): remove duplicate padded outage coverage
kixelated 6c1e411
docs(test): name retained disjoint outage coverage
kixelated 8916dc2
test(net): quarantine the lite-06 datagram end/close flake
pullfrog[bot] 212cb77
fix(mux): preserve the running schedule when changing delay
kixelated 114f0fc
docs(quest): link retained PCR recovery validation
kixelated 1e62fff
fix(mux): retain jitter state across delay changes
kixelated 417b876
Merge main and preserve both flake follow-up lists
kixelated 546a154
Merge origin/main into PCR discontinuity fix
kixelated 7f0175e
fix(mux)!: configure TS delay only during construction
kixelated dc359ab
quest: record construction-only TS delay decision
kixelated c39da7d
quest: drop completed P2P test link after main merge
kixelated 378a5a4
test(cli): pass TS delay through export fixtures
kixelated ee199d6
test(mux): configure round-trip recording delay at construction
kixelated 58fa002
fix(mux): construct programs with their final delay
kixelated 5091311
Merge base and reconcile datagram quarantine notes
672f834
Merge branch 'base' into pr-7981
19aa8c9
docs: nest datagram investigation under the quest plan
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,13 @@ | ||
| # [S] The TS export flags a PCR only where its clock jumps | ||
| # [S] Validate PCR jumps across recovery | ||
|
|
||
| ## Goal | ||
|
|
||
| `moq export ts` sets `discontinuity_indicator` on a PCR exactly when the | ||
| time base it asserts breaks: a declared switch, as today, or a schedule that | ||
| skips empty slots so the PCR jumps past the bytes between. A delivery skip the | ||
| schedule pads on a continuing clock goes out unflagged, a gap in the programme | ||
| and not a new time base. | ||
| Validate actual-PCR-jump flags in the remaining TS recovery interop coverage. | ||
|
|
||
| ## Plan | ||
|
|
||
| Reported in [moq-dev/moq#7965](https://github.com/moq-dev/moq/issues/7965), | ||
| a correction to [moq-dev/moq#7741](https://github.com/moq-dev/moq/issues/7741): | ||
| in a live relay-kill run the export padded a 7 s outage with nulls on an | ||
| unbroken 25 ms PCR grid, and every PID's DTS kept its offset to the PCR. So | ||
| [moq-dev/moq#7785](https://github.com/moq-dev/moq/pull/7785), which flags | ||
| every delivery skip, declared a new time base equal to the old one there. | ||
| Verified against `main`: the claim holds for holes the schedule pads, but | ||
| `Schedule::index` (`rs/moq-mux/src/container/ts/schedule.rs`) skips the | ||
| empty slots of a gap longer than `BACKFILL` (1 s), and that PCR does jump. | ||
| `a_skipped_group_flags_the_clock` runs 6 s holes through that path. | ||
| Decided 2026-11-06 (maintainer, /quest-unblock): ✅ Continue the actual-PCR-jump approach. Not chosen: rethink; drop the PR. | ||
|
|
||
| Decided 2026-11-05 (maintainer, /quest-import of #7965): | ||
| Decided 2026-11-06 (maintainer, /quest-unblock): ✅ Reproduce and fix the Rust `with_delay` schedule replacement in this PR. Hand the unrelated JS decoded-end/session-failure finding to [datagram-end-close](/quest/m0/test-flakes-2/datagram-end-close.md). Not chosen: fixing both findings here. | ||
|
|
||
| - ✅ Flag real jumps only: derive the flag from the schedule, set on the first | ||
| PCR after it skips slots, whatever caused the gap, so a source stall with | ||
| no delivery skip is flagged too. Delete #7785's per-track loss tracking | ||
| (`Track::{gap, last_timestamp, lost}`, `coalesce`, `Queued::gap`, | ||
| `PesUnit::skipped`, `Schedule::{gap, skip}`), and the 2026-11-05 | ||
| coalescing decision in the epic README goes with it. Not chosen: keeping | ||
| the flag as a skip marker and rewording its docs (it misstates the time | ||
| base); reverting #7785 (a hole past the backfill would again carry an | ||
| unflagged PCR jump); won't fix. | ||
| - ✅ m1, in the TS reliability epic. | ||
|
|
||
| Rework the tests to match: holes the schedule pads carry no flag and keep the | ||
| PCR's repetition health clean; holes past the backfill carry one flag each on | ||
| the first PCR after the jump. Fix `doc/bin/cli.md` and `test/ts/README.md`, | ||
| which describe the skip flag. | ||
|
|
||
| ## Closes | ||
|
|
||
| - [#7965](https://github.com/moq-dev/moq/issues/7965) - `export ts`: the skip #7741 reported keeps its clock | ||
| Decided 2026-11-06 (maintainer, /quest-unblock): ✅ Construction-only delay supersedes runtime updates. TS Export and Release take delay when constructed, so retained state never changes its delay basis. Not chosen: full runtime retiming; landing without the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 42081
Script executed:
Repository: moq-dev/moq
Length of output: 18048
Script executed:
Repository: moq-dev/moq
Length of output: 9077
Distinguish the failed run’s fixture from the current test.
The current test drains 10,000 microtasks and disables
Budget.poll. The currentrunResponsesloop does not poll a budget. The stated cause can therefore misdirect the investigation. Identify the fixture used in the failed run and update the description of the current path.