Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions js/net/src/ietf/publisher.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2663,10 +2663,10 @@ test("draft-22: a backwards range within one group serves nothing and ends the s
}
});

// Quarantined: the live group intermittently resets while read.
// Investigation: quest/m0/test-flakes-2/ietf-wider-fill.md.
test.skip.each(["ascending", "descending"] as const)("draft-22: a wider fill is refused in %s order", async (order) => {
test.each(["ascending", "descending"] as const)("draft-22: a wider fill is refused in %s order", async (order) => {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
const fx = fixture();
// No max age: group 9 is served live, and a zero budget would give it up mid-write once the
// live group supersedes it, racing this test's read of the refused fill.
const track = fx.broadcast.createTrack("video", { timescale: Timescale.MILLI, maxAge: null });
for (const sequence of [0n, 3n, 9n]) {
const group = track.createGroup(sequence);
Expand All @@ -2691,7 +2691,7 @@ test.skip.each(["ascending", "descending"] as const)("draft-22: a wider fill is
const fill = await nextUni(fx.uni);
if (!fill) throw new Error("missing fill stream");
const served = await readFill(fill, order);
expect(served.reset).toBeDefined();
expect(served.reset).toBeInstanceOf(StreamError);
expect(served.objects).toEqual([]);
const live = track.appendGroup();
live.writeFrame({ payload: new TextEncoder().encode("live"), timestamp: Timestamp.now() });
Expand Down
1 change: 0 additions & 1 deletion quest/m0/test-flakes-2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ Public API: none. Wire: none.
## Required

- [Fallback playback](/quest/m0/test-flakes-2/ietf22-fallback.md) - a browser viewer follows a fallback within the media lane's bound without dropping its session
- [The draft-22 wider-fill refusal test is deterministic](/quest/m0/test-flakes-2/ietf-wider-fill.md) - fix its intermittent live-group reset and re-enable both ordering cases without weakening their assertions
- [reload.test.ts's close-drain tests pass under load](/quest/m0/test-flakes-2/reload-close-drain.md) - the drain cases in `js/net`'s reload tests pass in loaded multi-file runs
- [dispatch-query's terminate test survives load](/quest/m0/test-flakes-2/dispatch-query-terminate.md) - `test_terminating_the_run_stops_the_running_phase` passes reliably under host load, re-enabled once fixed
- [Diagnose and re-enable the FFI datagram connection test](/quest/m0/test-flakes-2/ffi-datagram-roundtrip.md) - diagnose the default-connection timeout and re-enable the quarantined test
Expand Down
35 changes: 0 additions & 35 deletions quest/m0/test-flakes-2/ietf-wider-fill.md

This file was deleted.