Skip to content

quest(ci): delete the five-minute gate quest - #8004

Merged
kixelated merged 1 commit into
mainfrom
quest/m0/ci/five-minutes
Nov 6, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/m0/ci/five-minutes

Conversation

@kixelated

@kixelated kixelated commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Closes quest/m0/ci/five-minutes.md by deleting it with quest rm, which also drops its link from the CI epic. The measurements below, taken with moq-dev/quest's admission changes landed, are the record behind that decision.

Problem

The 2026-11-05 audit dropped the wait on moq-dev/quest's admission work. It asked for the moq-net route to be re-measured with that admission landed, and for this quest to then be finished or narrowed. The default FFI route also needed a rerun without the GRADLE_CMD override, now that moq-dev/moq#7632 has merged.

Approach

Each row is one bench/local.py --checkout . --workers 4 --jobs 3 --samples 1 -- just check HEAD run over a comment-only edit. The loaded runs shared the host with about 25 other agents; the quiet runs fell in a lull.

Edited source Run Admission (s) Work (s) Total (s) Load
rs/moq-net/src/lib.rs loaded preparation 818.8 232.5 1,051.3 30.7
rs/moq-net/src/lib.rs loaded measured 100.9 325.0 426.0 28.7
rs/moq-net/src/lib.rs quiet 0.1 189.3 189.4 5.5
rs/moq-ffi/src/lib.rs loaded preparation 180.6 318.3 498.9 30.3
rs/moq-ffi/src/lib.rs quiet 0.1 204.5 204.6 7.8

The default FFI route passes without the override.

On a quiet host the gate already meets the bound. Under concurrent agents, admission is the largest and least predictable term.

Agent transcripts since the admission changes reached main (2026-11-03 22:51 UTC) agree:

  • Command time alone is mostly under 5 minutes. 178 passing dispatch reports had a median of 172 s. JS went over in 0 of 27 runs, Rust in 5 of 41, and FFI in 9 of 14.
  • Counting admission, many runs exceed it. 154 of 361 Claude Code foreground gate calls (43%) took over 5 minutes, and 72 of those hit the 10-minute command limit.
  • The premise is gone. This /quest-spawn worker's harness reports a 1-hour prompt-cache TTL.

The host benchmark lock blocked every gate

Measuring exposed a regression from moq-dev/moq#7867. just gh test runs bench/build.test.py, which runs bench/run.sh, which takes the host-wide /tmp/moq-bench.lock. So every gate waited in test gh behind any benchmark session. Four open PRs report stalls of 40 to 60+ minutes behind one browser benchmark.

The fix is urgent and needs no decision, so it is a separate ready PR: moq-dev/moq#8029. It stubs the lock in that fixture, as bench/profile.test.py already does.

Levers not taken

Each remaining lever cuts wall time by running more at once, not CPU, so none lands:

  • isolate dart's build directory so dart no longer runs alone
  • run just gh test concurrently
  • overlap the Rust lint's cargo doc with the test run

Impact

  • No public API or wire change. Only quest/m0/ci/five-minutes.md (deleted) and its entry in quest/m0/ci/README.md change.

Decisions

  • ✅ Delete this quest (maintainer, /quest-complete, 2026-11-06). Prompt: does the five-minute bound still stand, now that its premise, a worker's 5-minute prompt cache, no longer holds? Gate cost is left to the CI epic's CPU measure, since the remaining levers add concurrency without saving CPU. Not chosen: narrow the Goal to the gated command's own time; keep the Goal and move it to m1 behind moq-dev/quest's worker cache quest.

Review

Skipped on b6811de5ff: the change only deletes a quest document and its list entry with quest rm, which runs quest check; there is no code to review.

Validation

  • quest check --base origin/main: pass.
  • bash sh/quest.sh gate just check origin/main on head fa4b259deb: pass in 110 s, with test gh at 83 s.
  • quest rm ran quest check on the result: pass. Head b6811de5ff.

Follow-ups

None.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

@kixelated kixelated changed the title Gate each diff in under five minutes quest(ci): re-measure the five-minute gate with landed admission Nov 6, 2026
Its premise, a worker's 5-minute prompt cache, no longer holds; gate cost
is left to the CI epic's CPU measure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated force-pushed the quest/m0/ci/five-minutes branch from fa4b259 to b6811de Compare November 6, 2026 16:36
@kixelated kixelated changed the title quest(ci): re-measure the five-minute gate with landed admission quest(ci): delete the five-minute gate quest Nov 6, 2026
@kixelated
kixelated marked this pull request as ready for review November 6, 2026 16:37
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 603380a0-dc9e-4e1c-81a7-7bf6df0f4c63
Commits

Reviewing files that changed from the base of the PR and between 809994b and b6811de.

Files selected for processing: 2

  • quest/m0/ci/README.md
  • quest/m0/ci/five-minutes.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Deleted quest/m0/ci/five-minutes.md — the whole 161-line quest ("Gate each diff in under five minutes") is removed, recording the maintainer's 2026-11-06 decision that its 5-minute prompt-cache premise no longer holds.
  • Dropped the epic link — quest/m0/ci/README.md loses the quest's only ## Required entry.

Verified against the head: the deleted file matches main's 161 lines exactly, the README carried exactly one reference, and a repo-wide grep for five-minutes, the quest title, and 5-minute prompt (including backticked prose paths that quest check does not validate) finds no leftovers. The Quest check on the PR passes, and the body's cross-PR follow-up, #8029, is merged rather than stale. Deleting outright with no prose record matches the repo's quest convention, and each "What remains" item is either measured in the body or still tracked elsewhere (the hakari quest, the epic's CPU measure).

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: b6811de

No actionable findings in the two-file change. The obsolete five-minute quest is deleted and its CI epic entry is removed, with no changes to gate implementation or test coverage.

Direction: this matches the maintainer decision recorded in the PR and the epic's CPU-cost focus. Retiring the requirement rather than adding concurrency solely to meet a wall-clock target is consistent with that scope.

Validation and limits: GitHub-only static review of the full diff, the head's CI epic, repository guidance, and existing discussion. The Quest check passed for this SHA; the active Check run was still in progress when inspected. I did not run quest context, quest check, just check, or independently reproduce the timing measurements.

@kixelated
kixelated added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 804ce0f Nov 6, 2026
17 checks passed
@kixelated
kixelated deleted the quest/m0/ci/five-minutes branch November 6, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant