Repository navigation
fix(ffi): the concurrent-ready test lets woken calls run between reads #8053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
80574e0
chore(quest): claim quest/m0/test-flakes-2/ffi-concurrent-ready.md
kixelated 4d5fdb1
fix(ffi): the concurrent-ready test lets woken calls run between reads
kixelated 8746376
Merge remote-tracking branch 'origin/main' into quest/m0/test-flakes-…
kixelated d6819f9
Merge remote-tracking branch 'origin/main' into quest/m0/test-flakes-…
kixelated cdfa058
quest land: merge tested base
36e2ba5
Merge base into pr-8053, preserving both test resolution notes
a5b93df
quest land: merge tested base
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
git diff HEAD^ HEAD -- rs/moq-ffi/src/test.rs quest/m0/test-flakes-2/README.md | tail -120Repository: moq-dev/moq
Length of output: 2183
Script executed:
Repository: moq-dev/moq
Length of output: 13726
Script executed:
Repository: moq-dev/moq
Length of output: 19873
Correct the concurrent-ready fix history.
Before this PR, the drain loop already had the 24-read bound and per-read yield. This PR removes
ffi_caught_upfrom that loop. Attribute the bound and yield to the earlier change so maintainers can identify what this PR changed when investigating a recurrence.