Repository navigation
test(interop): re-run the pre-cut audit's regressions and fix two stale browser checks #8059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cd07f51
9e51bf5
afc6024
9be2463
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -728,8 +728,8 @@ test("a selected camera stays announced while real capture is reopening", async | |
| return { publish }; | ||
| }); | ||
|
|
||
| // Muting and hiding only flip each rendition to `enabled: false`: the same tracks stay live and | ||
| // unmuting reopens nothing. | ||
| // Hiding only flips video to `enabled: false` and muting keeps audio enabled while it sends | ||
| // nothing: the same tracks stay live and unmuting reopens nothing. | ||
| const opened = await captured(publication); | ||
| await gate.evaluate((gate) => { | ||
| gate.hold = true; | ||
|
|
@@ -741,7 +741,8 @@ test("a selected camera stays announced while real capture is reopening", async | |
| }); | ||
| await page.waitForFunction( | ||
| ({ publish }) => | ||
| publish.audio.out.catalog.peek()?.enabled === false && | ||
| !!publish.audio.out.catalog.peek() && | ||
| publish.audio.out.catalog.peek()?.enabled === undefined && | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| publish.video.out.catalog.peek()?.enabled === false, | ||
| publication, | ||
| ); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 7437
Script executed:
Repository: moq-dev/moq
Length of output: 20381
Script executed:
Repository: moq-dev/moq
Length of output: 23704
Script executed:
Repository: moq-dev/moq
Length of output: 16493
Script executed:
Repository: moq-dev/moq
Length of output: 10752
Identify the patched tree for the browser results.
The passing results follow the reference to
main 1ae5c5f808, but that commit still has the broken browser fixtures. A release engineer rerunning the checks there can see failures. State that the browser checks passed on the patched PR tree, not the unpatched main commit.