Repository navigation
test(net): quarantine flate's tail-shed test and plan its fix #8093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # [S] Flate's tail-shed test passes under load | ||
|
|
||
| ## Goal | ||
|
|
||
| `compressed tails shed dictionary prefixes without retaining inflated history` | ||
| in `js/net/src/flate/group.test.ts`, both `plain` variants, passes reliably | ||
| under load, fixed at its cause under the | ||
| [epic](/quest/m0/test-flakes-2/README.md)'s rules, never by raising the test | ||
| timeout. Restore both cases with every assertion when it is fixed. | ||
|
|
||
| ## Plan | ||
|
|
||
| Evidence: the `plain=true` case timed out at bun's 5000 ms default in the | ||
| merge-group batch for [moq-dev/moq#7981](https://github.com/moq-dev/moq/pull/7981) | ||
| ([run 42299125466](https://github.com/moq-dev/moq/actions/runs/42299125466), | ||
| Check job, `ci: test js failed`). That PR changes moq-mux's TS exporter, `rs/moq-cli`, | ||
| `js/net/src/lite/datagram-tracks.test.ts`, and quest docs; none of it touches | ||
| flate or its test, though a `js/net` test-side cause is not ruled out. | ||
| Both variants are quarantined with `test.skip`, since they share the loop. | ||
|
|
||
| Baseline (unloaded, pre-quarantine file copied aside): both variants together | ||
| ran in 1198 ms on the maintainer's dev host; a reviewer measured ~2.1 s per | ||
| variant on theirs, with `plain=true` only ~2% slower than `plain=false`. So the | ||
| second `toEqual` is not the cost, `plain=false` is no cheaper, and CI's 5697 ms | ||
| is a ~2.7x loaded slowdown, not a cliff. | ||
|
|
||
| Lead (unverified): the test is CPU-bound in its 100 iterations that compress | ||
| and inflate a 1 MiB frame. If profiling confirms it, cut the work volume while | ||
| keeping what the test proves (the cache stays bounded and the slow reader is | ||
| evicted), such as smaller frames against a proportionally smaller cache bound, | ||
| leaving enough headroom that a ~3x loaded slowdown still fits; if | ||
| deflate/inflate in the code under test is the slow part, fix that. | ||
|
|
||
| Reproduce first: time the case alone and under CPU contention | ||
| (`--rerun-each`) before changing it. | ||
|
|
||
| Public API: none. Wire: none. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7981has nojs/netchanges: its diff isrs/moq-mux/src/container/ts/*,rs/moq-srt/src/ts.rs,rs/moq-cli,doc/bin/cli.md,test/ts/README.md, and quest docs. Thejs/net/src/lite/datagram-tracks.test.tschange that ran in the failing batch came frommain(#7986landed 21:26Z, 18 minutes before the run started at 21:43Z), not from this PR. Since the trail-off lead ("ajs/nettest-side cause is not ruled out") depends on that file being in the batch, attribute it to the batch'smainrather than to#7981.Technical details