Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/net/src/flate/group.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ test("a slice that fails to decode fails its open group, which takes no more fra
});

for (const readPlain of [false, true]) {
test(`compressed tails shed dictionary prefixes without retaining inflated history (plain=${readPlain})`, async () => {
// Quarantined pending quest/m0/test-flakes-2/flate-tail-shed.md.
test.skip(`compressed tails shed dictionary prefixes without retaining inflated history (plain=${readPlain})`, async () => {
const group = new Group(0n);
hooks.bindGroupCompression(group, true);
const raw = group.consume();
Expand Down
4 changes: 4 additions & 0 deletions quest/m0/test-flakes-2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ process held back; eviction now lets go of that content itself, fixed by
concurrent-ready test, quarantined here instead of in the unrelated
[moq-dev/moq#7981](https://github.com/moq-dev/moq/pull/7981).

Added 2026-11-06: `js/net`'s flate tail-shed test, which timed out in a
merge-queue batch, one child.

Added 2026-11-06 (maintainer's standing rule that flakes join this epic):
`js/net`'s datagram-end close case, which failed
[moq-dev/moq#7986](https://github.com/moq-dev/moq/pull/7986)'s Check while
Expand All @@ -121,6 +124,7 @@ Public API: none. Wire: none.

## Required

- [Flate's tail-shed test passes under load](/quest/m0/test-flakes-2/flate-tail-shed.md) - `js/net`'s compressed tail-shed cases finish within bun's timeout under load, re-enabled once fixed
- [Fallback playback](/quest/m0/test-flakes-2/ietf22-fallback.md) - a browser viewer follows a fallback within the media lane's bound without dropping its session
- [dispatch-query's terminate test survives load](/quest/m0/test-flakes-2/dispatch-query-terminate.md) - `test_terminating_the_run_stops_the_running_phase` passes reliably under host load, re-enabled once fixed
- [Test PulseAudio servers stay off the desktop's D-Bus](/quest/m0/test-flakes-2/pulse-dbus.md) - concurrent media runs on one desktop never collide on `org.PulseAudio1`
Expand Down
37 changes: 37 additions & 0 deletions quest/m0/test-flakes-2/flate-tail-shed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# [S] Flate's tail-shed test passes under load

## Goal

`compressed tails shed dictionary prefixes without retaining inflated history`
in `js/net/src/flate/group.test.ts`, both `plain` variants, passes reliably
under load, fixed at its cause under the
[epic](/quest/m0/test-flakes-2/README.md)'s rules, never by raising the test
timeout. Restore both cases with every assertion when it is fixed.

## Plan

Evidence: the `plain=true` case timed out at bun's 5000 ms default in the
merge-group batch for [moq-dev/moq#7981](https://github.com/moq-dev/moq/pull/7981)
([run 42299125466](https://github.com/moq-dev/moq/actions/runs/42299125466),
Check job, `ci: test js failed`). That PR changes moq-mux's TS exporter, `rs/moq-cli`,
`js/net/src/lite/datagram-tracks.test.ts`, and quest docs; none of it touches
flate or its test, though a `js/net` test-side cause is not ruled out.
Comment on lines +16 to +18

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7981 has no js/net changes: its diff is rs/moq-mux/src/container/ts/*, rs/moq-srt/src/ts.rs, rs/moq-cli, doc/bin/cli.md, test/ts/README.md, and quest docs. The js/net/src/lite/datagram-tracks.test.ts change that ran in the failing batch came from main (#7986 landed 21:26Z, 18 minutes before the run started at 21:43Z), not from this PR. Since the trail-off lead ("a js/net test-side cause is not ruled out") depends on that file being in the batch, attribute it to the batch's main rather than to #7981.

Technical details
# #7981's file set vs the failing batch

## Affected sites
- `quest/m0/test-flakes-2/flate-tail-shed.md:16-18` — "That PR changes moq-mux's TS exporter, `rs/moq-cli`, `js/net/src/lite/datagram-tracks.test.ts`, and quest docs."

## Required outcome
- The evidence sentence names what `#7981` itself changes, and separately notes that its merge-queue batch also carried `main`'s `js/net` datagram-tracks change.

## Suggested approach (optional)
- `gh pr diff 7981 --name-only` lists 22 files, none under `js/net`. `git log --oneline -- js/net/src/lite/datagram-tracks.test.ts` shows `42220ab4f` (#7986) as the change present in that batch.
- Reword along the lines of: `#7981 changes moq-mux's TS container, rs/moq-cli, rs/moq-srt, and docs; none of it touches flate. Its batch also carried main's datagram-tracks test change (#7986), so a js/net test-side cause is not ruled out.`

Both variants are quarantined with `test.skip`, since they share the loop.

Baseline (unloaded, pre-quarantine file copied aside): both variants together
ran in 1198 ms on the maintainer's dev host; a reviewer measured ~2.1 s per
variant on theirs, with `plain=true` only ~2% slower than `plain=false`. So the
second `toEqual` is not the cost, `plain=false` is no cheaper, and CI's 5697 ms
is a ~2.7x loaded slowdown, not a cliff.

Lead (unverified): the test is CPU-bound in its 100 iterations that compress
and inflate a 1 MiB frame. If profiling confirms it, cut the work volume while
keeping what the test proves (the cache stays bounded and the slow reader is
evicted), such as smaller frames against a proportionally smaller cache bound,
leaving enough headroom that a ~3x loaded slowdown still fits; if
deflate/inflate in the code under test is the slow part, fix that.

Reproduce first: time the case alone and under CPU contention
(`--rerun-each`) before changing it.

Public API: none. Wire: none.
Loading