Repository navigation
test(net): re-enable the datagram-end close case #8110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fbefc4c
1bdffb0
8b58f7b
69d1431
7d698bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,10 @@ removed. | |
|
|
||
| ## Plan | ||
|
|
||
| The original end/close case was re-enabled by PR #8110 after PR #8000 | ||
| stubbed the publisher write budget. The additional duplicate-SETUP | ||
| investigation below remains open. | ||
|
Comment on lines
+13
to
+15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The retained quest still opens with Technical details# Retained quest still declares a completed goal
## Affected sites
- `quest/m0/test-flakes-2/datagram-end-close.md:1` — H1 still names the re-enable as the quest title.
- `quest/m0/test-flakes-2/datagram-end-close.md:5-9` — Goal says the case "passes reliably ... and its `test.skip` is removed", i.e. the objective this PR satisfies.
- `quest/m0/test-flakes-2/README.md:140` — the epic bullet now reads `[The datagram-end close follow-up]`, which no longer matches the H1.
## Required outcome
- The quest's H1 and Goal state the open objective (whether a duplicate SETUP can override an accepted lite-06 `SUBSCRIBE_END` during shutdown, preserving the accepted end), and the README bullet text matches the H1.
- The completed re-enable stays recorded as history, e.g. in the Plan paragraph added here, not as the Goal.
## Open questions for the human (optional)
- Whether the follow-up deserves its own file (leaving this one to be deleted as originally planned) rather than being folded into this quest's title; both satisfy the outcome above.
Comment on lines
+13
to
+15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| Added 2026-11-06 (maintainer's standing rule that flakes join this epic). | ||
| [moq-dev/moq#7986](https://github.com/moq-dev/moq/pull/7986)'s Check failed | ||
| in this case, whose diff touches only `bench/`, `justfile`, and quest prose. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 10860
Script executed:
Repository: moq-dev/moq
Length of output: 24389
Script executed:
Repository: moq-dev/moq
Length of output: 7677
Web query:
Bun test timeout async test promise cancellation automatic restore mock spyOn after timeout test runner documentation sourceResult:
Script executed:
Repository: moq-dev/moq
Length of output: 8175
Web query:
Bun test timeout promise async finally mockRestore spy not restored next test timeout GitHub issue sourceResult:
Script executed:
Repository: moq-dev/moq
Length of output: 14728
Web query:
Bun test timeout pending async promise finally timeout spy next test bun:test source TestRunnerResult:
Script executed:
Repository: moq-dev/moq
Length of output: 3355
Web query:
site:github.com/oven-sh/bun test timeout async function finally spy mock restore subsequent tests bun testResult:
Script executed:
Repository: moq-dev/moq
Length of output: 185
Web query:
Bun 1.4.2 bun test timeout promise finally mock restore source TestRunner timeoutResult:
Script executed:
Repository: moq-dev/moq
Length of output: 1795
Web query:
Bun 1.4.2 test timeout promise finally spy restore Bun test 1.4.2Result:
Script executed:
Repository: moq-dev/moq
Length of output: 3447
Script executed:
Repository: moq-dev/moq
Length of output: 5295
Script executed:
Repository: moq-dev/moq
Length of output: 11837
Script executed:
Repository: moq-dev/moq
Length of output: 835
Script executed:
Repository: moq-dev/moq
Length of output: 15578
Script executed:
Repository: moq-dev/moq
Length of output: 7151
Restore the budget spy after a timeout.
If the lite-07 case times out while waiting for
reader.info()or a priority change, itsfinallycannot restore the spy. The next test can then run with budget yields disabled, weakening its scheduling coverage. Register timeout-safe cleanup for the spy.