Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m0/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ edge, which embeds moq-relay; it moved there on 2026-09-28.
- [Publish the release line's drain() wrappers](/quest/m0/ffi-shutdown-backport.md) - Dart `moq` 0.1.1 reaches pub.dev from `release`
- [Release's audio encoder rolls groups before the cap](/quest/m0/release-audio-group-cap.md) - a long `groupDuration` with short frames never throws `GroupTooLarge` on `release`
- [Local checks pass on unchanged main](/quest/m0/local-checks-main.md) - `sh/go/publish-wrapper.test.sh` passes under a global `tag.gpgsign = true`, so `just check` passes on a clean `main`
- [The invalid-attribute browser check matches moq-watch's attributes](/quest/m0/watch-invalid-attribute-check.md) - `publish-ui.browser.ts`'s invalid-attribute test passes on main again, with no stale `buffer` case
- [Bun-spawning test recipes install the JS workspace](/quest/m0/recipe-js-install.md) - `bare-fin`, `max-age`, `stream-limits`, `relay-fill`, and `receive-credit` pass in a fresh checkout
- [CI cost and latency](/quest/m0/ci/README.md) - cloud CI runs only in GitHub's merge queue, one tested entry at a time, expensive checks run nightly and gate `release`, caches move to R2, and runners are chosen last
- [More tests under load](/quest/m0/test-flakes-2/README.md) - load-only and queue failures, one quest per flake, fixed at the cause, since each one drops a queued PR
Expand Down
26 changes: 26 additions & 0 deletions quest/m0/watch-invalid-attribute-check.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# [XS] The invalid-attribute browser check matches moq-watch's attributes

## Goal

`test/interop/clients/js/publish-ui.browser.ts`'s "invalid attributes and
properties refuse, retain bad markup, and recover" passes on main again. Each
case tests an attribute moq-watch or moq-publish still has, and every value it
calls invalid is one the element documents as invalid.

## Plan

Planned 2026-11-07 (maintainer, /quest-complete) from
[moq-dev/moq#8136](https://github.com/moq-dev/moq/pull/8136)'s validation.
From the repository root, `(cd test/interop/clients/js && bun test ./publish-ui.browser.ts -t "invalid attributes")` fails on main
(9bf34b20dd) with `invalid: "30"` giving `threw: false, recovered: false`.

Likely cause: [moq-dev/moq#8057](https://github.com/moq-dev/moq/pull/8057)
renamed moq-watch's `buffer` to `lookahead`. In `js/watch/src/element.ts`, a
`buffer` attribute now throws only the rename error, and the element has no
`buffer` property. So the case `["moq-watch", "buffer", "30", "buffer", 0]`
neither throws on `Reflect.set` nor reads back its valid value. Confirm which
case fails. If it is this one, move it to `lookahead` with a value
`parseLookahead` refuses, and keep a check that `buffer` still reports its
rename when set and recovers once the attribute is removed.
If the `delay` case fails instead, decide from `parseDelay`'s documented
syntax whether the element or the test is wrong.