Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions quest/m0/test-flakes-2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,11 @@ closed, left no finished record, so the final catalog snapshot started the
rendition again and replayed a group on its held pad. A failure now counts as
the track's end, fixed by [moq-dev/moq#8160](https://github.com/moq-dev/moq/pull/8160).

Added 2026-11-07 (maintainer, /quest-complete): moq-gst's stale-completion
sink test, which failed once in 30 stress iterations in
[moq-dev/moq#8160](https://github.com/moq-dev/moq/pull/8160)'s validation.
It is quarantined with `#[ignore]` until its child fixes it.

`js/net`'s lite-07 relative-start integration test, which failed once on main in
[moq-dev/moq#8165](https://github.com/moq-dev/moq/pull/8165)'s baseline run,
read a start of 0 when the newest group landed before the reader asked: its
Expand All @@ -187,6 +192,7 @@ Public API: none. Wire: none.
## Required

- [Fallback playback](/quest/m0/test-flakes-2/ietf22-fallback.md) - a browser viewer follows a fallback within the media lane's bound without dropping its session
- [moq-gst's stale-completion sink test survives load](/quest/m0/test-flakes-2/gst-stale-completion.md) - `a_stale_completion_cannot_end_the_next_publication` passes under stress, and its `#[ignore]` is removed
- [The embedded relay's sockets are closed when run returns](/quest/m0/test-flakes-2/embed-sockets-outlived.md) - `embed::worker_tokio_custom_route_and_quic` stops failing with "the owner's sockets outlived `run`"
- [The http:// fingerprint tests survive a slow fetch](/quest/m0/test-flakes-2/fingerprint-host-clock.md) - a fingerprint fetch slower than the 500 ms hedge no longer trips the host-clock guard
- [A lite-07 reply FINs instead of resetting when the subscriber FINs mid-write](/quest/m0/test-flakes-2/lite07-reply-fin.md) - `js/net`'s empty-window reply test passes under `--rerun-each 200`, fixed in the publisher
Expand Down
29 changes: 29 additions & 0 deletions quest/m0/test-flakes-2/gst-stale-completion.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# [S] moq-gst's stale-completion sink test survives load

## Goal

`rs/moq-gst/src/sink/imp.rs`'s `a_stale_completion_cannot_end_the_next_publication`
passes reliably under load, fixed at its cause, and its `#[ignore]` is
removed.

## Plan

Planned 2026-11-07 (maintainer, /quest-complete) from
[moq-dev/moq#8160](https://github.com/moq-dev/moq/pull/8160)'s validation:
it failed once in a 30-iteration stress run of the moq-gst suite at
[8e2db7b9f6](https://github.com/moq-dev/moq/commit/8e2db7b9f609f1c0992049def7499c268ddcf085).
It is quarantined with `#[ignore]` until this quest fixes it, per AGENTS.md.

The test starts a session against an unreachable URL, stops it, starts a
second one, and asserts that failing the first session's completion leaves
the second's open and the pad relinked to it. Reproduce it under stress
first and record which assertion fails; that decides whether the sink or
the test is wrong. Candidates: a state transition that returns before the
old session's task lets go of the pad; a second session that hasn't linked
its pad by the time `Paused` returns; or the old session's status task
failing its own completion during shutdown before `stale.fail()` runs, which
breaks the test's assumption rather than the sink. Fix a sink defect in the
sink, never by waiting in the test, and prove it with a test that forces
the losing order.

Public API: none. Wire: none.
1 change: 1 addition & 0 deletions rs/moq-gst/src/sink/imp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2236,6 +2236,7 @@ mod tests {
// A task outliving its session writes into the handle nobody reads any more. Scoping falls out of
// the topology: no id comparison guards the state the pads see.
#[test]
#[ignore = "flaky under stress; investigation: quest/m0/test-flakes-2/gst-stale-completion.md"]
Comment thread
kixelated marked this conversation as resolved.
Resolved
fn a_stale_completion_cannot_end_the_next_publication() {
gst::init().unwrap();
let sink = sink();
Expand Down
3 changes: 3 additions & 0 deletions sh/gh/test-inventory.allow
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ ignore moq-video::frame::tests::d3d11_resize_matches_cpu /quest/m5/video-hardwar
ignore moq-video::render::export::dx12::tests::exports_an_nv12_texture /quest/m5/video-hardware.md
ignore moq-video::render::export::dx12::tests::media_foundation_encodes_the_export_in_place /quest/m5/video-hardware.md

# Quarantined flakes, re-enabled by the quest that fixes them.
ignore moq-gst::sink::imp::tests::a_stale_completion_cannot_end_the_next_publication /quest/m0/test-flakes-2/gst-stale-completion.md

# Flaky, disabled until its quest fixes the cause.
ignore moq-relay::embed::worker_tokio_custom_route_and_quic /quest/m0/test-flakes-2/embed-sockets-outlived.md

Expand Down
Loading