Repository navigation
test(gst): quarantine the stale-completion sink flake and plan its fix #8187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
acdb1b3
test(gst): quarantine the stale-completion sink flake and plan its fix
kixelated c7e125d
test(gst): allowlist the quarantined sink test; plan names the shutdo…
kixelated 25f345b
merge: preserve both quarantine entries when merging base
5e14edd
merge: preserve both quarantine entries when merging base
297abc9
chore: merge base and preserve both flake quest entries
0a25182
Merge remote-tracking branch 'origin/main' into fix-8187
kixelated 078a0aa
merge: preserve test quarantines while merging base
fdff90e
Merge base into pr-8187, preserving both quest updates
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # [S] moq-gst's stale-completion sink test survives load | ||
|
|
||
| ## Goal | ||
|
|
||
| `rs/moq-gst/src/sink/imp.rs`'s `a_stale_completion_cannot_end_the_next_publication` | ||
| passes reliably under load, fixed at its cause, and its `#[ignore]` is | ||
| removed. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-07 (maintainer, /quest-complete) from | ||
| [moq-dev/moq#8160](https://github.com/moq-dev/moq/pull/8160)'s validation: | ||
| it failed once in a 30-iteration stress run of the moq-gst suite at | ||
| [8e2db7b9f6](https://github.com/moq-dev/moq/commit/8e2db7b9f609f1c0992049def7499c268ddcf085). | ||
| It is quarantined with `#[ignore]` until this quest fixes it, per AGENTS.md. | ||
|
|
||
| The test starts a session against an unreachable URL, stops it, starts a | ||
| second one, and asserts that failing the first session's completion leaves | ||
| the second's open and the pad relinked to it. Reproduce it under stress | ||
| first and record which assertion fails; that decides whether the sink or | ||
| the test is wrong. Candidates: a state transition that returns before the | ||
| old session's task lets go of the pad; a second session that hasn't linked | ||
| its pad by the time `Paused` returns; or the old session's status task | ||
| failing its own completion during shutdown before `stale.fail()` runs, which | ||
| breaks the test's assumption rather than the sink. Fix a sink defect in the | ||
| sink, never by waiting in the test, and prove it with a test that forces | ||
| the losing order. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.