Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions quest/m3/webrtc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ Decided 2026-10-30 with the maintainer (planning interview), after the str0m wor
- [Several bandwidth lines per media section](/quest/m3/webrtc/sdp-bandwidth.md) - answers carry both `b=TIAS` and `b=AS` without splicing
- [DTLS waits for ICE](/quest/m3/webrtc/dtls-after-ice.md) - DTLS flights start once ICE nominates a pair, so a late ICE path can't exhaust them
- [The stack takes kio clock time](/quest/m3/webrtc/clock.md) - the vendored code takes `kio::clock::Instant`, so sim tests drive it directly
- [WHIP/WHEP builds carry no SCTP](/quest/m3/webrtc/sctp-feature.md) - SCTP compiles only with the `p2p` feature
- [The vendored stack keeps only what browsers negotiate](/quest/m3/webrtc/browser-only.md) - PSK suites, `ccm`, and anything else no browser uses are gone
- [The vendored stack exposes only what moq-webrtc calls](/quest/m3/webrtc/dead-api.md) - dead upstream API is deleted once rind and clock settle the seams

## Related

Expand Down
26 changes: 26 additions & 0 deletions quest/m3/webrtc/browser-only.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# [S] The vendored stack keeps only what browsers negotiate

## Goal

The vendored str0m, dimpl, `is`, and sctp-proto drop every feature no
browser's WebRTC negotiates today, starting with dimpl's PSK cipher suites
and the `ccm` dependency they pull in, so nothing MoQ can't reach from a
browser peer stays compiled.

## Plan

Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of
[moq-dev/moq#8163](https://github.com/moq-dev/moq/pull/8163). The maintainer
widened the suggestion from PSK alone: delete anything browsers don't use
now. Browser DTLS authenticates with certificates and fingerprints, never
PSK. Inventory what Chrome, Firefox, and Safari offer and accept (cipher
suites, extensions, SDP attributes, codecs' packetizers) against what the
vendored code still carries, cite the evidence for each removal in the PR,
and keep what a browser negotiates even if MoQ doesn't call it yet. The
epic's settled removals (its "What goes" list, such as G.7xx, DTMF, and
comfort noise) and non-goals (TURN, DTLS 1.3) stay as decided: this trim
only removes more, never restores. API
that moq-webrtc never calls but a browser could need stays for
[the dead-API trim](/quest/m3/webrtc/dead-api.md).

Public API: none. Wire: none toward browsers.
23 changes: 23 additions & 0 deletions quest/m3/webrtc/dead-api.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# [M] The vendored stack exposes only what moq-webrtc calls

## Goal

Every item in the vendored modules is reached from moq-webrtc or its
tests; dead upstream API is deleted.

## Plan

Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of
[moq-dev/moq#8163](https://github.com/moq-dev/moq/pull/8163). It waits on
the rind and clock quests, since both reshape the seams moq-webrtc calls
through. The vendored tree opens with `#![allow(warnings, reason = "vendored
upstream code")]` (`rs/moq-webrtc/src/vendor/mod.rs`), so first narrow that
allow to let `dead_code` fire, then delete what the report shows unreached,
keeping upstream's tests for what stays.

Public API: none. Wire: none.

## Required

- [moq-webrtc on rind](/quest/m1/rind/rtc.md) - settles the crypto seams
- [The stack takes kio clock time](/quest/m3/webrtc/clock.md) - settles the time seams
20 changes: 20 additions & 0 deletions quest/m3/webrtc/sctp-feature.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# [S] WHIP/WHEP builds carry no SCTP

## Goal

The vendored `sctp_proto` and str0m's SCTP glue compile only with
moq-webrtc's `p2p` feature (its data-channel transport), so a WHIP/WHEP-only
build has no SCTP code in its tree.

## Plan

Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of
[moq-dev/moq#8163](https://github.com/moq-dev/moq/pull/8163), which vendors
the stack but still compiles SCTP into every build. The epic's settled
decision ("SCTP stays ... but compiles only with the data-channel feature")
gets this owner. Gate the modules and the str0m paths that reach them,
and add a check, in the feature matrix `just rs features` runs, that a
build without `p2p` neither compiles nor links `sctp_proto`. The feature
keeps its name.

Public API: none. Wire: none.
Loading