Repository navigation
fix(video): codec drains resume or fail for good #8207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d53ae60
chore(quest): claim quest/m1/explicit-state/video-drain.md
kixelated 70e014a
fix(video): codec drains resume or fail for good, and the keyframe ga…
kixelated e0b03d2
fix(video): Media Foundation and VideoToolbox drains, and the vpx/VAA…
kixelated cb2aa2b
quest: video codec drains are done
kixelated 301f41b
fix(video): stop a V4L2 queue that never streamed, and keep MF timest…
kixelated 3f3c6ae
Merge remote-tracking branch 'origin/main' into quest/m1/explicit-sta…
kixelated ff4181e
Merge remote-tracking branch 'origin/main' into HEAD
kixelated c9ae4e2
Merge remote-tracking branch 'origin/main' into HEAD
kixelated 9af1218
fix(video): latch unrecoverable drain failures as CodecGone; keep a h…
kixelated e3f9f83
Merge remote-tracking branch 'origin/main' into HEAD
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 1375
Script executed:
Repository: moq-dev/moq
Length of output: 30563
Web query:
Linux V4L2 VIDIOC_STREAMOFF failed ioctl buffers remain queued VIDIOC_QBUF already queued error official kernel documentationResult:
Web query:
Linux kernel v4l2 ioctl video_ioctl2 mutex_lock_interruptible streamoff EINTR queued buffers vb2 qbuf already queued EINVAL sourceResult:
Web query:
Linux kernel videobuf2 vb2_core_qbuf queued state EINVAL vb2_streamoff interrupted mutex ioctl sourceResult:
Script executed:
Repository: moq-dev/moq
Length of output: 5559
Script executed:
Repository: moq-dev/moq
Length of output: 16504
Web query:
site:github.com/torvalds/linux "vb2_core_qbuf" "invalid buffer state" "VB2_BUF_STATE_DEQUEUED" return -EINVALResult:
Script executed:
Repository: moq-dev/moq
Length of output: 15489
Web query:
Linux videobuf2-core.c "vb2_core_qbuf" "case VB2_BUF_STATE_DEQUEUED" "return -EINVAL" buffer state queueResult:
Track failed capture-start cleanup.
If startup and
STREAMOFFboth fail, buffers can remain queued while the stream saysStopped. A retry can then attempt to queue them again. In both mmap and userptr streams, retain a cleanup-required or failed state until cleanup succeeds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining: if STREAMON and the cleanup STREAMOFF both fail, the original error is returned and a retry's QBUF fails with EINVAL, which also surfaces as an error. Nothing is silently corrupted, and a device whose STREAMOFF fails is already unusable; tracking a third state for it adds code without a recovery path.
(Written by Claude Opus 5.5 with low)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rate Limit Exceeded
@kixelatedhave exceeded the limit for the number of chat messages per hour. Please wait 2 minutes and 46 seconds before sending another message.