Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e0014d3
chore(quest): claim quest/m1/explicit-state/transport-close.md
kixelated Nov 7, 2026
c96e757
fix(moq-tokio): a stopped connection loop reports its error next
kixelated Nov 7, 2026
24fe47e
fix(moq-tokio): a closed or driverless QUIC endpoint stays closed
kixelated Nov 7, 2026
b2a6f40
wip: closed latch
kixelated Nov 7, 2026
9b857a6
fix(moq-tokio): a local QUIC close resolves closed() once it is sent
kixelated Nov 7, 2026
96cb096
refactor(moq-uring): a connection's end is one enum
kixelated Nov 7, 2026
9854817
style: cargo fmt
kixelated Nov 7, 2026
906f811
fix(qmux): a stopped stream resets on drop, and close state lives once
kixelated Nov 7, 2026
187b82b
refactor(moq-quic): a QMux connection's end is one enum
kixelated Nov 7, 2026
4e24b0b
fix(moq-relay): a session closed twice ends once
kixelated Nov 7, 2026
a85e3dc
refactor(quic): a web session's mode is one value
kixelated Nov 8, 2026
36081a3
refactor(moq-quic): a path challenge keeps its token and pending bit …
kixelated Nov 8, 2026
2995318
refactor(moq-quic): a due CONNECTION_CLOSE lives in the closing states
kixelated Nov 8, 2026
9446409
refactor(moq-quic): a stream's reader and FIN each live in one state
kixelated Nov 8, 2026
2d085b9
Merge origin/main
kixelated Nov 8, 2026
aa899c2
fix(moq-tokio): box a connection's draining predecessor
kixelated Nov 8, 2026
76b3545
quest: finish transport close
kixelated Nov 8, 2026
0e80821
fix(quic): closed() waits for the close itself, and uring wakes once
kixelated Nov 8, 2026
4f0838c
fix(moq-quic): a closing endpoint drops a pending PATH_CHALLENGE
kixelated Nov 8, 2026
8150dc6
test(moq-tokio): a closed or driverless endpoint stays closed
kixelated Nov 8, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions quest/m1/explicit-state/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ Decided 2026-11-07 (maintainer):
REVIEW.md's State check and its AGENTS.md line). Not chosen:
REVIEW.md only, or no rule change.
- ✅ `quic::driver::Endpoint::rebind` becomes crate-private, since only
tests call it (see [Transport close](/quest/m1/explicit-state/transport-close.md)).
Not chosen: refusing to rebind after close.
tests call it (done: test-only, and unreleased, so it broke no published
surface and needed no m2 quest). Not chosen: refusing to rebind after
close.

Every child reproduces each folded bug in a test before fixing it. A bug
that doesn't reproduce is dropped from the child, and its PR says why. A
Expand All @@ -69,7 +70,6 @@ which collapses that state and waits on [Drop set](/quest/m1/drop-set.md).
## Required

- [moq-boy pause state](/quest/m1/explicit-state/boy-pause.md) - a new viewer always wakes a paused emulator
- [Transport close](/quest/m1/explicit-state/transport-close.md) - connection status ends with its error, and every Rust QUIC backend agrees when a connection is closed
- [Video codec drains](/quest/m1/explicit-state/video-drain.md) - a hardware codec whose drain fails is ready for input again or terminally failed, never left stuck
- [Publish capture phases](/quest/m1/explicit-state/publish-capture.md) - dismissing the screen-share picker turns sharing off
- [js/qmux close](/quest/m1/explicit-state/qmux-close.md) - a graceful remote close ends qmux streams cleanly
Expand Down
76 changes: 0 additions & 76 deletions quest/m1/explicit-state/transport-close.md

This file was deleted.

4 changes: 2 additions & 2 deletions rs/moq-net/src/lite/subscriber.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3102,7 +3102,7 @@ impl kio::Task for DatagramServe {
self.state,
DatagramState::Ending { .. } | DatagramState::Finish { .. } | DatagramState::Done
) && self.gate.poll_denied(waiter).is_ready()
&& self.closed.poll_closed(waiter).is_pending()
&& self.closed.poll_ending(waiter).is_pending()
{
tracing::info!(broadcast = %self.subscriber.log_path(&self.path), track = %self.name(), "datagrams no longer authorized");
self.abort(Error::Unauthorized);
Expand Down Expand Up @@ -10856,7 +10856,7 @@ impl kio::Task for TrackServeRun {
// its tracks end.
if !matches!(self.state, TrackRunState::Ending { .. } | TrackRunState::Finish { .. })
&& self.gate.poll_denied(waiter).is_ready()
&& self.serve.subscriber.session.clone().poll_closed(waiter).is_pending()
&& self.serve.subscriber.session.poll_ending(waiter).is_pending()
{
self.revoke();
return Poll::Ready(());
Expand Down
8 changes: 8 additions & 0 deletions rs/moq-net/src/session.rs
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,14 @@ impl Closing {
sent.get_or_insert_with(|| (code, cause.cloned()));
}

/// Whether this side closed the transport.
pub(crate) fn is_sent(&self) -> bool {
self.sent
.lock()
.unwrap_or_else(std::sync::PoisonError::into_inner)
.is_some()
}

/// Whether the handles closed the transport by dropping or draining.
pub(crate) fn is_local(&self) -> bool {
self.local.load(std::sync::atomic::Ordering::Relaxed)
Expand Down
11 changes: 11 additions & 0 deletions rs/moq-net/src/transport/boxed.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,17 @@ impl Session {
&self.closing
}

/// Resolve once the session is ending: this side closed the transport, or it closed.
///
/// Unlike `poll_closed`, which a backend holds until its close is on the wire, this sees a
/// local close the moment it is sent.
pub(crate) fn poll_ending(&self, waiter: &kio::Waiter) -> Poll<()> {
if self.closing.is_sent() {
return Poll::Ready(());
}
poll::Session::poll_closed(self, waiter).map(|_| ())
}

/// The subscriptions and fetches the session's tasks carry over this transport.
pub(crate) fn work(&self) -> &crate::session::Work {
&self.work
Expand Down
Loading
Loading