Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions quest/m0/test-flakes-2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,16 @@ Added 2026-11-07 (maintainer's standing rule that flakes join this epic):
A subscriber FIN during the reply write's budget yield resets the stream. It is
quarantined with `test.skip` until its child fixes it.

Added 2026-11-07 (maintainer, /quest-complete): moq-relay's
`socket_auth::a_forged_dial_never_connects`, which failed
[moq-dev/moq#8204](https://github.com/moq-dev/moq/pull/8204)'s Check when
mallory's request for bob's endpoint synced before his announce arrived. It is
quarantined with `#[ignore]` until its child fixes it.

Added 2026-11-07 (maintainer, /quest-complete): moq-uring's qlog accounting
test, which spins a fixed count waiting on a background thread, from
[moq-dev/moq#8208](https://github.com/moq-dev/moq/pull/8208)'s follow-ups.

Public API: none. Wire: none.

## Required
Expand All @@ -196,3 +206,5 @@ Public API: none. Wire: none.
- [moq-gst's stale-completion sink test survives load](/quest/m0/test-flakes-2/gst-stale-completion.md) - `a_stale_completion_cannot_end_the_next_publication` passes under stress, and its `#[ignore]` is removed
- [The http:// fingerprint tests survive a slow fetch](/quest/m0/test-flakes-2/fingerprint-host-clock.md) - a fingerprint fetch slower than the 500 ms hedge no longer trips the host-clock guard
- [A lite-07 reply FINs instead of resetting when the subscriber FINs mid-write](/quest/m0/test-flakes-2/lite07-reply-fin.md) - `js/net`'s empty-window reply test passes under `--rerun-each 200`, fixed in the publisher
- [moq-relay's forged-dial test waits for bob's endpoint](/quest/m0/test-flakes-2/forged-dial-announce.md) - `a_forged_dial_never_connects` requests bob's endpoint only after its announce reaches mallory, and its `#[ignore]` is removed
- [moq-uring's qlog accounting test waits on the accounting](/quest/m0/test-flakes-2/qlog-staging-spin.md) - `an_open_trace_accounts_for_staging_and_close` waits for the accounting, not 10,000 spins
31 changes: 31 additions & 0 deletions quest/m0/test-flakes-2/forged-dial-announce.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# [XS] moq-relay's forged-dial test waits for bob's endpoint

## Goal

moq-relay's `socket_auth::a_forged_dial_never_connects` passes under load and runs again. Mallory
asks for bob's server endpoint only once it has reached her session, so
the request never syncs ahead of bob's announce.

## Plan

Planned 2026-11-07 (maintainer, /quest-complete). The test failed `Check` on
[moq-dev/moq#8204](https://github.com/moq-dev/moq/pull/8204)
([run 42430262086](https://github.com/moq-dev/moq/actions/runs/42430262086)),
which touches no relay, socket, or origin code. It panicked at
`rs/moq-relay/tests/integration/socket_auth.rs:251` with
`bob's endpoint: Unroutable`. It passed 40 stress runs alone and 18 more
inside the loaded relay suite. It is quarantined with `#[ignore]` and a
`sh/gh/test-inventory.allow` entry until this quest fixes it.

Bob's first `poll_accept_tcp` only starts his server endpoint's announce,
which still has to cross bob's session, the relay, and mallory's session.
`origin::Consumer::request` reports `Unroutable` once discovery has synced
without a covering route, so mallory's request can sync first. Have the test
wait for the announce to reach mallory's origin before the forge requests
it. `.server/bob` is a hidden route (a `.`-named segment), so an announced
watch needs `with_hidden(true)` to see it. Check the file's other tests that
request a freshly announced endpoint without such a wait, and fix any that
share the race. Then remove the `#[ignore]` and the allowlist entry, and
delete this quest.

Public API: none. Wire: none.
21 changes: 21 additions & 0 deletions quest/m0/test-flakes-2/qlog-staging-spin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# [XS] moq-uring's qlog accounting test waits on the accounting

## Goal

moq-uring's `quic::qlog::tests::an_open_trace_accounts_for_staging_and_close`
passes on a loaded host. It waits for the staged memory to be accounted, not
for a fixed number of spins.

## Plan

Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of
[moq-dev/moq#8208](https://github.com/moq-dev/moq/pull/8208).

The test (`rs/moq-uring/src/quic/qlog.rs`) spins up to 10,000
`std::thread::yield_now` calls until `sink.inner.memory` reaches the
expected value, which a background thread sets. On a loaded host the thread
can run late and the spins run out first. Wait on the accounting itself, for
example a condition the sink signals when it charges memory, or a blocking
read of the staged state. Don't raise the spin count.
Comment thread
kixelated marked this conversation as resolved.
Resolved

Public API: none. Wire: none.
4 changes: 4 additions & 0 deletions quest/m1/mock-clock-tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,7 @@ Rules every child keeps:

The counts come from a heuristic scan on 2026-11-06; re-scan each area
before starting, since tests land and move.

## Required

- [A lint rejects expect(clock.drive(...)).rejects and .resolves](/quest/m1/mock-clock-tests/drive-expect-guard.md) - wrapping `drive` in `expect(...).rejects` or `.resolves` fails lint
23 changes: 23 additions & 0 deletions quest/m1/mock-clock-tests/drive-expect-guard.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# [XS] A lint rejects expect(clock.drive(...)).rejects and .resolves

## Goal

A JS test can't wrap a `Manual` clock's `drive` in
`expect(...).rejects` or `expect(...).resolves`. A lint rule rejects the
pattern with a message pointing at the fix.

## Plan

Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of
[moq-dev/moq#8226](https://github.com/moq-dev/moq/pull/8226).

Bun's `expect(...).rejects` and `.resolves` run a nested event loop, which
silently breaks the order `drive` relies on, and the resulting failure looks
like a clock bug. Today only a doc line in `@moq/clock` warns. Add a
`noRestrictedSyntax`-style rule in `biome.jsonc` (or a GritQL plugin if
biome's built-in rules can't match it) that flags `drive` or `driveUntil`
called inside `expect(...)` followed by `.rejects` or `.resolves`. Its message
says to await `drive` first and assert on the settled result. Fix any existing
matches.

Public API: none. Wire: none.
1 change: 1 addition & 0 deletions rs/moq-relay/tests/integration/socket_auth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ async fn prefix_grants_admit_a_session() {
/// name. Bob sees a dial from alice, but alice never dialed it and resets his accept, so it
/// never connects and mallory reads nothing.
#[tokio::test]
#[ignore = "flaky: mallory's request can sync before bob's announce arrives; quest/m0/test-flakes-2/forged-dial-announce.md"]
async fn a_forged_dial_never_connects() {
let fixture = Fixture::new().await;
let (alice, _alice_origin, _alice_session) = fixture.endpoint(Role::Client, "alice", LITE).await;
Expand Down
3 changes: 3 additions & 0 deletions sh/gh/test-inventory.allow
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ ignore moq-video::render::export::dx12::tests::media_foundation_encodes_the_expo
# Quarantined flakes, re-enabled by the quest that fixes them.
ignore moq-gst::sink::imp::tests::a_stale_completion_cannot_end_the_next_publication /quest/m0/test-flakes-2/gst-stale-completion.md

# Flaky, disabled until its quest fixes the cause.
ignore moq-relay::socket_auth::a_forged_dial_never_connects /quest/m0/test-flakes-2/forged-dial-announce.md

# Need another implementation to speak the route wire; the quest ports it.
ignore moq-net::test_interop::lite_tracks_interop /quest/m2/cluster-routing/routes/js.md

Expand Down
Loading