Repository navigation
quest: quarantine the forged-dial flake and plan three test follow-ups #8241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
535f6d3
quest: plan the forged-dial test's wait for bob's endpoint
kixelated 6703f2f
test(relay): quarantine the forged-dial flake until its quest fixes it
kixelated 5e807a0
Merge remote-tracking branch 'origin/main' into quest-plan/forged-dia…
kixelated 24eaa57
quest: plan the qlog accounting wait and the drive expect guard
kixelated 4347722
Merge remote-tracking branch 'origin/main' into quest-plan/forged-dia…
kixelated fa1f300
chore: merge base and preserve new quest and test exemption
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # [XS] moq-relay's forged-dial test waits for bob's endpoint | ||
|
|
||
| ## Goal | ||
|
|
||
| moq-relay's `socket_auth::a_forged_dial_never_connects` passes under load and runs again. Mallory | ||
| asks for bob's server endpoint only once it has reached her session, so | ||
| the request never syncs ahead of bob's announce. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-07 (maintainer, /quest-complete). The test failed `Check` on | ||
| [moq-dev/moq#8204](https://github.com/moq-dev/moq/pull/8204) | ||
| ([run 42430262086](https://github.com/moq-dev/moq/actions/runs/42430262086)), | ||
| which touches no relay, socket, or origin code. It panicked at | ||
| `rs/moq-relay/tests/integration/socket_auth.rs:251` with | ||
| `bob's endpoint: Unroutable`. It passed 40 stress runs alone and 18 more | ||
| inside the loaded relay suite. It is quarantined with `#[ignore]` and a | ||
| `sh/gh/test-inventory.allow` entry until this quest fixes it. | ||
|
|
||
| Bob's first `poll_accept_tcp` only starts his server endpoint's announce, | ||
| which still has to cross bob's session, the relay, and mallory's session. | ||
| `origin::Consumer::request` reports `Unroutable` once discovery has synced | ||
| without a covering route, so mallory's request can sync first. Have the test | ||
| wait for the announce to reach mallory's origin before the forge requests | ||
| it. `.server/bob` is a hidden route (a `.`-named segment), so an announced | ||
| watch needs `with_hidden(true)` to see it. Check the file's other tests that | ||
| request a freshly announced endpoint without such a wait, and fix any that | ||
| share the race. Then remove the `#[ignore]` and the allowlist entry, and | ||
| delete this quest. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # [XS] moq-uring's qlog accounting test waits on the accounting | ||
|
|
||
| ## Goal | ||
|
|
||
| moq-uring's `quic::qlog::tests::an_open_trace_accounts_for_staging_and_close` | ||
| passes on a loaded host. It waits for the staged memory to be accounted, not | ||
| for a fixed number of spins. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of | ||
| [moq-dev/moq#8208](https://github.com/moq-dev/moq/pull/8208). | ||
|
|
||
| The test (`rs/moq-uring/src/quic/qlog.rs`) spins up to 10,000 | ||
| `std::thread::yield_now` calls until `sink.inner.memory` reaches the | ||
| expected value, which a background thread sets. On a loaded host the thread | ||
| can run late and the spins run out first. Wait on the accounting itself, for | ||
| example a condition the sink signals when it charges memory, or a blocking | ||
| read of the staged state. Don't raise the spin count. | ||
|
|
||
| Public API: none. Wire: none. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # [XS] A lint rejects expect(clock.drive(...)).rejects and .resolves | ||
|
|
||
| ## Goal | ||
|
|
||
| A JS test can't wrap a `Manual` clock's `drive` in | ||
| `expect(...).rejects` or `expect(...).resolves`. A lint rule rejects the | ||
| pattern with a message pointing at the fix. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-07 (maintainer, /quest-complete), a follow-up of | ||
| [moq-dev/moq#8226](https://github.com/moq-dev/moq/pull/8226). | ||
|
|
||
| Bun's `expect(...).rejects` and `.resolves` run a nested event loop, which | ||
| silently breaks the order `drive` relies on, and the resulting failure looks | ||
| like a clock bug. Today only a doc line in `@moq/clock` warns. Add a | ||
| `noRestrictedSyntax`-style rule in `biome.jsonc` (or a GritQL plugin if | ||
| biome's built-in rules can't match it) that flags `drive` or `driveUntil` | ||
| called inside `expect(...)` followed by `.rejects` or `.resolves`. Its message | ||
| says to await `drive` first and assert on the settled result. Fix any existing | ||
| matches. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.