Repository navigation
fix(ffi): FFI handles hold one lifecycle state each #8264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fe72875
chore(quest): claim quest/m1/explicit-state/ffi-state.md
kixelated e797a4a
fix(moq-ffi): handles hold one lifecycle state each
kixelated b13a808
fix(moq-c): video follow and Background hold one state each
kixelated 104ffaa
quest: rewrite ffi-state to the remaining sweep, split connection sta…
kixelated d3f4b24
fix(moq-ffi): the Go wrapper reads AlreadyResponded after an answer
kixelated dae578f
Merge remote-tracking branch 'origin/main' into quest/m1/explicit-sta…
kixelated d63f86d
fix(ffi): a failed publish still moves the claim to the new track
kixelated 9d7a2ea
fix(ffi,c): a moved claim resumes from the encoder's target, and a di…
kixelated faf4a70
fix(mux): an assumed target ramps from now
kixelated 1655a94
fix(mux): an assumed target above the ceiling comes down to it
kixelated 988c75a
Merge branch 'base' into pr-8264
b1e94f6
fix(moq-c): follow video producer constructor rename in test
c5a7fd0
fix(moq-ffi): follow video producer constructor rename in test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # [L] Connection state carries each phase's data | ||
|
|
||
| ## Goal | ||
|
|
||
| A connection state snapshot carries each phase's data inside that phase, so | ||
| a field that means nothing in the current phase can't be read: | ||
|
|
||
| - moq-ffi's `MoqConnectionState` (`rs/moq-ffi/src/session.rs`) is a flat | ||
| record (`revision`, `phase`, `connects`, `failure`, `version`), so | ||
| `failure` and `version` are readable in phases where they mean nothing. | ||
| It becomes a phase enum whose variants carry their own data, mirroring | ||
| Rust's `moq_tokio::connection::Observation`, which takes the same shape, | ||
| and every hand-written wrapper follows. | ||
| - moq-c's `moq_connection_state` follows the same shape and renames its | ||
| `protocol` to `version`. | ||
|
|
||
| ## Plan | ||
|
|
||
| Split from [FFI handle state](/quest/m1/explicit-state/ffi-state.md) when it | ||
| started (2026-11-08), as that item recorded: it breaks every binding, so | ||
| under the [explicit-state epic](/quest/m1/explicit-state/README.md)'s | ||
| milestone rule it is its own m2 quest. Its PR marks its title `!` and says | ||
| how to migrate. | ||
|
|
||
| Rust's `moq_tokio::connection::Observation` (`rs/moq-tokio/src/connection.rs`) | ||
| is flat too: `failure`, `version`, `transport`, and `last_connected` sit | ||
| beside `phase`, while the private `Lifecycle` enum it is built from already | ||
| carries them per phase. | ||
|
|
||
| - ✅ Decided 2026-11-08 (maintainer): reshape `Observation` together with | ||
| `MoqConnectionState`, one phase per value in both, so each binding converts | ||
| one enum to another (rejected: reshape only the binding records and keep | ||
| Rust's snapshot flat). | ||
|
|
||
| ## Related | ||
|
|
||
| - [Lifecycles are explicit state](/quest/m1/explicit-state/README.md) - the epic this item split from | ||
| - [Bindings' small surface fixes](/quest/m2/api-shape/bindings.md) - other breaking binding fixes before the cut | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.