Repository navigation
test(py): quarantine the TCP close test and plan its fix #8359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # [S] moq-rs's Python TCP close test settles on a promised error | ||
|
|
||
| ## Goal | ||
|
|
||
| `py/moq-rs/tests/test_socket.py`'s `test_tcp_rst_and_endpoint_close_are_errors` | ||
| passes on a loaded host, and its `pytest.mark.skip` is removed. It still | ||
| proves that a stream reset reaches the reader as `Protocol` with the app code, | ||
| and that an endpoint close never ends a reader with a clean EOF. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer's standing rule that flakes join this epic). | ||
| It failed once in [moq-dev/moq#8293](https://github.com/moq-dev/moq/pull/8293)'s | ||
| loaded `just check`, before a main merge, then passed 30 of 30 runs alone. The | ||
| reader after `a.close()` got `Unroutable`, while the test accepts only | ||
| `Cancelled` or `Closed`. The test uses an in-process origin with no lite-07 | ||
| session, so #8293's route changes can't reach it. | ||
|
|
||
| Find which path turns the endpoint's retraction into `Unroutable` for a stream | ||
| that was already open: the socket module's route lookup, or the origin | ||
| retracting the peer's broadcast before the stream's reset lands. Decide whether | ||
| `Unroutable` is a cause the socket contract should promise here (then document | ||
| it on `moq.socket` and accept it in the test) or a wrong error for an already | ||
| routed stream (then fix the cause so `Cancelled` or `Closed` wins). Prefer the | ||
| fix if the error leaks to users of a stream they already held. Never match on | ||
| error text. | ||
|
|
||
| Public API: none, unless the contract's documented errors change. Wire: none. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the endpoint-close half of this test flakes. The reset assertions just below (
abort(17)reaching the reader asProtocolwith code64 + 17) are deterministic, and no other Python test asserts the app code after a stream reset. Splitting that half into its own test would keep it in the gate while the close half stays quarantined.