Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/common/worklet.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ test("worklet modules load a lazy blob or a hosted script, leaving no child proc
});

// A page that calls assets() in dev fetches the same path a build emits, so the dev server serves it.
test("the dev server serves hosted worklets where builds emit them", async () => {
// Quarantined: flaky under load, see /quest/m0/test-flakes-2/worklet-dev-server.md
test.skip("the dev server serves hosted worklets where builds emit them", async () => {
const dir = mkdtempSync(join(tmpdir(), "worklet-"));
const server = await createServer({
configFile: false,
Expand Down
7 changes: 7 additions & 0 deletions quest/m0/test-flakes-2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@ cancelled one missed an appended group during
[moq-dev/moq#8363](https://github.com/moq-dev/moq/pull/8363)'s loaded
`just check`. It is quarantined with `t.Skip` until its child fixes it.

Added 2026-11-09 (maintainer, `/quest-complete`, under the flaky-test rule):
`js/common/worklet.test.ts`'s dev-server test, a candidate for bun's 5 s timeout
in a loaded full `just check` on [moq-dev/moq#8325](https://github.com/moq-dev/moq/pull/8325).
The failed log was not retained, so the failing test is unconfirmed.
It is quarantined with `test.skip` until its child fixes it.

Added 2026-11-09 (maintainer, /quest-complete): interop's `finish` cases with
a cpp or rust publisher, which failed under a loaded host and passed on rerun.
They are quarantined until their child fixes them.
Expand All @@ -257,6 +263,7 @@ Public API: none. Wire: none.

## Required

- [js/common's worklet dev-server test holds up under load](/quest/m0/test-flakes-2/worklet-dev-server.md) - the dev-server test passes on a loaded host, and its `test.skip` is removed
- [js/net's lite-07 datagram queue test holds up under load](/quest/m0/test-flakes-2/datagram-queues.md) - the test waits for the first track's queue instead of asserting at once, and its `test.skip` is removed
- [Interop's cpp and rust finish cases hold up under load](/quest/m0/test-flakes-2/interop-finish.md) - the publishers' finish cells pass under load, and their quarantine is removed
- [The Go wrapper's cancelled-RecvGroup test holds up under load](/quest/m0/test-flakes-2/go-recv-cancel.md) - a `RecvGroup` after a cancelled one is woken by the next group, and its `t.Skip` is removed
50 changes: 50 additions & 0 deletions quest/m0/test-flakes-2/worklet-dev-server.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# [S] js/common's worklet dev-server test holds up under load

## Goal

`js/common/worklet.test.ts`'s "the dev server serves hosted worklets where
builds emit them" passes on a loaded host, and its `test.skip` is removed. The
fix lands at the cause of the timeout, never by raising bun's 5 s test timeout
or adding a retry.

## Plan

Decided 2026-11-09 (maintainer, `/quest-complete`), under the repository's
flaky-test rule: quarantine the test and plan a quest. Rejected: leave it
enabled and watch it.

Evidence: a full `just check` on
[moq-dev/moq#8325](https://github.com/moq-dev/moq/pull/8325)'s branch, with the
host loaded, hit bun's 5 s timeout in `js/common/worklet.test.ts`. The test
passed alone and on a second full run. The log of the failed run was not kept,
so which test timed out is unconfirmed.

Candidate, unconfirmed: the dev-server test. It is the only one that opens real
sockets, starts a Vite dev server, makes several requests, and awaits
`server.close()` in its `finally`. Alone on 2026-11-09 it took 322 ms, against
208 ms for the lazy-blob test. The file reported 4.98 s for its two tests,
though their bodies took about 0.5 s together. The rest of that time is outside
the test bodies and was not measured, so it is not evidence either way.

Reproduction attempts, all on 2026-11-09, all passing:

- `bun test js/common/worklet.test.ts --rerun-each 60` on the already loaded
host: 120 of 120.
- The same with 48 CPU burners and `--rerun-each 150`: 300 of 300.
- The root JS set (`api`, `constructors`, `deps`, `worklet`, `release`, which
bun runs in one process) with 48 burners and `--rerun-each 20`: 640 of 640.

Suspected, not confirmed: the dev server's setup or `close()` waits on I/O under
load past the 5 s budget; or state from an earlier file in the same bun process
(the root set shares one process) delays this test's timers. Temporarily remove
the candidate's `test.skip` locally first, since a skipped test cannot fail.
Reproduce the failure: run the root `bun test` set under a loaded `just check`,
and keep the log with the failing test's name. Then fix the step that outruns the
budget: wait on an event the test can observe, not a longer deadline or a
retry. If the failure is in the shared process rather than the test, fix it
there.

The earlier round already fixed other `worklet.test.ts` flakes, so this is a new
cause, not a regression of those.

Public API: none. Wire: none.