Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ quests that require them.
- [Cluster routing](/quest/m2/cluster-routing/README.md) - prove shared routing contracts, implement per-origin routes, and connect outbound local clusters
- [A group a subscriber gives up on is always reported](/quest/m2/group-drops.md) - the wire names every abandoned group and the drop signal is public, so readers count losses instead of stalling
- [Stream credit by priority](/quest/m1/stream-credit/README.md) - every stream opens through one priority entry point, and a higher-priority group takes over or resets a lower one when credit runs out (held in m1 by an open claim)
- [Minted instances are a typed flag](/quest/m2/instance-provenance.md) - whether a session minted an instance is a typed flag on `Instance`, carried explicitly on lite-07 instead of a `~` prefix
- [Finalize moq-lite-07](/quest/m2/lite07-finalize.md) - when the maintainer cuts it, lite-07 negotiates as `moq-lite-07` and the next release ships it
- [Unbounded groups](/quest/m2/unbounded-groups/README.md) - groups and frames lose their size caps; a group keeps a 32 MB tail, and readers behind it replay through paced flights or refresh
- [moq-video codecs split submission from receive](/quest/m2/video-codec-receive.md) - video encoders and decoders submit, then `receive` one output, the shape moq-audio took, so no call allocates a `Vec` of outputs
Expand Down
6 changes: 6 additions & 0 deletions quest/m3/layers/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,9 @@ Decided 2026-11-08 (maintainer, moq-dev/studio /quest-plan):
maps priority onto moq-lite's subscription priorities and unsubscribes a
toggled-off layer.
- m3: moq-dev/studio is the named consumer, and its side sits in its m2.

## Required

- [hang specifies a layer layout track](/quest/m3/layers/spec.md) - a versioned layout track in the hang draft, `rs/hang`, and `js/hang` that both players composite
- [moq play composites layers](/quest/m3/layers/play.md) - `moq play` composites visible layers and mixes their audio
- [The watch player composites layers](/quest/m3/layers/watch.md) - `@moq/watch` composites visible layers, mixes their audio, and toggles them
Comment on lines +38 to +42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block contradicts the quest version the repository pins. quest check does not fail on main — the Quest workflow passed on 147327e with quest 6a18b8a, and that revision's guide says an epic's README lists none of its children while its Required never lists its own quests. The same applies to the instance-provenance entry added at quest/m2/README.md:198.

Technical details
# Quest child lists are not required at the pinned revision, and are rejected by the next one

## Affected sites
- quest/m3/layers/README.md:38-42 — adds a `## Required` list for the epic's own three children
- quest/m2/README.md:198 — adds a `Required` entry for `instance-provenance.md`, which `quest/m2/README.md` holds

## Evidence
- `flake.lock` pins `nodes.quest.locked.rev` to `6a18b8a815c2d15d37d7433a619f961ec5a07165` (bumped in #8193), which already includes #518 (`7f17c66`, "epics list no children").
- Running the core `check` from that revision reports 0 findings on main `147327e` and 0 on this branch. The `Quest` workflow on main at `147327e` concluded `success` (run 42720548077), and this PR's `Check` passed.
- The findings in the PR body reproduce only on quest before #518: at `5397c57` (its parent) the tree reports exactly `quest/m3/layers/README.md: quest title must be '# [XS|S|M|L|XL] Title'`, the three `not listed in quest/m3/layers/README.md's '## Required'` findings, and `quest/m2/instance-provenance.md: not listed ...`.
- The guide shipped at the pin (`assets/AGENTS.md`) says an epic's README "lists none of" its children, and "an epic's [Required] never lists its own quests, which it already waits for".
- Quest `f3a9069` (#554, merged after the pin) reports `requires X, which this epic holds` for exactly these entries, and `quest check --fix` removes them. The next pin bump past it will delete all four lines.
- #8291 created `quest/m3/layers/README.md` and #8266 created `quest/m2/instance-provenance.md`, both after the pin bump and both deliberately without a child list.

## Required outcome
- Do not merge the hand-added child lists. Either close this as unnecessary (main passes at the pin), or, if adopting the newer quest contract is the goal, bump the pin and run `quest check --fix` in its own PR — that migrates the whole tree's legacy child lists rather than adding new ones.