Repository navigation
quest: unblock 2026-11-09 waits, round 2 #8403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,9 +7,7 @@ The `release` line's hand-written Dart wrapper that gained `drain()` in | |
| [`moq`](https://pub.dev/packages/moq) 0.1.1, is on pub.dev. | ||
|
|
||
| Check: pub.dev lists the version. It is already set on `release` | ||
| (`dart/moq/pubspec.yaml`), so this needs a tag push, not code. The publish | ||
| is outward-facing, so the maintainer runs it; agents do not push tags, | ||
| dispatch workflows, or bump versions. | ||
| (`dart/moq/pubspec.yaml`), so this needs a tag push, not code. | ||
|
|
||
| ## Plan | ||
|
|
||
|
|
@@ -39,8 +37,22 @@ are ready, and merge `main` into `release` for the next minor line | |
| separately, later. Not chosen: one combined cut that merges `main` first, or | ||
| neither this week. | ||
|
|
||
| Decided 2026-11-09 (maintainer, /quest-unblock): ✅ an agent pushes | ||
| `moq-dart-v0.1.1` at `release`'s head once the combined cut's release-plz | ||
| PR, [moq-dev/moq#8378](https://github.com/moq-dev/moq/pull/8378), merges | ||
|
Comment on lines
+41
to
+42
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Raise the The The package script retains that constraint. A consumer that resolves 0.4.18 can therefore fail to compile
|
||
| (rejected: tag before #8378 merges; the maintainer pushes it). Then it checks | ||
| that `release-dart.yml` succeeds and pub.dev lists 0.1.1, and deletes this | ||
| quest. | ||
|
|
||
| Public API: none. Wire: none. | ||
|
|
||
| ## Waiting | ||
|
|
||
| - moq-dev/moq: the combined patch cut's release-plz PR, | ||
| [moq-dev/moq#8378](https://github.com/moq-dev/moq/pull/8378), merges into | ||
| `release`. Check with `gh pr view 8378 --repo moq-dev/moq --json state`; | ||
| then push the tag as the Plan's 2026-11-09 decision says. | ||
|
|
||
| ## Related | ||
|
|
||
| - [A Dart tag publishes unattended](/quest/m3/release/dart-publish.md) - proves the `moq-dart-v*` tag path this publish uses | ||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,8 +60,8 @@ moved path is rewritten. A recurring cut-gate child that its last run | |
| re-created in m3, such as the [vendor | ||
| sync](/quest/m3/vendor-sync/README.md), moves under the re-created | ||
| gate instead. That PR also removes this path from every `Required`, which | ||
| releases the audits waiting on it. It then re-creates the [cut | ||
| gate](/quest/m2/cut-gate/README.md) in m2 as that gate's Plan describes, and | ||
| releases the audits waiting on it. It then re-creates the cut gate at `quest/m2/cut-gate/README.md` from | ||
| the template below, and | ||
|
Comment on lines
+63
to
+64
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Preserve the template in the recreated cut. The recreated cut retains only its Goal and recurrence paragraph. The template and candidate recheck below are separate paragraphs, so the next cut will lose both instructions. Require the recreated cut to retain them.
|
||
| this quest, the [API shape review](/quest/m3/release/api-review.md), the | ||
| [feature review](/quest/m3/release/feature-review.md), and the [Cargo feature | ||
| review](/quest/m3/release/feature-flags.md) at the same paths under a fresh | ||
|
|
@@ -84,6 +84,27 @@ merged moq-e2ee and moq-sign into moq-crypto (decided 2026-11-02, no yank): | |
| already points at moq-crypto, and `rs/moq-e2ee` is gone. Don't merge a | ||
| `release` branch release-plz proposal that bumps it. | ||
|
|
||
| Cut gate template (moved here 2026-11-09 from the gate's own Plan; see the | ||
| decision below). The gate is an epic in m2 for the checks the cut needs that | ||
| break nothing: `main` is no slower than `release`, vendored code has the | ||
| upstream fixes it needs, and the hand-written `moq-c` is at parity with | ||
| moq-ffi. It has no work of its own and completes when every child merges. It | ||
| recurs once per release cycle, always in m2, and never re-creates itself: m2 | ||
| holds it and the cut requires m2, so a copy made before the cut would block | ||
| that cut forever. Re-create its README with that Goal and this recurrence, a | ||
| fresh "main is no slower than release" child with its Goal and no | ||
| measurements yet, and the [vendor sync](/quest/m3/vendor-sync/README.md) | ||
| questline that the last run re-created in m3. Only `/quest-delete` ends the | ||
| recurrence. | ||
|
|
||
| Decided 2026-11-09 (maintainer, /quest-unblock): the cut, not the gate, | ||
| confirms on its candidate commit that the gate's children's results still | ||
| hold, and records that commit here. ✅ Move the recheck into the cut, and | ||
|
Comment on lines
+101
to
+102
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Link the performance evidence for the recheck. The deleted gate linked to
|
||
| delete the gate while it has no children (rejected: the gate requiring every | ||
| other m2 entry by hand; a /quest-plan interview). The gate had no children | ||
| left and nothing made it wait for the rest of m2, so it showed as ready, and | ||
| a candidate commit recorded then would go stale before the cut. | ||
|
|
||
| The [2026-10-22 release audit](https://github.com/moq-dev/moq/pull/7176) | ||
| closed with its fixes rechecked together. At source candidate | ||
| [main 487759f62a](https://github.com/moq-dev/moq/commit/487759f62a9ef39d916fe5b92df06dcff83478ce), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line now runs to 107 columns where the rest of the file wraps near 78, and the clause reads awkwardly without
that(plus the cut gate the release cut re-creates there). Rewrapping asplus the cut gate that the [release cut](/quest/m3/release/cut.md) re-creates there.would fix both; the reworked sentence atquest/m3/release/cut.md:63-64has the same over-long line.