Repository navigation
quest: plan Nightly's Windows platform job passing #8405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # [S] Nightly's Windows platform job passes | ||
|
|
||
| ## Goal | ||
|
|
||
| The `Windows` job of `platform.yml` passes on `main`, both as Nightly's | ||
| `platform / Windows` and on `workflow_dispatch` runs and release PRs. Every | ||
| Windows-only warning or Linux-only crate it trips on is fixed at its cause, | ||
| not silenced for the job. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, from | ||
| [moq-dev/moq#8251](https://github.com/moq-dev/moq/pull/8251)'s follow-ups, | ||
| /quest-unblock). Known causes: | ||
|
|
||
| - `moq-vaapi` is not gated to Linux under `--all`, so the Windows build tries | ||
| to compile it. | ||
| - `moq-relay`'s memory integration test leaves items unused on Windows, | ||
| which `build.warnings = deny` turns into errors. | ||
| - The 2026-11-09 dispatch on `quest/m2/video-codec-receive` | ||
| ([run](https://github.com/moq-dev/moq/actions/runs/42635646987)) failed | ||
| `just rs test -p moq-video --no-default-features --features render` on a | ||
| `dead_code` warning at `rs/moq-video/src/encode/backend/mod.rs:84`. Check | ||
| whether `main` has it too. | ||
|
|
||
| Reproduce each on a `workflow_dispatch` of `platform.yml` for this branch | ||
| before and after the fix. Gate platform-specific crates and items with `cfg` | ||
| where they are defined, so a later Windows-only warning shows up as one new | ||
| error rather than a pile. | ||
|
|
||
| Public API: none. Wire: none. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of these were fixed on
mainby moq-dev/moq#8258, merged 2026-11-08:rs/moq-vaapi/src/lib.rs:20now has#![cfg(target_os = "linux")], andrs/moq-relay/tests/integration/memory.rs:8-9gates theDurationimport (withrungated too). The 2026-11-09 dispatch cited just below confirms it: the compile andmoq-relaytest steps pass there, and only themoq-videowarning fails the job, so these bullets send the implementer to reproduce work that is already done.Technical details