Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m0/nightly/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ near the paired threshold (re-check if one repeats), a one-off
## Required

- [Nightly's macOS platform job passes](/quest/m0/nightly/macos.md) - `moq-audio`'s tests compile on macOS again and the websocket version test's timeout is fixed if it recurs
- [Nightly's Windows platform job passes](/quest/m0/nightly/windows.md) - `moq-vaapi` is gated to Linux and Windows-only unused items are fixed, so `platform.yml`'s Windows job builds and tests cleanly
31 changes: 31 additions & 0 deletions quest/m0/nightly/windows.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# [S] Nightly's Windows platform job passes

## Goal

The `Windows` job of `platform.yml` passes on `main`, both as Nightly's
`platform / Windows` and on `workflow_dispatch` runs and release PRs. Every
Windows-only warning or Linux-only crate it trips on is fixed at its cause,
not silenced for the job.

## Plan

Planned 2026-11-09 (maintainer, from
[moq-dev/moq#8251](https://github.com/moq-dev/moq/pull/8251)'s follow-ups,
/quest-unblock). Known causes:

- `moq-vaapi` is not gated to Linux under `--all`, so the Windows build tries
to compile it.
- `moq-relay`'s memory integration test leaves items unused on Windows,
which `build.warnings = deny` turns into errors.
Comment on lines +16 to +19

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these were fixed on main by moq-dev/moq#8258, merged 2026-11-08: rs/moq-vaapi/src/lib.rs:20 now has #![cfg(target_os = "linux")], and rs/moq-relay/tests/integration/memory.rs:8-9 gates the Duration import (with run gated too). The 2026-11-09 dispatch cited just below confirms it: the compile and moq-relay test steps pass there, and only the moq-video warning fails the job, so these bullets send the implementer to reproduce work that is already done.

Technical details
# Scope the Plan to the remaining Windows failure

## Affected sites
- `quest/m0/nightly/windows.md:16-19` β€” the two stale causes.
- `quest/m0/nightly/README.md:54` β€” the summary repeats the same two fixed items and omits the `moq-video` cause.

## Required outcome
- The Plan names only causes that still reproduce on a dispatch of this branch, and records #8258 as the reason the first two no longer do.

## Evidence
- `rs/moq-vaapi/src/lib.rs:20` β€” `#![cfg(target_os = "linux")]`, added by #8258.
- `rs/moq-relay/tests/integration/memory.rs:8-9` β€” `Duration` import behind `test-support`, also from #8258; `run` at line 367 is gated the same way.
- Run 42635646987 on `6c0d45e9`: `just rs windows --all` and the `moq-relay` nextest step pass; only `just rs test -p moq-video --no-default-features --features render` fails on `encode_all` at `rs/moq-video/src/encode/backend/mod.rs:84`.
Suggested change
- `moq-vaapi` is not gated to Linux under `--all`, so the Windows build tries
to compile it.
- `moq-relay`'s memory integration test leaves items unused on Windows,
which `build.warnings = deny` turns into errors.
- `moq-vaapi`'s Linux gating and `moq-relay`'s unused items already landed
in [moq-dev/moq#8258](https://github.com/moq-dev/moq/pull/8258); confirm
they stay fixed on the dispatch, but they need no work. The remaining
cause:

- The 2026-11-09 dispatch on `quest/m2/video-codec-receive`
([run](https://github.com/moq-dev/moq/actions/runs/42635646987)) failed
`just rs test -p moq-video --no-default-features --features render` on a
`dead_code` warning at `rs/moq-video/src/encode/backend/mod.rs:84`. Check
whether `main` has it too.

Reproduce each on a `workflow_dispatch` of `platform.yml` for this branch
before and after the fix. Gate platform-specific crates and items with `cfg`
where they are defined, so a later Windows-only warning shows up as one new
error rather than a pile.

Public API: none. Wire: none.