Repository navigation
test(interop): quarantine the finish scenario for every publisher #8407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,36 @@ | ||
| # [S] Interop's cpp and rust finish cases hold up under load | ||
| # [S] Interop's finish cases hold up under load | ||
|
|
||
| ## Goal | ||
|
|
||
| `just test interop --finish --all` passes its `finish cpp -> *` and | ||
| `finish rust -> *` cells on a loaded host, and their quarantine in | ||
| `test/interop/interop.sh`'s `run_finishes` is removed. | ||
| `just test interop --finish --all` passes every `finish <publisher> -> *` cell | ||
| on a loaded host, and the scenario's quarantine in `test/interop/interop.sh`'s | ||
| `run_finishes` is removed. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-complete), under the repository's | ||
| flaky-test rule. Two agents' local `just test interop --all` runs, both under a | ||
| host load average above 30, failed once each and passed on rerun. No logs were | ||
| kept. | ||
| flaky-test rule, and widened the same day to every publisher. Local | ||
| `just test interop --all` runs under a host load average above 30 failed once | ||
| each and passed on rerun. No logs were kept. | ||
|
|
||
| - All nine `finish cpp -> *` cells failed together, while iterating | ||
| [moq-dev/moq#8358](https://github.com/moq-dev/moq/pull/8358). | ||
| - The `finish rust -> *` cells failed, while iterating | ||
| [moq-dev/moq#8220](https://github.com/moq-dev/moq/pull/8220): the Rust | ||
| publisher never printed `finish acknowledged`, though every reader ended | ||
| clean. | ||
| - The `finish go -> *` cells failed, while iterating | ||
| [moq-dev/moq#8366](https://github.com/moq-dev/moq/pull/8366). The same run | ||
| also failed `js -> c` and `rust-swapped -> js-native-node` once; those lanes | ||
| are not quarantined, only recorded here as seen under the same load. | ||
|
|
||
| Suspected, not confirmed: with three publishers failing `finish` the same way, | ||
| the cause is shared, most likely the harness's own waits under load (the | ||
| publisher's wait for the finish acknowledgement, the FIFO the runner writes | ||
| after every reader ends, and the readers' deadlines), not one implementation. | ||
|
|
||
| Reproduce it first, under load as the epic describes, with the interop logs | ||
| kept. Suspected, not confirmed: the publisher's wait for the finish | ||
| acknowledgement (the FIFO the runner writes after every reader ends). That | ||
| cpp's cells all failed together also points at its publisher rather than any | ||
| reader. Fix the cause, never with a longer limit, then remove the quarantine. | ||
| kept, and check whether the two unquarantined lanes fail the same way. Fix the | ||
| cause, never with a longer limit, then remove the quarantine. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
Requiredentry now covers every publisher, but the provenance paragraph three lines up (quest/m0/test-flakes-2/README.md:252-254) still reads "interop'sfinishcases with a cpp or rust publisher … They are quarantined until their child fixes them". Since the code now quarantines all five publishers, that decision record understates what the epic is tracking. Widening it to "interop'sfinishcases with any publisher" (and noting the go failures) keeps the epic consistent withrun_finishes.