Repository navigation
quest: plan Nightly's qmux-bench handshake regression #8408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # [S] Nightly's WebSocket fallback benchmark connects again | ||
|
|
||
| ## Goal | ||
|
|
||
| The scheduled Nightly's Audio quality job passes its "WebSocket fallback | ||
| startup benchmark" step (`just js qmux-bench`) on `main`, fixed at the cause | ||
| of its handshake timeout, so the job fails only on real audio results. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-unblock). The step passed on the | ||
| 2026-11-05 and 2026-11-06 scheduled Nightlies, then failed on 2026-11-07, | ||
| 11-08 and 11-09 ([run 42659882487](https://github.com/moq-dev/moq/actions/runs/42659882487)) | ||
| with `error: evaluate: Error: handshake timeout` from the Playwright | ||
| evaluate in `qmux-bench`. That's a regression, not a flake. The window is | ||
| [fbef872b](https://github.com/moq-dev/moq/commit/fbef872bdc7f2ec619ae515626d6cd07d3926445)..[b5805859](https://github.com/moq-dev/moq/commit/b5805859aa6bf856c1a96ab3af89d45757de8e3d) | ||
| (120 commits). Likely suspects, to check first: | ||
|
|
||
| - [moq-dev/moq#8054](https://github.com/moq-dev/moq/pull/8054): QMux sessions return once established. | ||
| - [moq-dev/moq#8021](https://github.com/moq-dev/moq/pull/8021): send-rate estimates sampled from one page-wide ticker. | ||
| - [moq-dev/moq#8078](https://github.com/moq-dev/moq/pull/8078): a bun test fails when its own timer fires on the host clock. | ||
|
|
||
| Reproduce locally with `just js qmux-bench`, bisect the window if no suspect | ||
| explains it, and list the culprit under the fix PR's `## Caused by`. | ||
|
Comment on lines
+11
to
+24
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Technical details# Stale plan: the cause is already fixed by #8351
## Affected sites
- `quest/m0/nightly/qmux-bench-handshake.md:17` — the suspects list leads with #8054, already confirmed as the culprit in #8351's `## Caused by`.
- `quest/m0/nightly/qmux-bench-handshake.md:23` — "reproduce ... bisect the window if no suspect explains it" repeats the diagnosis #8351 already did.
- `quest/m0/nightly/README.md:54` — the bullet re-adds the child #8351 deleted.
## Required outcome
- The quest stops re-planning the investigation, or the PR is dropped. The cause is fixed on `main`; the only unverified piece is the next scheduled Nightly, which the epic README's own "Confirm a scheduled run on `main` passes" already owns.
- If the intent is to confirm #8351's fix rather than re-investigate, say so and point at the next scheduled run, and drop the three suspects.
## Open questions for the human
- Was this plan kept deliberately after #8351 landed? The body's `## Decisions` does not mention it.
Comment on lines
+23
to
+24
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update the plan for the existing fix. PR Link the existing fix and make the remaining task confirmation on a scheduled Nightly, or remove this duplicate quest.
|
||
|
|
||
| Public API: none expected. Wire: none expected. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## ModelsrecordsSize: XS, but the quest title and the body's own Changes list say[S]; the quest CONTEXT defines the Models size as the quest's size. One of the two needs to change so the implementer run is sized correctly.