Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m0/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ edge, which embeds moq-relay; it moved there on 2026-09-28.

## Required

- [The C bindings accept MoqInstance again](/quest/m0/check-c-moqinstance.md) - `check c` passes on main once the C generator stops refusing `MoqInstance`'s exported `Debug`
- [Nightly passes on main](/quest/m0/nightly/README.md) - the scheduled Nightly passes end to end, so red means a new break
- [Interop and Video pass on main](/quest/m0/interop-green/README.md) - the scheduled Interop and Video workflows pass, so red means a new break
- [@moq/clock's Instant has no throwing Duration arithmetic, mirroring kio](/quest/m0/peer-arithmetic.md) - JS `Instant` drops `add`/`sub` for checked and saturating forms, so each call site states what overflow means, as kio's do
Expand Down
24 changes: 24 additions & 0 deletions quest/m0/check-c-moqinstance.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# [XS] The C bindings accept MoqInstance again

## Goal

`check c` in `just check` passes on `main`. The C bindings generator stops
refusing `MoqInstance`, whose `#[uniffi::export(Debug, Display, Eq, Hash)]`
in `rs/moq-ffi/src/instance.rs` exports a `Debug` trait method the generator
can't render. Every branch's local `just check` fails on it until then.

## Plan

Planned 2026-11-09 (maintainer, /quest-unblock), after
[moq-dev/moq#8375](https://github.com/moq-dev/moq/pull/8375)'s iterate found
`check c` failing identically on a clean `origin/main`. It came in with
[moq-dev/moq#8366](https://github.com/moq-dev/moq/pull/8366) (minted instances
are a typed flag), merged 2026-11-10 03:04 UTC; list it under the fix's
`## Caused by`.

Either stop exporting `Debug` (keep `Display`, `Eq`, and `Hash` if the other
bindings use them), or have the C generator handle or skip exported trait
methods the way it handles the others. Prefer the change that keeps every
binding at the same functionality, as the root `AGENTS.md` requires.

Public API: possibly a binding's debug string for `MoqInstance`. Wire: none.