Repository navigation
quest: plan the 2026-11-09 deletion audit and prune m5 #8423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # [M] CI lanes that fail or repeat the queue are cut | ||
|
|
||
| ## Goal | ||
|
|
||
| Every workflow either produces a signal someone reads or is gone. Today | ||
| `cache.yml` fails every run, `cache-refresh.yml` has never passed, | ||
| `mutants.yml` has never produced a result, and three workflows re-run on | ||
| `main` what the merge queue already ran. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-plan from the deletion audit). | ||
| Decided: ✅ CI trims (rejected: leave CI as the 2026-11-01 workflow audit | ||
| kept it). Joins m0 because `cache.yml` is broken now (rule: broken CI is m0). | ||
|
|
||
| - `cache.yml`: every push to `main` fails in the warm jobs with | ||
| `does not contain a 'flake.nix'` (the `roots` recipe runs outside the | ||
| checkout), including the macOS job. Fix it and add it to `alert.yml`, or | ||
| delete it if the R2 and nix.moq.dev caches already cover what it warms; | ||
| reproduce first and say which in the PR. Check | ||
| [Cachix retire](/quest/m0/ci/cachix-retire.md), which also edits it. | ||
| - Delete `cache-refresh.yml`. It guards against weeks without a merge, and | ||
| `main` lands more than ten PRs a day. | ||
| - Delete `mutants.yml`. Its one run failed all 24 shards creating | ||
| `target/mutants`, and `test/drill/sensitivity.sh` already runs hand-written | ||
| mutations nightly. This PR deleted its quest. | ||
| - `codspeed.yml` moves from every Rust push on `main` to the nightly | ||
| schedule. It gates nothing, and 62 of its last 100 runs were cancelled by | ||
| the next push. The 2026-10-28 decision to keep CodSpeed stands; only its | ||
| trigger changes. | ||
| - `check.yml` stops running for PRs into `main` and keeps `release` | ||
| admission; the queue runs the same `just ci`. | ||
| - `quest.yml` drops its `main` push trigger and keeps `release` and | ||
| `quest/**`; `main` lands only through the queue, which runs the quest | ||
| checks. | ||
|
|
||
| Update the rows these change in [CI workflow audit](/quest/m3/audit-ci.md) | ||
| and any doc naming the removed workflows. | ||
|
|
||
| Public API: none. Wire: none. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # [M] The recurring audits are fewer and carry plans, not results | ||
|
|
||
| ## Goal | ||
|
|
||
| m3's 13 recurring `audit-*.md` quests become about five, each a Goal plus a | ||
| short "check first" list. Results and baselines live in the PR that measured | ||
| them, not in the plan. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-plan from the deletion audit). | ||
| Decided: ✅ merge the audits (rejected: keep 13 separate recurring audits). | ||
|
|
||
| The 13 files total about 23.6k words, mostly result tables from past runs | ||
| (`audit-ci.md` alone is about 7,400 words describing one Nightly). | ||
| Several overlap: dead code against simplify, CI against test cost, and deps, | ||
| size, and compile time all trace back to dependencies. The same ~150-word | ||
| recurrence paragraph is copied into each. | ||
|
|
||
| Recommended grouping, the implementer's call: | ||
|
|
||
| - Cost: CI, test cost, compile time, artifact size, dependencies. | ||
| - Code: dead code, simplification, lints. | ||
| - Tests: coverage. | ||
| - Docs. | ||
| - Interop. | ||
| - Performance. | ||
|
|
||
| Delete [quest tree audit](/quest/m3/audit-quests.md); `/quest-audit` does | ||
| that job. Keep each merged audit's "decided" carve-outs and the still-useful | ||
|
Comment on lines
+29
to
+30
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Preserve the recurring tree-audit trigger.
|
||
| "check first" items. Drop result tables, measured baselines, and history, | ||
| linking the PR that recorded them instead. Each merged audit keeps the | ||
| recurrence rule (successor added by the PR that finishes a run, behind the | ||
| [release cut](/quest/m3/release/cut.md)), stated once per file in a line or | ||
| two. Update m3's README links and anything else that links a merged file. | ||
|
|
||
| [CI lane trims](/quest/m0/ci/trim.md) edits `audit-ci.md` rows; whichever | ||
| lands second adapts. | ||
|
|
||
| Public API: none. Wire: none. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # [S] The CARLA bridge builds outside the root workspace | ||
|
|
||
| ## Goal | ||
|
|
||
| `demo/carla/bridge` is no longer a root Cargo workspace member, so workspace | ||
| builds, checks, and `cargo` metadata stop compiling a demo bridge, while the | ||
| bridge still builds and is checked when its own files change. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-plan from the deletion audit). | ||
| Decided: ✅ exclude it from the workspace (rejected: keep it a member; | ||
| move it to its own repository). | ||
|
|
||
| The bridge is the root `Cargo.toml`'s first `members` entry. Give it its own | ||
| workspace and lock file, keep its check in the dispatch for `demo/carla/**` | ||
| changes, and keep the files where they are: moq.pro reads | ||
| `demo/carla/sim/trucks.json` from its pin. Check the GPU end-to-end test in | ||
| [vendor-free CARLA bridge](/quest/m5/carla-bridge.md) and | ||
| [macOS check](/quest/m0/macos-check.md), which touch the bridge, still find | ||
| it. | ||
|
|
||
| Public API: none. Wire: none. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # [S] Draft publishing keeps the upload and drops changelog rewriting | ||
|
|
||
| ## Goal | ||
|
|
||
| `sh/drafts/publish.sh` uploads a draft to the datatracker and nothing else | ||
| automated: the changelog heading rewriting, about half of its 298 lines, and | ||
| most of the 653-line `publish.test.sh` that every `just drafts check` runs | ||
| are gone. The 17 drafts publish a few times a year, so the author edits the | ||
| changelog by hand. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-plan from the deletion audit). | ||
| Decided: ✅ trim (rejected: keep the automation). | ||
|
|
||
| Keep whatever test still guards the upload path. Update `drafts/` docs or | ||
| CONTRIBUTING text that describes the removed step. | ||
|
|
||
| Public API: none. Wire: none. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # [S] .github/ffi.md holds rules, not evidence | ||
|
|
||
| ## Goal | ||
|
|
||
| `.github/ffi.md` states the FFI release layout and its rules in about a | ||
| sixth of its 264 lines. The one-off evidence moves out: SHA comparisons, | ||
| runner image versions, OpenH264 assembly differences, and runner-minute | ||
| tables belong to the PRs that measured them. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-plan from the deletion audit). | ||
| Decided: ✅ trim (rejected: leave as is). | ||
|
|
||
| Link the PR for any evidence a rule still rests on. Drop the temporary rule | ||
| that accepts legacy per-language workflow names for a tag cut from a | ||
| `release` older than the coordinator once `release` carries the | ||
| coordinator; if it does not yet, keep that rule and say when it goes. | ||
|
|
||
| Public API: none. Wire: none. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # [S] rs/AGENTS.md's time-test rule matches the tree | ||
|
|
||
| ## Goal | ||
|
|
||
| `rs/AGENTS.md` tells an agent writing a time-dependent Rust test what the | ||
| tree actually does. Its rule says such tests call `tokio::time::pause()` and | ||
| that only moq-net and moq-relay's in-memory tests use `#[kio::test]`; the | ||
| tree has about 4,900 `kio::test` uses (moq-mux, moq-tokio, moq-ffi, and | ||
| more) against about 200 `pause()` calls. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-plan from the deletion audit, which | ||
| the maintainer prompted). Decided: ✅ fix the stale rule (rejected: leave it). | ||
|
|
||
| Follow `quest guide prompting`. State the rule once: the time-mocking rule | ||
| also appears in `quest context`, `REVIEW.md`, `rs/moq-net/AGENTS.md`, and | ||
| `clippy.toml`, so drop any copy that only repeats it. Say when `pause()` is | ||
| still the right tool, if ever. | ||
|
|
||
| Public API: none. Wire: none. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # [S] Unused crates, scripts, and files are deleted | ||
|
|
||
| ## Goal | ||
|
|
||
| Code and files with no consumer, whose removal breaks no published API, are | ||
| gone: the `moq-room` crate, the `moq-native` tombstone, `demo/throttle`, | ||
| `sh/dart/publish.sh`, `demo/web`'s Solid dependencies, and release notes for | ||
| packages that never publish. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-plan from the deletion audit). | ||
| Decided: ✅ delete, in one PR with one commit each (rejected: keep them for | ||
| possible future use). | ||
|
|
||
| - `rs/moq-room`: `publish = false` since | ||
| [moq-dev/moq#6454](https://github.com/moq-dev/moq/pull/6454), no | ||
| workspace or binding consumer, and `doc/lib/rs/moq-room.md` already points | ||
| users to `@moq/room`. Delete the crate, its workspace entry, and its doc | ||
| page, and rewrite [room alias withdraw](/quest/m3/room-alias-withdraw.md) | ||
| to JS only. `@moq/room` stays. | ||
| - `rs/moq-native`: the 0.20.0 tombstone has been on crates.io since | ||
| 2026-09-23 and stays there. Remove the crate and its workspace entry so the | ||
| shared-minor cut cannot publish another tombstone. The redirects in | ||
| `doc/worker.js` stay. | ||
| - `demo/throttle`: a macOS-only pf/dummynet script behind `just throttle` in | ||
| `demo/justfile`; moq-shaper does seeded, cross-platform impairment. | ||
| - `sh/dart/publish.sh`: no caller; the release workflows run | ||
| `dart pub publish` inline. | ||
| - `demo/web`: `solid-js`, `vite-plugin-solid`, and `solidPlugin()` with no | ||
| `.tsx` in the demo. | ||
| - Release notes for packages that never publish: `demo/boy/CHANGELOG.md`, | ||
| `js/p2p/MIGRATE.md`, `js/crypto/MIGRATE.md`, `rs/moq-quic/MIGRATE.md` | ||
| (157 lines), and the "unpublished API" paragraph in `rs/moq-congestion`'s | ||
| README. A package gets them when it first publishes. | ||
| - `rs/moq-rtmp/src/flv.rs` matches `moq_mux::Error::TimestampRewind` to | ||
| decide which demux failures end the session, against the rule never to | ||
| match on errors. Make the importer report that outcome as its own result | ||
| instead; how is the implementer's call. | ||
|
|
||
| Kept on purpose (2026-11-09): `Hang.Health` and `hang::health` have no | ||
| caller in this repository, but moq.pro's QoS line plans to use the client | ||
| health sample and classification. | ||
|
|
||
| Public API: none (moq-room and moq-native no longer publish). Wire: none. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,22 @@ Rejected in planning: | |
| - Folding these items into the larger quests: those wait on decisions or | ||
| prototypes, and these do not. | ||
|
|
||
| Added 2026-11-09 (maintainer, /quest-plan from the deletion audit): the | ||
| pre-cut sweep also deletes these, which a "used only by its definition" | ||
| search misses or which are not items: | ||
|
|
||
| - `@moq/watch`'s `Arrival`/`Arrivals` export and `decoder.arrivals()`: | ||
| only `test/audio-quality` uses them, and it can import from source. Not on | ||
| `release`, so removing them breaks nobody. | ||
| - `@moq/qmux`'s `install()`: no caller, and it cannot help Safari, which | ||
| ships a broken WebTransport rather than none. | ||
| - `moq-nvenc`'s `src/sys/windows_sys` (680 KB generated): moq-video depends | ||
| on moq-nvenc only under `cfg(target_os = "linux")`. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deleting Technical details# moq-nvenc stays a Windows build target
## Affected sites
- `rs/moq-nvenc/src/sys/mod.rs:22-25` — `mod windows_sys; pub use windows_sys::*;` on `target_os = "windows"`.
- `Cargo.toml:29` — `rs/moq-nvenc` is a default member; `rs/*` in `members` also matches it.
- `sh/rs/select.sh:147` — the `--all` path is `cargo check --workspace`, excluding only the fuzz crates.
- `.github/workflows/platform.yml:114` — the Windows job passes `--all` on non-PR events.
## Required outcome
- The bullet states how the crate keeps compiling on Windows after the bindings go (reuse `linux_sys`, gate the crate's Windows build, or drop it from the Windows selection), so the implementer does not delete the module and leave a red Windows lane.
Comment on lines
+69
to
+70
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Preserve the Windows workspace build.
Based on learnings: quest documents describe planned implementation work.
|
||
| - `moq-sock`'s `fast-apple-datapath` feature (`udp/apple_fast.rs`), which only | ||
| `just rs macos-test` enables, and its WASI arm (`udp/wasi.rs`), which no | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Technical details# Second enable site for fast-apple-datapath
## Affected sites
- `sh/rs/select.sh:258` — `flags+=(--features moq-sock/fast-apple-datapath)` inside the `platform` case, guarded by `uname -s == Darwin`.
- `rs/justfile:157` — the `macos-test` call the bullet names.
## Required outcome
- The bullet names both sites, or says the feature removal must update `sh/rs/select.sh` too. |
||
| target builds. Update [cmsg length on send](/quest/m3/cmsg-len-send.md), | ||
| which names the feature. | ||
|
|
||
| ## Required | ||
|
|
||
| - [A peer's closed session reads as Closed in the bindings](/quest/m2/api-shape/session-closed.md) - a remote SESSION_CLOSED maps to `MoqError::Closed`, as a local close does | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # [S] MoQ Boy is a demo, not a published package | ||
|
|
||
| ## Goal | ||
|
|
||
| The `moq-boy` crate and `@moq/boy` npm package stop publishing, and MoQ Boy | ||
| lives as a demo: no semver, CHANGELOG, MIGRATE, API report, or release tag. | ||
| The Solid UI it alone carries leaves the published surface with it. The | ||
| hosted demo keeps working. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-plan from the deletion audit). | ||
| Decided: ✅ unpublish (rejected: keep publishing; delete MoQ Boy). | ||
| Joins m2 because ending a published package is breaking. | ||
|
|
||
| - `rs/moq-boy`: `publish = false`, drop its CHANGELOG and MIGRATE, and drop | ||
| the `moq-boy-v*` tags from `release-nix.yml`. Keep the flake package | ||
| `moq-boy`: moq.pro's demo hosts build it from their pin. | ||
| - `js/moq-boy`: move into `demo/boy` as a private package with no API | ||
| report, MIGRATE, or trusted-publisher entry. | ||
| - `@moq/signals/solid` has no other consumer: delete it. Either rewrite the | ||
| Boy UI on `@moq/signals/dom`, as watch and publish do, or keep Solid | ||
| private to `demo/boy`; the implementer picks the smaller change. | ||
| - The release cut deprecates the last published versions on crates.io and | ||
| npm with a pointer to the demo. | ||
|
|
||
| Public API: breaking. `moq-boy` and `@moq/boy` stop publishing, and | ||
| `@moq/signals/solid` is removed. Wire: none. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # moq-transport is a compatibility layer again | ||
|
|
||
| ## Goal | ||
|
|
||
| Our moq-transport support covers what a third-party implementation needs to | ||
| exchange live media with ours, and stops there: SETUP, the standard | ||
| AUTHORIZATION TOKEN, live PUBLISH_NAMESPACE / SUBSCRIBE / PUBLISH, joining | ||
| FETCH, and relay forwarding between moq-transport and moq-lite sessions, | ||
| including across our relays. Our own extensions and the IETF-only features | ||
| nobody third-party uses are deleted from Rust, JS, and the drafts. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-11-09 (maintainer, /quest-plan from the deletion audit). | ||
| Decided: ✅ freeze the IETF scope (rejected: keep growing IETF features to | ||
| parity with lite). | ||
|
|
||
| AGENTS.md calls moq-transport "a low-effort compatibility layer", but Rust | ||
| `ietf/` is 62.3k lines (28.3k logic) against `lite/`'s 40.4k (21.0k logic), | ||
| and both `ietf/publisher.rs` and `ietf/subscriber.rs` grew by thousands of | ||
| lines since 2026-10-23. Since August, the Rust IETF code took 465 commits | ||
| against lite's 429. | ||
|
|
||
| Settled with this epic: | ||
|
|
||
| - Deleted from m5 by this PR, as work the freeze rules out: | ||
| moq-transport hole markers and moq-transport cluster peers. | ||
| - Kept: moq-transport drafts 18, 20, and 22 (draft 20 restored on purpose in | ||
| [moq-dev/moq#7190](https://github.com/moq-dev/moq/pull/7190)), and the | ||
| relay paths moq.pro's fleet smoke runs: cross-relay moq-transport | ||
| subscribes and a draft-18 session to a third-party relay. | ||
| - Kept, as rejected in the same interview: lite-07's `ietf` object extension | ||
| and moq-lite 01 to 04. | ||
| - Not here: `ietf/flate.rs`; compression removal has its own work. | ||
|
|
||
| This epic's own work, after its children: the docs that describe | ||
| moq-transport support (`doc/concept/`, `drafts/draft-lcurley-moq-ietf.md` if | ||
| it lists the extensions, and the interop matrix in | ||
| [interop audit](/quest/m3/audit-interop.md)) state the frozen scope, and | ||
| AGENTS.md's IETF rule is reworded only if the maintainer asks. | ||
|
|
||
| ## Related | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With no |
||
|
|
||
| - [Simplification audit](/quest/m3/audit-simplify.md) - owns duplication inside the IETF code that remains | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve Smoke’s cache revision source.
If
cache.ymlis deleted,.github/justfile’scache-revcan no longer find a new successful Cache run. The Nix Smoke job uses that revision, so it will fail to find one or remain pinned to an old commit. Plan a replacement revision source as well as cache coverage. (raw.githubusercontent.com)