Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .cargo/mutants.toml

This file was deleted.

7 changes: 0 additions & 7 deletions .github/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@ cache-rev:
fi
echo "$rev"

# Keep the newest cached commit's closures on nix.moq.dev past the bucket's expiry.
cache-refresh:
#!/usr/bin/env bash
set -euo pipefail
rev=$(just gh cache-rev)
just infra nix refresh nix-ci-moq-dev "$rev"

# Build the runner image with a temporary policy on a disposable hosted runner.
runner-vm-ci:
#!/usr/bin/env bash
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/alert.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: Alert

# Posts cron, release, and deployment failures to the Discord #alerts channel.
# PRs, branch validation, and cache warming stay on GitHub; the landing gate
# runs on the maintainer's host.
# PRs and branch validation stay on GitHub; the landing gate runs on the
# maintainer's host.
#
# Needs a DISCORD_WEBHOOK secret in the `alert` Environment (Discord: Channel >
# Integrations > Webhooks). Nothing else reads it.
Expand All @@ -15,7 +15,7 @@ on:
# `just gh check` enforces coverage and the exclusions in alert.sh.
workflows:
- apt-repo
- Cache refresh
- Cache
- CodSpeed
- Docker
- Interop
Expand All @@ -24,7 +24,6 @@ on:
- moq-gst
- moq-relay
- moq.sh
- Mutants
- Nightly
- release-brew
- Release C
Expand Down Expand Up @@ -71,7 +70,7 @@ jobs:
github.event.workflow_run.event != 'pull_request' &&
github.event.workflow_run.event != 'pull_request_target' &&
(github.event.workflow_run.event == 'schedule' ||
!contains(fromJSON('["Cache refresh", "Interop", "Mutants", "Nightly", "Smoke", "Smoke toolchain update", "TS", "Video"]'), github.event.workflow_run.name))
!contains(fromJSON('["CodSpeed", "Interop", "Nightly", "Smoke", "Smoke toolchain update", "TS", "Video"]'), github.event.workflow_run.name))
runs-on: ubuntu-latest
# The webhook lives in the `alert` Environment, which admits only `main`,
# where workflow_run runs. It is not a release credential, so it stays out
Expand Down
38 changes: 0 additions & 38 deletions .github/workflows/cache-refresh.yml

This file was deleted.

23 changes: 9 additions & 14 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ name: Check
permissions:
contents: read

# Ready main PRs run the merge queue's selection as a signal, never a gate.
# Release PRs run the same checks over every package, including while drafts.
# Release admission: release PRs run the queue's checks over every package,
# including while drafts. Main PRs get their verdict from the merge queue.
on:
pull_request:
# Closing or returning a main PR to draft cancels its in-flight run.
# Any edit reruns eligible PRs, including a retarget to main or release:
# skipping an edit would replace a failed context with a passing one.
# Release readiness transitions rerun its required gate for the same reason.
branches: [release]
# Any edit reruns, including a retarget to release: skipping an edit would
# replace a failed context with a passing one. Readiness transitions rerun
# the required gate for the same reason.
types: [opened, synchronize, reopened, edited, ready_for_review, converted_to_draft, closed]

# Cancel in-flight runs when a new commit lands on the same PR, or when the PR
Expand All @@ -23,29 +23,24 @@ jobs:
# One checkout, dev shell, cache restore, and dispatcher for lints and tests.
check:
name: Check
if: github.event.action != 'closed' && (github.base_ref == 'release' || (github.base_ref == 'main' && github.event.pull_request.draft == false))
if: github.event.action != 'closed'
runs-on: ubuntu-24.04-arm
# Backstop a hang instead of holding the runner for the 6-hour default.
timeout-minutes: 60
env:
# The fetched branch includes base changes since the PR event's base.sha.
CI_BASE: ${{ github.base_ref == 'release' && '--all' || 'origin/main' }}

steps:
- name: Checkout
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
# Full history for the dispatcher's base comparison.
fetch-depth: 0

- uses: ./.github/actions/just

# The dispatcher owns scope, including repository-wide lints. A query
# failure fails this job; an empty selection keeps its required name green.
- name: Select work
id: scope
run: just ci-select "$CI_BASE" >> "$GITHUB_OUTPUT"
run: just ci-select --all >> "$GITHUB_OUTPUT"

- uses: ./.github/actions/nix
if: steps.scope.outputs.needed == 'true' && runner.environment != 'self-hosted'
Expand All @@ -65,7 +60,7 @@ jobs:
if: steps.scope.outputs.needed == 'true'
run: |
rm -rf target/cargo-timings
nix develop --command just ci "$CI_BASE"
nix develop --command just ci --all

# Cargo's per-crate timings for the Rust test builds, so a slow crate
# shows without rebuilding. The job summary has the per-module times.
Expand Down
21 changes: 4 additions & 17 deletions .github/workflows/codspeed.yml
Original file line number Diff line number Diff line change
@@ -1,26 +1,13 @@
name: CodSpeed

# CPU-simulated instruction counts for the deterministic Criterion benches on
# every main commit. An extra signal beside Nightly's paired timing, which still
# CPU-simulated instruction counts for the deterministic Criterion benches,
# nightly on main. An extra signal beside Nightly's paired timing, which still
# measures every bench and is the only gate; see bench/README.md.
on:
push:
branches: [main]
paths:
- "rs/**"
- Cargo.toml
- Cargo.lock
- flake.nix
- flake.lock
- .github/workflows/codspeed.yml
schedule:
- cron: "0 7 * * *"
workflow_dispatch:

# A busy main queues one run behind the active one, so a burst of merges is
# measured as one comparison instead of piling up runs.
concurrency:
group: codspeed
cancel-in-progress: false

jobs:
codspeed:
name: CodSpeed
Expand Down
53 changes: 0 additions & 53 deletions .github/workflows/mutants.yml

This file was deleted.

10 changes: 5 additions & 5 deletions .github/workflows/quest.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: Quest

# Validates the quest tree on every branch that carries one. check.yml already
# runs `quest check` on ready main PRs and on release PRs, but a direct push (a
# merge to `main` or `release`, or `main` merged into a questline) is nobody's pull
# request, so a broken tree could land there unseen.
# Validates the quest tree on branches that take direct pushes. `main` lands only
# through the merge queue, whose `just ci` runs `quest check`, and check.yml runs
# it on release PRs, but a direct push (a merge to `release`, or `main` merged
# into a questline) is nobody's pull request, so a broken tree could land there
# unseen.
#
# Push only: a pull request is check.yml's job, and a pull_request trigger here
# would spawn a skipped Alert run on every push to every pull request.
Expand All @@ -17,7 +18,6 @@ permissions:
on:
push:
branches:
- main
- release
- "quest/**"
paths:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
# The matrix runs in real time (ffmpeg -re pacing + per-subscriber timeouts);
# this is just a safety net against a hung relay/client. The nix channel
# gets longer for a cold build when the pinned commit's closure misses
# nix.moq.dev (e.g. objects expired while Cache refresh was failing); compiling it
# nix.moq.dev (e.g. objects expired while Cache was failing); compiling it
# has taken 43 minutes.
timeout-minutes: ${{ matrix.channel == 'nix' && 75 || 45 }}

Expand Down Expand Up @@ -207,8 +207,8 @@ jobs:
# resolve a commit whose upload is still running (or was cancelled), and
# the relay and CLI could even resolve different commits.
# --print-build-logs is off, so a "building ...moq-relay" line here means
# a cache miss on a commit that was uploaded: the daily Cache refresh
# keeps that commit's closure inside the bucket's 30-day expiry
# a cache miss on a commit that was uploaded: each Cache run refreshes
# that commit's closure inside the bucket's 30-day expiry
# (infra/nix/lifecycle.json), so check its runs before calling it a cache bug.
# The repository root, where `just gh` resolves.
working-directory: .
Expand Down
4 changes: 2 additions & 2 deletions bench/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -982,8 +982,8 @@ sharing one can leave a bench linked against the other tree's library.

### CodSpeed

The CodSpeed workflow adds instruction counts for every `main` commit that
touches Rust, at <https://codspeed.io/moq-dev/moq>. Its CPU simulation runs
The CodSpeed workflow adds nightly instruction counts for `main`, at
<https://codspeed.io/moq-dev/moq>. Its CPU simulation runs
each bench under Valgrind on a hosted runner, so a change of a few percent
shows without the paired comparison's rounds. It does not see syscalls, I/O,
contention, or caches, and skips `iter_custom` benches, so `just rs codspeed`
Expand Down
2 changes: 0 additions & 2 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,6 @@
cargo-bloat
# The workspace-hack that gives every build one feature set per dependency.
cargo-hakari
# Weekly mutation testing of the security-critical modules (`just rs mutants`).
cargo-mutants
cargo-nextest
cargo-codspeed
# Sets versions for a release cut; `sh/version.py` needs 0.4.1 or newer.
Expand Down
7 changes: 3 additions & 4 deletions infra/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,9 @@ after upload. `nix copy` never re-uploads a path the bucket already has, so a
path many commits reuse keeps its first upload's age. Each job therefore
records the store paths it pushed under `roots/<commit>/`, then copies every
object in that commit's recorded closures that is over a week old onto itself,
restarting its age; it fails if any is already gone. The daily
`cache-refresh.yml` repeats that for the newest cached commit, the one Smoke
pins, so it always substitutes in full even when nothing merges;
older commits' paths still expire. `flake.nix` sets `fallback = true` because
restarting its age; it fails if any is already gone. The newest cached
commit, the one Smoke pins, therefore substitutes in full while `main` keeps
merging; older commits' paths still expire. `flake.nix` sets `fallback = true` because
that expiry can remove a path before one that depends on it.

The Worker logs R2 internal errors (10001) and service-unavailable errors
Expand Down
6 changes: 3 additions & 3 deletions infra/nix/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,16 @@ roots bucket rev name +paths:
set -euo pipefail
: "${AWS_ACCESS_KEY_ID:?not set}"
: "${AWS_SECRET_ACCESS_KEY:?not set}"
PATH="$(nix build --no-link --print-out-paths --inputs-from {{ quote(justfile_directory() / "../..") }} nixpkgs#rclone^out)/bin:$PATH"
PATH="$(nix build --no-link --print-out-paths --inputs-from {{ quote(source_directory() / "../..") }} nixpkgs#rclone^out)/bin:$PATH"
readlink -f {{ paths }} | rclone rcat "r2:{{ bucket }}/roots/{{ rev }}/{{ name }}"

# Restart the upload age of every object in a commit's recorded closures older than a week.
refresh bucket rev:
#!/usr/bin/env bash
# The bucket expires objects by upload age, and `nix copy` never rewrites
# one it already has, so a path every commit reuses keeps its first upload's
# age. Refreshed when published and then daily, the newest cached commit's
# closure stays well inside the 30-day expiry, even when nothing new is pushed.
# age. Refreshed when published, the newest cached commit's closure stays
# inside the 30-day expiry as long as `main` merges within that window.
set -euo pipefail
: "${AWS_ACCESS_KEY_ID:?not set}"
: "${AWS_SECRET_ACCESS_KEY:?not set}"
Expand Down
39 changes: 0 additions & 39 deletions quest/m0/ci/trim.md

This file was deleted.

Loading