Repository navigation
quest: the capture listing places each window on its display #8454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -8,6 +8,8 @@ show pictures instead of names, on macOS, Windows, and X11: | |||||||||||
| - **Apps:** every listed window names its app by an identity that is the same | ||||||||||||
| after the app restarts, and apps are listed with that identity, a name, and | ||||||||||||
| their icon as pixels. | ||||||||||||
| - **Placement:** every listed window says which listed display it is on and | ||||||||||||
| its rectangle there, in that display's pixels. | ||||||||||||
|
Comment on lines
+11
to
+12
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A window can straddle two monitors, and the goal gives no rule for which display it then reports; "its rectangle there" likewise needs a stated answer for the part hanging over the second display. The shield this bullet exists for paints on one display, and the decision's full-screen test compares against "its display's", so both depend on that rule. Naming it here keeps the outcome checkable.
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||||||||
| - **Cameras:** each says what kind of device it is (built in, webcam, capture | ||||||||||||
| card, phone, virtual) where the system says, and says nothing where it does | ||||||||||||
| not. | ||||||||||||
|
|
@@ -49,6 +51,15 @@ with the API. | |||||||||||
|
|
||||||||||||
| Settled in the interview: | ||||||||||||
|
|
||||||||||||
| - Window placement joins the listing (2026-11-10, maintainer, /quest-complete | ||||||||||||
| follow-up of [moq-dev/moq#8422](https://github.com/moq-dev/moq/pull/8422)): | ||||||||||||
| ✅ plan it (rejected: a full-screen flag, keeping an excluded app's sound | ||||||||||||
| out of system audio capture). The studio's privacy shield draws a lock | ||||||||||||
| where an excluded window was, and its camera that keeps out of the way | ||||||||||||
| avoids the foreground window; both need a window's position on its | ||||||||||||
| display. Full screen follows from a window's rectangle against its | ||||||||||||
| display's, so it gets no field of its own. | ||||||||||||
|
|
||||||||||||
| - Identity and icons cover every desktop, not macOS alone. | ||||||||||||
| - A supported path per desktop is decided at setup, with an error otherwise | ||||||||||||
| and never a silent fallback. | ||||||||||||
|
|
@@ -101,6 +112,11 @@ as given: | |||||||||||
| may refuse; listing alone opens no device. Measure what one picture stream | ||||||||||||
| costs per item at its default rate on each desktop, and state it on the | ||||||||||||
| API. | ||||||||||||
| - **Placement.** A window moving or resizing is a change like a retitle, so | ||||||||||||
| the watch's list stays current; coalesce a drag so it does not wake the | ||||||||||||
| caller per frame. X11 has `ConfigureNotify`, Windows `EVENT_OBJECT_LOCATIONCHANGE`, | ||||||||||||
| and macOS reports bounds in each listing, with the same caveat as the | ||||||||||||
| Waiting item for events. | ||||||||||||
|
Comment on lines
+115
to
+119
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Placement gets a Goal bullet and this recommendation, but no test in the Tests section, while every other Goal capability has one; the Xvfb window changes cover open, retitle, and close only, so a move that never wakes the watch would ship unnoticed. The Changes Goal bullet (lines 19-21) also still lists what wakes the watch without moves or resizes, which now reads as contradicting "a change like a retitle" here. Add a placement case to the Xvfb bullet (move and resize a window, assert the watch wakes with the new rectangle) and to the by-hand desktop lists, and include a move in the Changes list. |
||||||||||||
| - **Changes.** X11 has `PropertyNotify` on the root's client list and each | ||||||||||||
| window's title, and RandR for monitors, which `capture/x11.rs` already | ||||||||||||
| selects. Cameras have udev and PipeWire's registry on Linux, device | ||||||||||||
|
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 7869
Script executed:
Repository: moq-dev/moq
Length of output: 15569
Specify placement on every overlapping display.
When a window spans displays, the specified single association can leave the privacy shield and camera without its position on the other display. Require a rectangle for each overlapping display, or enough display topology to calculate it.
Suggested fix