Repository navigation
quest: plan a route per scope, and a prototype to settle distance against paths #8514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ccccfcb
quest: plan certifying claims by path, and a relay keeping its next h…
kixelated 1b960ba
quest: replan the route redesign as a route per scope
kixelated 16aba06
Merge remote-tracking branch 'origin/main' into quest-plan/route-certify
kixelated a0060f5
quest: the scope model keeps the lagging-neighbour case
kixelated 3e70b8d
quest: answer the review of the rewritten route plan
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # [M] The handoff sweep revives no ended claim | ||
|
|
||
| ## Goal | ||
|
|
||
| `sweep_handoff` in `rs/moq-net/src/route/tests/handoff.rs` reports no revival | ||
| over 20,000 scenarios: no reader sees one life of a claim start again after | ||
| it saw that life end, unless it forgot the claim in between. A publisher that | ||
| withdraws a claim and announces it again starts a new life, which is no | ||
| revival. The scenario that revives one today is a plain test. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found 2026-11-11 by running the sweep past its 150 scenarios: scenario 16316 | ||
| revives a claim, on `main` at `688312b9eb`, and no earlier one does. It is | ||
| the same whichever neighbours the router believes. It has not been traced. | ||
| Decided the same day (maintainer, /quest-plan): ✅ plan it. | ||
|
|
||
| - Reproduce it: the sweep draws every scenario from one random stream, so run | ||
| the first 16,317. Record the scenario's steps as it runs and remove them | ||
| one at a time while the revival remains, as | ||
| [the false END](/quest/m2/cluster-routing/routes/widen-false-end.md) was | ||
| shrunk. | ||
| - Decide whether it is a revival the contract forbids or one it excuses: a | ||
| replay after a collection or a restart is allowed only until the | ||
| withdrawal behind it lands | ||
| ([epic](/quest/m2/cluster-routing/routes/README.md), handoff contract). If | ||
| the fixture's `revivals` count misses an excuse, fix the count and say so. | ||
| - Otherwise fix the cause and keep the shrunk case as a test. | ||
| - If the cause is in what | ||
| [the route per scope](/quest/m2/cluster-routing/routes/scope.md) deletes, | ||
| pin it as a `residual_` test naming that quest instead of fixing it twice. | ||
|
|
||
| Public API: none. Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Widening an interest ends no live claim](/quest/m2/cluster-routing/routes/widen-false-end.md) - found the same way, and adds the way to run more scenarios |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.