Skip to content

quest: unblock the dart tag push, OSS-Fuzz application, and the nixpkgs review - #8517

Merged
kixelated merged 7 commits into
mainfrom
quest-unblock/2026-11-11
Nov 12, 2026
Merged

kixelated merged 7 commits into
mainfrom
quest-unblock/2026-11-11

Conversation

@kixelated

@kixelated kixelated commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

/quest-unblock on 2026-11-11: records the maintainer's answers and clears a wait whose condition resolved.

  • Finished: quest/m0/ffi-shutdown-backport.md waited on moq-dev/moq#8378 merging into release. It merged 2026-11-11 and moq-dart-v0.1.1 was pushed, but its release-dart.yml run failed: pub.dev's GitHub Actions publishing named the repository moq/moq-dev (owner and name swapped). With the maintainer's approval, the coordinator set it to moq-dev/moq in the maintainer's signed-in browser and reran the run, which published 0.1.1 (pub.dev lists it). The quest is deleted, and quest/m3/release/dart-publish.md records the fix.
  • Settled: quest/m4/oss-fuzz.md's maintainer item. The quest stays blocked only on quest/m1/session-fuzz.md (moq-dev/moq#8506, queued).
  • Advanced: quest/m2/cluster-routing/routes/playwright-pin.md still waits on nixpkgs, and now records how its review gets answered.

Decisions

  • OSS-Fuzz contact: ✅ security@moq.dev, from SECURITY.md (rejected: a personal address).
  • OSS-Fuzz application: ✅ the agent opens the google/oss-fuzz PR from the maintainer's account after the maintainer reviews the draft files and PR text (rejected: not yet). This accepts OSS-Fuzz's 90-day disclosure deadline.
  • NixOS/nixpkgs#585789 review: ✅ an agent drafts the fix on the kixelated/nixpkgs branch with an Assisted-by: trailer and a separate AI-disclosure line in the reply, as nixpkgs' policy requires for review comments, and the maintainer reviews the diff and reply before anything is pushed or posted (rejected: the maintainer answers it; leave it).

Checked and still waiting

  • cachix-retire, mbx-r2-verify (both date-gated: 2026-11-24 and 11-26), crates-trusted-publisher, demo-sockets-deploy, qmux-js-retire, qmux-rs-retire (all after the next cut).
  • rind 0.4.0 (crates.io has 0.3.2), instant-acme 0.9 (0.8.5), crossbeam Handle relays without announcement subscription support #1352 (open), cpal (0.18.2), bun lint (bun 1.4.4), Chrome 159 (stable is 157), Miri GenMC (cargo miri test still unsupported).
  • moq-tokio 0.19.36 (2026-11-11) is a patch backport, so runner-client-bump and interop-runner-approval still wait.
  • moq-dev/rust2's exporter epic and moq-dev/studio's watch quest are still open.
  • Scheduled Interop and Nightly runs on main are red every day; nightly/macos.md's websocket test passed nightly since 11-06 and needs the week to finish (about 11-13); hakari's benchmark-tests job was cancelled again on 11-10 and 11-11.

Impact

Public API: none. Wire: none. Quest text only.

Validation

quest check --base origin/main passes. just check was killed after 80 minutes in test gh: python3 sh/rs/test-lints.test.py hangs after its first test, and timeout 300 python3 sh/rs/test-lints.test.py hangs the same way on origin/main (f190d90), so this hang was already on main and this PR did not cause it.

Follow-ups

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, low effort (iterate, XS)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, low effort
  • Session: 01a1ccf0-3274-7111-9004-cb34af76eca0, round 1
  • Head: eedcc3a
  • Base: origin/main at b1ed1ba
  • Score: 10/10, The scoped diff changes only quest documentation and records maintainer decisions, with no actionable defects or blocking documentation issues.
  • Findings: none

(Written by Claude Opus 5.5)

…gs review

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated and others added 2 commits November 11, 2026 15:06
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 11, 2026 23:07
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request updates quest documentation. It adds notes about a test stall, records the Dart 0.1.1 publication, changes review-fix preparation instructions, and records OSS-Fuzz application decisions. It also removes an earlier Dart release-planning document.

Merge Risk: Minimal · up to ff3ab

This PR updates quest documentation only and does not change runtime behavior, so it is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names three changes the PR makes: unblocking the Dart tag push, the OSS-Fuzz application, and the nixpkgs review. The changeset is quest documentation that records maintainer decisions for t…
Description check Passed The description is detailed and relevant. It explains the /quest-unblock run of 2026-11-11, the Dart release fix in quest/m0/ffi-shutdown-backport.md and quest/m3/release/dart-publish.md, the OSS-Fuzz…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names three changes the PR makes: unblocking the Dart tag push, the OSS-Fuzz application, and the nixpkgs review. The changeset is quest documentation that records maintainer decisions for those three items and deletes or updates the matching quest files, so the title relates to the main change. It is long (78 characters, 12 words) and lists several items, but it remains specific and readable.

Full details: Description check

Explanation

The description is detailed and relevant. It explains the /quest-unblock run of 2026-11-11, the Dart release fix in quest/m0/ffi-shutdown-backport.md and quest/m3/release/dart-publish.md, the OSS-Fuzz contact and application decisions in quest/m4/oss-fuzz.md, the nixpkgs review process in quest/m2/cluster-routing/routes/playwright-pin.md, and the validation results. It matches the changeset.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 476906ef-db91-41b0-8ae7-c680676cefc3
Commits

Reviewing files that changed from the base of the PR and between 792cec5 and ff3ab99.

Files selected for processing: 5

  • quest/m0/ffi-shutdown-backport.md
  • quest/m0/test-lints-hang.md
  • quest/m2/cluster-routing/routes/playwright-pin.md
  • quest/m3/release/dart-publish.md
  • quest/m4/oss-fuzz.md
Files with no reviewable changes: 1

  • quest/m0/ffi-shutdown-backport.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The Dart publish landed between this branch's first commit and its head: the moq-dart-v0.1.1 tag was pushed at 21:59Z and release-dart.yml failed to publish, yet quest/m0/ffi-shutdown-backport.md still records the tag push as the next step. One inline comment covers the line to fix.

Reviewed changes

/quest-unblock output for 2026-11-11: four quest-text files, no code, API, or wire change.

  • Dart wait cleared: quest/m0/ffi-shutdown-backport.md drops the Waiting item on #8378 (verified merged 2026-11-11T10:08:11Z into release) and notes the tag push is ready.
  • Test-hang follow-up added: quest/m0/test-lints-hang.md is a new [XS] m0 quest for sh/rs/test-lints.test.py stalling after its first test. Both claims check out: just check does reach it through test:gh) run just gh test in sh/dispatch.sh, and the script is in .github/justfile's test recipe.
  • Nixpkgs decision recorded: quest/m2/cluster-routing/routes/playwright-pin.md now says an agent drafts NixOS/nixpkgs#585789's review fixes with an Assisted-by: trailer, vetted by the maintainer before anything is pushed or posted.
  • OSS-Fuzz wait settled: quest/m4/oss-fuzz.md replaces the maintainer item with the 2026-11-11 decision; security@moq.dev matches SECURITY.md:6.

ℹ️ The PR body's remaining OSS-Fuzz blocker is stale

The Description says the quest "stays blocked only on quest/m1/session-fuzz.md (#8506, queued)", but that path does not exist on main or on this head — the session targets the quest means live in rs/moq-net/fuzz/fuzz_targets/session_lite.rs and session_ietf.rs, and no quest file tracks them. #8506 also merged 2026-11-11T20:05:26Z, nearly three hours before this PR's head commit, so "queued" no longer holds either.

Technical details
# PR body cites a quest path and a PR state that no longer hold

## Affected sites
- PR Description, "Settled" bullet — names `quest/m1/session-fuzz.md`; `git ls-tree -r origin/main quest/m1/` has no such file, and neither does the head tree.
- Same bullet — says #8506 is "queued"; `gh pr view 8506` reports merged 2026-11-11T20:05:26Z.

## Required outcome
- The description names where the whole-session fuzz work is actually tracked (or says it landed) instead of a nonexistent quest path, so the next unblock run does not follow a dead link.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Comment thread quest/m0/ffi-shutdown-backport.md Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one factual nit inline.

Reviewed changes

Re-reviewed the two commits since the prior pullfrog review (1df96ef..26b777a), which turn the earlier findings into records of what actually happened.

  • Dart publish outcome recorded: quest/m0/ffi-shutdown-backport.md now records that moq-dart-v0.1.1 was pushed on #8378's merge and release-dart.yml published nothing, and its Waiting item became the maintainer enabling pub.dev automated publishing — addressing the prior inline finding.
  • Trusted-publishing question answered: quest/m3/release/dart-publish.md's "Confirm trusted publishing" step became "Configure trusted publishing", citing the moq-dart-v0.1.1 tag as the evidence it is not enabled for moq-dev/moq.
  • Nixpkgs reply disclosure widened: quest/m2/cluster-routing/routes/playwright-pin.md's decision now requires a separate AI-disclosure line in the posted reply alongside the Assisted-by: commit trailer — addressing the prior inline finding.
  • Hang diagnosis recorded: quest/m0/test-lints-hang.md narrows the title to a busy host and blames the fail-fast test's ungated just rs test calls, which reach sh/local.sh → quest gate. I checked the mechanism end to end: just rs test runs sh/rs/nextest.sh, which execs sh/local.sh, and without LOCAL_SUPERVISED=1 that ends in sh/quest.sh gate; test_clippy_warning_fails_test_build sets it and the fail-fast test does not. just check reaches the script through test:gh) run just gh test, which runs python3 sh/rs/test-lints.test.py directly, so nothing upstream supplies the variable either.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Comment thread quest/m0/test-lints-hang.md Resolved

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No new commits since the last review — one carried-over factual nit still stands inline.

Reviewed changes

No commits landed since the prior Pullfrog review at 26b777a (git log 26b777a..HEAD is empty), so this run re-checked the five quest files at head and the single finding still open against them rather than a new delta.

  • Dart publish record: quest/m0/ffi-shutdown-backport.md still records the failed moq-dart-v0.1.1 publish (tag points at #8378's merge, pub.dev lists only 0.1.0) and waits on the maintainer enabling automated publishing.
  • Hang diagnosis: quest/m0/test-lints-hang.md still attributes the stall to test_fail_fast_environment_reaches_nextest running just rs test without LOCAL_SUPERVISED=1, which test_clippy_warning_fails_test_build does set (sh/rs/test-lints.test.py:113).
  • Nixpkgs reply disclosure: quest/m2/cluster-routing/routes/playwright-pin.md still requires both the Assisted-by: trailer and a separate AI-disclosure line in the posted reply.
  • OSS-Fuzz decision: quest/m4/oss-fuzz.md is unchanged at head; security@moq.dev matches SECURITY.md:6.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Comment thread quest/m0/test-lints-hang.md Resolved
…d-run count

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one stale sentence in a quest intro that the new record now contradicts.

Reviewed changes

Re-reviewed the single commit since the prior pullfrog review (26b777a..eedcc3a), which closes the Dart wait and corrects the gated-run count.

  • Dart publish completed: deleted quest/m0/ffi-shutdown-backport.md after verifying pub.dev now lists moq 0.1.1 (published 2026-11-11T23:26:03Z) and release-dart.yml run 43107848443 succeeded on its rerun; grep -rn ffi-shutdown-backport quest/ is clean and quest/m0/README.md indexes no children, so the deletion leaves no dangling links.
  • Trusted-publishing fix recorded: quest/m3/release/dart-publish.md replaces the "Configure trusted publishing" step with the swapped moq/moq-dev repository field, the corrected moq-dev/moq config, and the successful rerun. The recorded tag pattern, pub.dev environment, and push trigger all match .github/workflows/release-dart.yml.
  • Gated-run count corrected: quest/m0/test-lints-hang.md now says 20 runs (10 via just rs test, 10 via sh/rs/nextest.sh), matching the test's nine-case matrix plus --no-run per command. This closes the prior inline thread.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Comment thread quest/m3/release/dart-publish.md Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Re-reviewed the single commit since the prior pullfrog review (eedcc3a..ff3ab99), which fixes the one open finding.

  • Plan intro refreshed: quest/m3/release/dart-publish.md now says moq has both 0.1.0 and 0.1.1 on pub.dev, describes 0.1.1 as published by a tag-workflow rerun, and narrows the open question to whether a tag publishes unattended with no rerun. This matches the bullet below it, and gh run view 43107848443 still reports conclusion: success on tag moq-dart-v0.1.1 via push.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit ac73d9e Nov 12, 2026
5 checks passed
@kixelated
kixelated deleted the quest-unblock/2026-11-11 branch November 12, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant