Repository navigation
fix(mux): back-to-back push-to-talk presses keep their latency #8589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6090747
chore(quest): claim quest/m1/push-to-talk-resume-latency.md
kixelated ad6da04
fix(mux): back-to-back segments continue the old schedule
kixelated a762c46
fix(mux): resume one delay before the tail ends so the sink plays it …
kixelated 8451d59
fix(mux): a continuing segment starts one tick past a durationless tail
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wake the paired resume from the selected origin delay.
poll_readysleeps untiltail - lead, andleadis this resume's own delay. Lines 626–627 can select a different delay from the paired origin. When the origin's delay is longer, this role wakes later than the origin needs.For example, the tail ends at 1000 ms. This role uses an 80 ms delay, and the origin uses 200 ms. This role wakes at 920 ms. The shared mapping starts at the tail end, but the origin's caller computes its lead from 200 ms. That caller then receives the mapping with only 80 ms of lead, so its sink can start late or underrun.
Use the paired origin's delay for the wake deadline. Select it with the same origin logic as lines 600–617, before
leadis computed. Keep the cached-mapping check and the non-paired fallback unchanged. The timer deadline is fixed when it is created, so recheck the origin if a member can change it during the sleep.