Skip to content

quest: re-check gpu-video 0.5 for the Vulkan encoder - #8714

Merged
moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/gpu-video-05
Nov 14, 2026
Merged

moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/gpu-video-05

Conversation

@kixelated

@kixelated kixelated commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

gpu-video 0.5.0 (Smelter blog) moved to wgpu 30, added a wgpu-based device setup, and keeps several encodes in flight. The Vulkan encode quest rejected gpu-video against 0.4, so it needed a re-check before someone hand-rolls the encoder.

Approach

Recorded the re-check in the quest's Plan, verified against the 0.5.0 crate source:

  • Resolved: wgpu 30 and ash 0.38 now match moq-video. The wgpu-based setup gets VK_KHR_external_memory_fd from wgpu-hal.
  • Still missing: VK_KHR_external_semaphore_fd, since VideoDeviceDescriptor takes no extra extensions. There is also no live bitrate change: rate control is fixed at creation.
  • Borrow its throughput design as guidance: a few submits in flight, rotating input pictures, explicit ordering of consecutive encodes, and a completion thread woken by a semaphore the CPU signals.

Decisions

  • ✅ Note the re-check and keep the hand-rolled ash encoder (rejected: switch to gpu-video 0.5 with upstream patches; add a pipelined NVENC/VAAPI encode quest; no change). Why: the missing external semaphore and live bitrate would need two upstream patches plus raw submits on wgpu's queue. Separately, moq-dev/moq#8693 measured flat p99 lateness up to 4 NVDEC to NVENC ladders with the engines under 10% busy, so moq-video's one-frame-at-a-time encode isn't the bottleneck yet.

Impact

None: planning only.

Validation

quest check: 509 documents ok. Claims checked in gpu-video 0.5.0's source: src/backends/vulkan/vulkan_device.rs (fixed extension list), src/device.rs (VideoDeviceDescriptor, max_in_flight_submissions default 3), src/encoders.rs (no reconfigure API), and wgpu-hal 30.0.1 adapter.rs (external_memory_fd optional, no external semaphore).

Alternatives

See Decisions.

Follow-ups

None.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 2a11115

  • Base: origin/main at 6f2f3ff

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1d830-d53e-7c10-ac0c-41f3befc76f4, round 1

  • Score: 10/10, The documentation-only update adds Vulkan encoder dependency research and implementation guidance, changes no executable behavior, and has no actionable defects.

  • Rounds: 1; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 14, 2026 03:54
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3de98459-9513-43d9-b0e8-8efbe3c87d3e
Commits

Reviewing files that changed from the base of the PR and between 6f2f3ff and 2a11115.

Files selected for processing: 1

  • quest/m3/vulkan-encode.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 14, 2026 03:54

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the single commit, which only edits the quest plan.

  • gpu-video 0.5 re-check — records in quest/m3/vulkan-encode.md why the hand-rolled ash encoder stays: VK_KHR_external_semaphore_fd is missing and rate control can't change live.
  • Throughput guidance — notes the design worth borrowing: a few submits in flight, rotating input pictures, explicit encode ordering, and a semaphore-woken completion thread.

I didn't check the claims about gpu-video 0.5.0's source.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit d764223 Nov 14, 2026
7 checks passed
@moq-bot
moq-bot Bot deleted the quest-plan/gpu-video-05 branch November 14, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant