Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quest/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,6 @@ Critical fixes continue to reach the existing release through backports.

Test flakes join m0 without asking (decided 2026-11-05, maintainer): a test
that fails intermittently in CI, Nightly, or the merge queue becomes a child
of m0's [test flakes](/quest/m0/test-flakes-2/README.md) epic. Skills that plan
of m0's [test flakes](/quest/m0/test-flakes-3/README.md) epic, planned anew once it completes. Skills that plan
follow-ups plan a reported flake there without asking whether or where; the
planning PR's review is the check.
2 changes: 1 addition & 1 deletion quest/m0/ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ a tested chain of squash commits ([land](https://github.com/moq-dev/moq/blob/17a
2026-10-30 (maintainer): it runs as a daemon on the maintainer's host, not as
a workflow on the self-hosted runner. This supersedes concurrent queue
entries on a second runner. Batching gains most when failures are rare, so the
[flake epic](/quest/m0/test-flakes-2/README.md) moved to m0 and
flake epic moved to m0 and
`MIGRATE.md` Unreleased sections, a top source of conflicts, stop being
written per PR. The batched gate was superseded 2026-11-01, below.

Expand Down
2 changes: 1 addition & 1 deletion quest/m0/interop-green/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ port-reservation lines are negative self-tests in
`interop/relay-log.test.sh` and `lib/harness.test.sh` that pass.
Already owned: the intermittent media-matrix timestamp-gap cells
(`cpp -> js-native-node`, `go -> c`, browser `rust -> js` timeouts) belong to
[test flakes](/quest/m0/test-flakes-2/README.md). The fallback audio stall
a test flakes epic. The fallback audio stall
that hit on `moq-lite-07-wip` in
[41495461904](https://github.com/moq-dev/moq/actions/runs/41495461904) and
[41668668824](https://github.com/moq-dev/moq/actions/runs/41668668824) was a
Expand Down
2 changes: 1 addition & 1 deletion quest/m0/nightly/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ This README's own work, after the children:
[audio playout](/quest/m2/audio-playout/README.md), the
macOS `receive_credit` timeout has no owner since its quest was deleted in
[moq-dev/moq#6732](https://github.com/moq-dev/moq/pull/6732), so plan one under
[test flakes](/quest/m0/test-flakes-2/README.md) if it recurs, and the paired bench
a test flakes epic if it recurs, and the paired bench
threshold is calibrated in [Paired comparison](/bench/README.md#paired-comparison). The moq-net benchmark
fixtures were repaired in [moq-dev/moq#7940](https://github.com/moq-dev/moq/pull/7940).
The receive-windows benchmark's overcommitted cells, skipped since
Expand Down
301 changes: 0 additions & 301 deletions quest/m0/test-flakes-2/README.md

This file was deleted.

27 changes: 27 additions & 0 deletions quest/m0/test-flakes-3/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# [S] Quarantined tests hold up under load

## Goal

Tests that pass alone but fail under a loaded `just check`, or intermittently
in CI or interop, pass reliably, each fixed at its cause, never by raising a
timeout or adding a retry.

## Plan

Continues the finished test flakes epic (deleted by
[moq-dev/moq#8776](https://github.com/moq-dev/moq/pull/8776); see its history
for earlier rounds). Decided 2026-11-15 (maintainer): a new flake joins this
epic while it is open; once it completes, the next flake opens a fresh one.
One child per flake, grouping only those that share a fixture.

Rules every child keeps:

- Prefer a paused clock over wall time, or assert on an event instead of a
deadline. If a test is slow under load because the code under test is slow,
fix that.
- Where real sockets fight the paused clock, drive the timers with a
`kio::clock::Manual` clock or the sim, or move the test off real sockets.
- Where the code jitters its timers with `rand`, wait out the jitter's whole
window, not a count of small steps.

Public API: none. Wire: none.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ one, and `gap_in_group_sequence_recovery` stops flaking in the merge queue.

Found 2026-11-14 by the [feature review](/quest/m3/release/feature-review.md):
queue run 43557751216 failed `gap_in_group_sequence_recovery` ("Expected >= 4
frames, got 2", 0.386 s) on a quest-only PR the day after this epic's three
frames, got 2", 0.386 s) on a quest-only PR the day after the finished flakes epic's three
loaded runs passed. It is a plain `#[tokio::test]` with a 100 ms max delay,
like most of the file's 115 tests, about 40 of which set a millisecond
`with_max`. `KIO_DENY_HOST_TIMERS` catches timers fired on the host clock, not
Expand Down