Repository navigation
fix(carla): the bridge's tests leave no lock files - #8813
Merged
Merged
Conversation
Quest-Claim: b6305cc0a4268969
Each test puts its socket in a tempfile directory it owns, so the `.sock.lock` file `Bridge::listen` takes goes with it. `Bridge` is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 15, 2026 11:28
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
enabled auto-merge
November 15, 2026 11:29
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the full diff. The tests now keep their sockets in their own temp directories.
- Test sockets in owned tempdirs:
src/lib.rs,src/server.rsandtests/gpu.rsbindbridge.sockinside atempfile::tempdir(). Eachdiris declared before itsBridge, so the bridge drops first and the directory removal takes the.sock.lockfile with it. tempfiledev-dependency: added under the Linux target dev-dependencies, soBridge::listenand the production lock file are unchanged.- Quest file removed: the quest doc is deleted.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Running the carla bridge's tests no longer leaves a
carla-bridge-*.sock.lockfile or socket in TMPDIR. Each test (src/lib.rs,src/server.rs,tests/gpu.rs) now puts its socket in atempfile::tempdir()it owns, which removes the lock file with it.Bridge::listenis unchanged: the lock file must stay in production, since unlinking a lock another process may be opening lets two bridges lock different inodes. Addstempfileas a Linux dev-dependency of the demo's own workspace (already3in the root workspace). Deletes the quest.Public API: none. Wire: none.
Caused by
Decisions
Taken without asking (user AFK):
tempfiledev-dependency rather than a hand-rolled directory with a drop guard, per the quest's recommendation.bridge.sock) in every test's own directory, since the directory is now unique, instead of per-test names with the pid.Validation
cargo test --libindemo/carla/bridgewith a fresh emptyTMPDIR: 16 passed, and the directory is empty afterwards.cargo clippy --all-targets -D warningsandcargo fmt --checkpass.tests/gpu.rs(ignored, needs an NVIDIA GPU) compiles under clippy but was not run here.Follow-ups
None.
Models
Size: XS
Implementer: Claude Code, claude-sonnet-5-5, default effort (arm A)
Review
Rewritten by
quest reviewafter each round.Head: 1197455
Base: origin/main at 31d389d
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1def6-f1aa-7e33-b835-a5a4b5540ed9, round 1Score: 10/10,
Each affected test owns a temporary directory that outlives its bridge, cleaning up sockets and lock files without changing production locking; source review found no issues, though no builds or tests were run.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none