Skip to content

fix(carla): the bridge's tests leave no lock files - #8813

Merged
moq-bot[bot] merged 2 commits into
mainfrom
quest/m1/carla-bridge-test-locks
Nov 15, 2026
Merged

moq-bot[bot] merged 2 commits into
mainfrom
quest/m1/carla-bridge-test-locks

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Running the carla bridge's tests no longer leaves a carla-bridge-*.sock.lock file or socket in TMPDIR. Each test (src/lib.rs, src/server.rs, tests/gpu.rs) now puts its socket in a tempfile::tempdir() it owns, which removes the lock file with it. Bridge::listen is unchanged: the lock file must stay in production, since unlinking a lock another process may be opening lets two bridges lock different inodes. Adds tempfile as a Linux dev-dependency of the demo's own workspace (already 3 in the root workspace). Deletes the quest.

Public API: none. Wire: none.

Caused by

  • moq-dev/moq#5621 - added the lock and tests that name sockets in the shared TMPDIR without cleaning up (found by person)

Decisions

Taken without asking (user AFK):

  • tempfile dev-dependency rather than a hand-rolled directory with a drop guard, per the quest's recommendation.
  • One socket name (bridge.sock) in every test's own directory, since the directory is now unique, instead of per-test names with the pid.

Validation

cargo test --lib in demo/carla/bridge with a fresh empty TMPDIR: 16 passed, and the directory is empty afterwards. cargo clippy --all-targets -D warnings and cargo fmt --check pass. tests/gpu.rs (ignored, needs an NVIDIA GPU) compiles under clippy but was not run here.

Follow-ups

None.

Models

Size: XS
Implementer: Claude Code, claude-sonnet-5-5, default effort (arm A)

Review

Rewritten by quest review after each round.

  • Head: 1197455

  • Base: origin/main at 31d389d

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1def6-f1aa-7e33-b835-a5a4b5540ed9, round 1

  • Score: 10/10, Each affected test owns a temporary directory that outlives its bridge, cleaning up sockets and lock files without changing production locking; source review found no issues, though no builds or tests were run.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 15, 2026 03:25
Each test puts its socket in a tempfile directory it owns, so the
`.sock.lock` file `Bridge::listen` takes goes with it. `Bridge` is unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title The carla bridge's tests leave no lock files fix(carla): the bridge's tests leave no lock files Nov 15, 2026
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 11:28
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9958d9de-76a4-4889-abd6-491839a208e7
Commits

Reviewing files that changed from the base of the PR and between 23b8ba4 and 1197455.

Files ignored due to path filters: 1

  • demo/carla/bridge/Cargo.lock is excluded by !**/*.lock
Files selected for processing: 5

  • demo/carla/bridge/Cargo.toml
  • demo/carla/bridge/src/lib.rs
  • demo/carla/bridge/src/server.rs
  • demo/carla/bridge/tests/gpu.rs
  • quest/m1/carla-bridge-test-locks.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 15, 2026 11:29

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the full diff. The tests now keep their sockets in their own temp directories.

  • Test sockets in owned tempdirs: src/lib.rs, src/server.rs and tests/gpu.rs bind bridge.sock inside a tempfile::tempdir(). Each dir is declared before its Bridge, so the bridge drops first and the directory removal takes the .sock.lock file with it.
  • tempfile dev-dependency: added under the Linux target dev-dependencies, so Bridge::listen and the production lock file are unchanged.
  • Quest file removed: the quest doc is deleted.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit 42c7880 Nov 15, 2026
10 checks passed
@moq-bot
moq-bot Bot deleted the quest/m1/carla-bridge-test-locks branch November 15, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant