Skip to content

quest: plan groups whose frames present before the next group starts - #8883

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/groups-never-overlap
Nov 15, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/groups-never-overlap

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Plans quest/m3/groups-never-overlap.md: a group's frames always present before the next group's start, so a reader can bound a group's end from its own frames.

Today, a TS content join (#3798) publishes an IDR below the previous group's last frame. #4543 allowed this when it removed timestamp shifting. That overlap is why #8874's early HLS placement can, in a rare case, list one segment differently across edges.

The new quest joins m3 beside #8874's quest, since it removes the edge case that quest documents. Size M: a survey of the importers, then a producer rule change, the draft's wording, and tests.

Decisions

Recorded in the quest's Plan (maintainer, 2026-11-15):

  • ✅ Enforce the rule end to end (rejected: investigate only; end the import at an overlapping keyframe).
  • ✅ An overlapping keyframe continues the open group (rejected: shift the broadcast forward; leave it to the implementer).
  • ✅ Readers assume the rule and don't detect it (rejected: container::Consumer refusing it).

Models

Size: S
Implementer: Claude Code, claude-opus-5-5

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: dd18321

  • Base: origin/main at 6ac78b6

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e14d-40a3-74d3-809f-3e2b11114bca, round 1

  • Score: 10/10, The change adds a quest plan and a related-plan link without changing executable behavior, and no actionable defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 22:23

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the full diff of this quest plan PR (docs only, no executable behavior).

  • New quest quest/m3/groups-never-overlap.md: plans the rule that a group's frames present before the next group's start, with the decisions recorded and tests named.
  • Cross-link in quest/m3/fmp4-group-start-tfdt.md: adds a Related entry noting that continuing a group on an overlapping or repeating keyframe may remove some of that quest's cases.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 15, 2026
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request adds a proposal that frames in a group present before the next group starts. It describes planned changes for the draft, producer, and importers, along with decisions, expected tests, and reader assumptions. A related fMP4 proposal gains a link to this proposal and a note about overlapping or repeating keyframes.

Merge Risk: Minimal · up to dd183

This change only adds planning documentation and a cross-link and does not alter runtime behavior, so no merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: a quest plan for groups whose frames present before the next group starts. The changeset adds quest/m3/groups-never-overlap.md, which proposes that rule, and a related…
Description check Passed The description states that it plans the groups-never-overlap quest. It explains the motivation (a TS content join publishing an IDR below the previous group's last frame, and the related HLS placemen…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: a quest plan for groups whose frames present before the next group starts. The changeset adds quest/m3/groups-never-overlap.md, which proposes that rule, and a related-plan link in quest/m3/fmp4-group-start-tfdt.md. The title is specific and matches the changeset.

Full details: Description check

Explanation

The description states that it plans the groups-never-overlap quest. It explains the motivation (a TS content join publishing an IDR below the previous group's last frame, and the related HLS placement edge case) and lists the decisions and size estimate. It matches the changeset, which adds the planning document and a related link.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ea61ea05-3f02-4718-ae08-c182505887d5
Commits

Reviewing files that changed from the base of the PR and between 6ac78b6 and dd18321.

Files selected for processing: 2

  • quest/m3/fmp4-group-start-tfdt.md
  • quest/m3/groups-never-overlap.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

Merged via the queue into main with commit d537f5a Nov 15, 2026
7 checks passed
@kixelated
kixelated deleted the quest-plan/groups-never-overlap branch November 15, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant