Skip to content

docs(quic): the BBR3 ledger names its reference commits and every deliberate divergence - #8899

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/bbr3-references/README
Nov 16, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/bbr3-references/README

Conversation

@kixelated

@kixelated kixelated commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes the BBR3 references epic: its children (#8805, #8806, #8807, #8809, #8810, #8848) have merged, so what was left was its own Goal, the ledger in rs/moq-quic/README.md.

Summary

  • Verified each epic item against the code before writing: the idle-aggregation, growth, loss-order, ProbeRTT (10 s schedule, save order, skip with spurious-loss undo, lowest-sample adoption), Drain-signals and Reno-floor, and Startup per-packet loss fixes are all present, each with a test in rs/moq-congestion/src/bbr3/mod.rs or rs/moq-quic/src/tests; Lost::new_burst is gone. Nothing in the Plan was left undone.
  • Spot-checked the controller against draft-07's pseudocode (5.3.1.2 to 5.3.4.4, 5.4.1, 5.5.10 to 5.5.11, 5.6.3). It matches except for the divergences now listed.
  • rs/moq-quic/README.md: a new BBR3 references entry names draft-07, Linux BBRv3 90210de4, and QUICHE BBR3 51a950db, rechecked today (the Linux v3 head and QUICHE's congestion_control are unchanged, draft-07 is still the newest), and lists every deliberate divergence. The loss-samples entry now cites draft-07.
  • quest/m3/vendor-sync/quinn.md points at the ledger entry for the reference heads instead of the finished epic.
  • Deleted the epic's README. One comment in maybe_go_down records that the precautionary stop reads inflight with the ACK's bytes counted, as Linux's prior_in_flight, a divergence found while writing the ledger.

Decisions

  • Recorded as a divergence, left unchanged: the precautionary stop reads pre-ACK inflight (Linux), where draft-07's C.inflight is read after the ACK; and the Reno round bound is picked from 62 or 63 (draft-07's prose) rather than its pseudocode's 63. Recommendation: keep both, measurement-only.
  • The "not compared" differences (ProbeBW_UP/DOWN end, minimum loss events, initial window, receive-timestamp clamping, CE ratio) are listed in the ledger as unmeasured rather than as decisions, per the epic's out-of-scope.

Public API / wire

None. Docs and one comment.

Validation

Docs change; no behavior to exercise. cargo check and cargo fmt --check on moq-congestion pass, and quest check reports 539 documents ok. Reference heads checked through the GitHub API; draft-07 text read in full for the sections above.

Follow-ups

None.

Models

Size: S
Implementer: Claude, claude-sonnet-5-5, high effort (arm B)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 43171bc

  • Base: origin/main at 3860774

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e3ea-7ee7-7310-946c-e536edf2131b, round 1

  • Score: 10/10, The changes consolidate reference tracking through documentation and one explanatory comment without changing runtime behavior or introducing actionable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 16, 2026 02:29
…iberate divergence

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title BBR3 matches its references docs(quic): the BBR3 ledger names its reference commits and every deliberate divergence Nov 16, 2026
@kixelated
kixelated marked this pull request as ready for review November 16, 2026 10:33
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2e806217-749a-4e4a-b1ab-9aebe9e98b00
Commits

Reviewing files that changed from the base of the PR and between 1ca6136 and 43171bc.

Files selected for processing: 4

  • quest/m1/bbr3-references/README.md
  • quest/m3/vendor-sync/quinn.md
  • rs/moq-congestion/src/bbr3/mod.rs
  • rs/moq-quic/README.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — docs-only PR plus one code comment, read in full.

  • BBR3 references ledger: rs/moq-quic/README.md adds a BBR3 references entry naming draft-07, Linux 90210de4 and QUICHE 51a950db, and lists the deliberate divergences. The loss-samples entry now cites draft-07.
  • Vendor-sync pointer: quest/m3/vendor-sync/quinn.md points at the ledger instead of the finished epic.
  • Epic removal: quest/m1/bbr3-references/README.md is deleted. Its stated goal and plan items are covered by the new ledger entry, and no references to it remain in the checkout.
  • Comment: maybe_go_down in rs/moq-congestion/src/bbr3/mod.rs notes that the ACK's bytes still count as in flight, as Linux's prior_in_flight does. The code is unchanged.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 16, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 43171bc0caeec8f969ed813036404e11953ac84b.

No actionable defect found in this documentation-focused static review.

Read all four changed files and spot-checked the ledger against the controller implementation: application-limited bandwidth aging and plateau handling, ProbeRTT skip/lowest-sample adoption and interrupted-probe aging, recovery snapshots, Drain reset, Reno round bounds/floors, and the pre-ACK precautionary-stop calculation. Located corresponding regression tests, including idle gaps, per-packet loss counts, ProbeRTT skip/undo, Drain signals and small-BDP Reno timing. The source change is only a comment; no behavior changes.

Also read the pinned Linux tcp_bbr.c and verified its any-ACK growth reset, empty-window bandwidth-filter retention, inflight target, and precautionary stop using prior_in_flight. The current v3 copy of that file is byte-for-byte identical to the pinned copy. The pinned QUICHE source is accessible. The ledger preserves the distinction between intentional departures and unmeasured comparison questions, and the vendor-sync instructions now point to the retained ledger rather than the deleted epic.

Limits: GitHub-only inspection, not a complete independent draft-07 conformance audit or verification of every upstream branch/directory head. No builds, simulations, benchmark runs, or tests executed. Test presence is not a claim that every listed regression runs through the seeded network-simulation path. COMMENT only, not approval.

Merged via the queue into main with commit b4515c7 Nov 16, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m1/bbr3-references/README branch November 16, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant