Repository navigation
The relay drops its 0.14 upgrade leftovers - #8919
Conversation
Quest-Claim: ee6e4b85e4f5bb4d
Remove the ten hidden `--auth-*` flags with their MOQ_AUTH_* variables, the six hidden `[auth]` keys, and the guard that refused a wildcard-free public or mTLS pattern, in the relay and in `moq auth serve`. `anon` now names the broadcast `anon`. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This review covers the removal of the relay's 0.14 upgrade guards and the matching cleanup in moq auth serve.
Legacyand hidden[auth]keys removed. The ten hidden--auth-*flags, theirMOQ_AUTH_*variables, and the sixIgnoredAnykeys are gone.[auth]is stilldeny_unknown_fields, and unknownMOQ_*variables still stop startup, so a leftover setting still fails. The only difference is the generic error message.auth::Config::deprecateddropped. Both callers are removed:rs/moq-relay/src/config.rsandrs/moq-cli/src/args.rs. The[server],[client], and--server-quic-lb-*refusals stay as they were.- Wildcard-free pattern guard removed. The guard is gone from the relay's
validateand fromServe::policy, and both now accept a literal pattern. The new relay test checks thatanonadmits/anonand/, and refuses/anon/room,/anonymous, and/other. - Docs.
doc/bin/relay/auth.mdnow says a wildcard-free pattern names one broadcast. The 0.14 migration table is kept.
claude-opus-5-5 | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 29f5871dcadc560844ba7482f124ab13ffb4bab3.
No functional blocker found. A wildcard-free rule authorizes exactly one broadcast, not its descendants; unrelated auth-source validation remains. The removed 0.14 TOML keys, flags and environment variables still fail closed as unknown input.
One cut note: “Public API: none” understates this change. moq_relay::auth::Config::deprecated() is a public method on the release branch. Even if every known caller is in-tree, list its removal for library embedders. Also replace the old warning that literal patterns fail startup.
Static review only; I did not run the CLI, test suite, or Nix evaluation. COMMENT only, not approval.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Since the last review, the branch merged main and updated one test to match main's new types.
- The literal-pattern test now compares
Access.mainchanged tokenpublish/subscribefromPatternstomoq_auth::Access. The assertions ina_literal_public_pattern_admits_exactly_that_broadcastnow compare againstpatterns(..).into(), which usesFrom<Patterns> for Access. What the test checks is unchanged. - Resolved the merge in
quest/m2/README.md. The Relay bullet now takesmain's rewrite and still drops this quest's link.
claude-opus-5-5 | 𝕏
|
quest land watch: the merge queue removed this pull request at c26e361 because it conflicts with The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs. (written by quest land watch) |
|
quest land watch: armed auto-merge on this pull request at 7bde684, so it joins the back of the merge queue once its required checks pass, with the land fixer's fix ( (written by quest land watch) |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Since the last review, the branch merged main again. Nothing else changed.
- Resolved the merge conflict in
quest/m2/README.md. The Relay bullet now takesmain's version, which no longer has the CPU link, and still leaves out this quest's link. It now reads "Congestion names and transport names". No code changed.
claude-opus-5-5 | 𝕏

Completes
quest/m2/relay-014-leftovers.md(deleted here).Summary
moq-relay: deleteLegacy(the ten hidden--auth-*flags andMOQ_AUTH_*variables), the six hidden[auth]keys,Config::deprecatedfor auth, and the wildcard-free-pattern guard inauth::Config::validate.moq auth serve: delete the same guard inServe::policy.moq(args.rs) no longer asks the auth config for deprecations.doc/bin/relay/auth.md: a wildcard-free pattern names one broadcast;anon/**is the subtree.moq auth serveacceptance test, and tests that an old[auth]key,--auth-key, andMOQ_AUTH_KEYare unknown like any other.release([client],[server.quic],--server-quic-lb-*, and the rest ofdeprecated), so the newest and previous release still interoperate as relays and the upgrade this cut asks for stays protected.quest/m2/README.md.Impact
Public API: none (
Legacywas crate-private;auth::Config::deprecatedwaspubbut only the relay andmoqcalled it). Wire: none.Migration note for moq-relay (for the release cut's
MIGRATE.md): the tailored refusals for 0.14 settings are gone.--auth-key,--auth-key-dir,--auth-api,--auth-public-api,--auth-domain,--auth-mtls-tier,--auth-tls-*, theirMOQ_AUTH_*variables, and the[auth]keyskey,key_dir,auth_api,domains,mtls_tier,tlsare now unknown flags, variables, and keys, and stop startup with the generic message. A public or mTLS pattern without a wildcard is accepted with its literal meaning:anonis the broadcastanon,anon/**the subtree. The 0.14 mapping stays indoc/bin/relay/auth.md.Validation
just checkpasses (780 Rust tests).moq-relay --listen 127.0.0.1:0 --listen-tls-generate localhost --auth-public anonstarts and serves; adding--auth-key kfails withunexpected argument '--auth-key';MOQ_AUTH_KEY=k moq-relay --auth-public anonfails withunknown environment variable under 'MOQ_': MOQ_AUTH_KEY.MOQ_AUTH_KEYis harmless: it is stricter than harmless. UnknownMOQ_*variables already stop startup (feat(cli)!: refuse MOQ_* environment variables a binary does not read #6633), so it still refuses, never booting with tokens ignored.Decisions
The maintainer confirmed these decisions on 2026-11-16 (/quest-run); each is reviewable and undoable.
rs/moq-relay/MIGRATE.md:sh/migrate.shrejects any edit outside the release cut, so the note is above. Its older "Grants are patterns" sentence (a wildcard-free pattern refuses to start) is now stale; the cut should drop it.!: it removes parsing of settings 0.17 already refused, and it loosens a refusal, so no working deployment breaks.gh pr list). Their edits toquest/m2/README.mdmay need a trivial merge.Models
Size: S
Implementer: claude-sonnet-5-5, high effort (arm B)
Review
mechanical fix by codex, gpt-6.1-sol, medium effort:
Merged base and re·solved quest/m2/README.md conflict preserving both completed-item removals; passed nix develop --no-write-lock-file --command just ci base and git diff --check.(head 7bde684)Rewritten by
quest reviewafter each round.Head: c26e361
Base: origin/main at 401230e
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1e489-0e66-7ed2-a1e7-c086fcae621b, round 2Score: 9/10,
The incremental change correctly adapts the literal-grant assertions to Access, with no actionable regressions found; builds and tests were intentionally not run.Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none