Skip to content

The relay drops its 0.14 upgrade leftovers - #8919

Merged
moq-bot[bot] merged 5 commits into
mainfrom
quest/m2/relay-014-leftovers
Nov 17, 2026
Merged

moq-bot[bot] merged 5 commits into
mainfrom
quest/m2/relay-014-leftovers

Conversation

@kixelated

@kixelated kixelated commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Completes quest/m2/relay-014-leftovers.md (deleted here).

Summary

  • moq-relay: delete Legacy (the ten hidden --auth-* flags and MOQ_AUTH_* variables), the six hidden [auth] keys, Config::deprecated for auth, and the wildcard-free-pattern guard in auth::Config::validate.
  • moq auth serve: delete the same guard in Serve::policy.
  • moq (args.rs) no longer asks the auth config for deprecations.
  • doc/bin/relay/auth.md: a wildcard-free pattern names one broadcast; anon/** is the subtree.
  • Tests: removed the ones pinning the leftovers; added a literal public pattern admitting exactly that broadcast (and nothing beneath it), a moq auth serve acceptance test, and tests that an old [auth] key, --auth-key, and MOQ_AUTH_KEY are unknown like any other.
  • Kept the refusals for names removed since release ([client], [server.quic], --server-quic-lb-*, and the rest of deprecated), so the newest and previous release still interoperate as relays and the upgrade this cut asks for stays protected.
  • Removed this quest's link from quest/m2/README.md.

Impact

Public API: none (Legacy was crate-private; auth::Config::deprecated was pub but only the relay and moq called it). Wire: none.

Migration note for moq-relay (for the release cut's MIGRATE.md): the tailored refusals for 0.14 settings are gone. --auth-key, --auth-key-dir, --auth-api, --auth-public-api, --auth-domain, --auth-mtls-tier, --auth-tls-*, their MOQ_AUTH_* variables, and the [auth] keys key, key_dir, auth_api, domains, mtls_tier, tls are now unknown flags, variables, and keys, and stop startup with the generic message. A public or mTLS pattern without a wildcard is accepted with its literal meaning: anon is the broadcast anon, anon/** the subtree. The 0.14 mapping stays in doc/bin/relay/auth.md.

Validation

  • just check passes (780 Rust tests).
  • Built binary: moq-relay --listen 127.0.0.1:0 --listen-tls-generate localhost --auth-public anon starts and serves; adding --auth-key k fails with unexpected argument '--auth-key'; MOQ_AUTH_KEY=k moq-relay --auth-public anon fails with unknown environment variable under 'MOQ_': MOQ_AUTH_KEY.
  • The quest's check that a leftover MOQ_AUTH_KEY is harmless: it is stricter than harmless. Unknown MOQ_* variables already stop startup (feat(cli)!: refuse MOQ_* environment variables a binary does not read #6633), so it still refuses, never booting with tokens ignored.

Decisions

The maintainer confirmed these decisions on 2026-11-16 (/quest-run); each is reviewable and undoable.

  • Did not edit rs/moq-relay/MIGRATE.md: sh/migrate.sh rejects any edit outside the release cut, so the note is above. Its older "Grants are patterns" sentence (a wildcard-free pattern refuses to start) is now stale; the cut should drop it.
  • Kept the title without !: it removes parsing of settings 0.17 already refused, and it loosens a refusal, so no working deployment breaks.
  • Left sibling quests relay-config-names and relay-connect-keys alone; no open PR touches the same files (checked gh pr list). Their edits to quest/m2/README.md may need a trivial merge.

Models

Size: S
Implementer: claude-sonnet-5-5, high effort (arm B)

Review

mechanical fix by codex, gpt-6.1-sol, medium effort: Merged base and re·solved quest/m2/README.md conflict preserving both completed-item removals; passed nix develop --no-write-lock-file --command just ci base and git diff --check. (head 7bde684)

Rewritten by quest review after each round.

  • Head: c26e361

  • Base: origin/main at 401230e

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e489-0e66-7ed2-a1e7-c086fcae621b, round 2

  • Score: 9/10, The incremental change correctly adapts the literal-grant assertions to Access, with no actionable regressions found; builds and tests were intentionally not run.

  • Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 16, 2026 04:28
Remove the ten hidden `--auth-*` flags with their MOQ_AUTH_* variables, the six
hidden `[auth]` keys, and the guard that refused a wildcard-free public or mTLS
pattern, in the relay and in `moq auth serve`. `anon` now names the broadcast
`anon`.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 16, 2026 13:27
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fec00685-5aed-43ef-aac3-a5a0f3f724ad
Commits

Reviewing files that changed from the base of the PR and between cb227b2 and 7bde684.

Files selected for processing: 7

  • doc/bin/relay/auth.md
  • quest/m2/README.md
  • quest/m2/relay-014-leftovers.md
  • rs/moq-cli/src/args.rs
  • rs/moq-cli/src/auth.rs
  • rs/moq-relay/src/auth.rs
  • rs/moq-relay/src/config.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

pullfrog[bot]
pullfrog Bot previously approved these changes Nov 16, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This review covers the removal of the relay's 0.14 upgrade guards and the matching cleanup in moq auth serve.

  • Legacy and hidden [auth] keys removed. The ten hidden --auth-* flags, their MOQ_AUTH_* variables, and the six IgnoredAny keys are gone. [auth] is still deny_unknown_fields, and unknown MOQ_* variables still stop startup, so a leftover setting still fails. The only difference is the generic error message.
  • auth::Config::deprecated dropped. Both callers are removed: rs/moq-relay/src/config.rs and rs/moq-cli/src/args.rs. The [server], [client], and --server-quic-lb-* refusals stay as they were.
  • Wildcard-free pattern guard removed. The guard is gone from the relay's validate and from Serve::policy, and both now accept a literal pattern. The new relay test checks that anon admits /anon and /, and refuses /anon/room, /anonymous, and /other.
  • Docs. doc/bin/relay/auth.md now says a wildcard-free pattern names one broadcast. The 0.14 migration table is kept.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 29f5871dcadc560844ba7482f124ab13ffb4bab3.

No functional blocker found. A wildcard-free rule authorizes exactly one broadcast, not its descendants; unrelated auth-source validation remains. The removed 0.14 TOML keys, flags and environment variables still fail closed as unknown input.

One cut note: “Public API: none” understates this change. moq_relay::auth::Config::deprecated() is a public method on the release branch. Even if every known caller is in-tree, list its removal for library embedders. Also replace the old warning that literal patterns fail startup.

Static review only; I did not run the CLI, test suite, or Nix evaluation. COMMENT only, not approval.

pullfrog[bot]
pullfrog Bot previously approved these changes Nov 17, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Since the last review, the branch merged main and updated one test to match main's new types.

  • The literal-pattern test now compares Access. main changed token publish/subscribe from Patterns to moq_auth::Access. The assertions in a_literal_public_pattern_admits_exactly_that_broadcast now compare against patterns(..).into(), which uses From<Patterns> for Access. What the test checks is unchanged.
  • Resolved the merge in quest/m2/README.md. The Relay bullet now takes main's rewrite and still drops this quest's link.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 17, 2026
@moq-bot

moq-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

quest land watch: the merge queue removed this pull request at c26e361 because it conflicts with main (merge_conflict).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

(written by quest land watch)

@moq-bot

moq-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

quest land watch: armed auto-merge on this pull request at 7bde684, so it joins the back of the merge queue once its required checks pass, with the land fixer's fix (codex, gpt-6.1-sol, medium effort): Merged base and re·solved quest/m2/README.md conflict preserving both completed-item removals; passed nix develop --no-write-lock-file --command just ci base and git diff --check..

(written by quest land watch)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Since the last review, the branch merged main again. Nothing else changed.

  • Resolved the merge conflict in quest/m2/README.md. The Relay bullet now takes main's version, which no longer has the CPU link, and still leaves out this quest's link. It now reads "Congestion names and transport names". No code changed.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 0051c3d Nov 17, 2026
8 checks passed
@moq-bot
moq-bot Bot deleted the quest/m2/relay-014-leftovers branch November 17, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant