Repository navigation
feat(hang): one rule refuses a mis-shaped catalog section #8920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
118dc94
chore(quest): claim quest/m2/hang04/shape.md
kixelated 9da2f49
feat(hang): one rule refuses a mis-shaped catalog section
kixelated aec4441
docs(hang): namespaced extension examples, rewrapped audio jitter, fu…
kixelated ea9db2e
Merge base and resolve catalog documentation conflicts
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align the nested-null rule with Rust decoding.
This rule also forbids
nullin optional entry fields. However, Rust accepts{"json":{"tracks":{"events":{"mode":"snapshot","schema":null}}}}:JsonConfig.schemabecomesNone, and its defaultEntry::checksucceeds. The root parser adds no check that rejects this value. (raw.githubusercontent.com)JavaScript rejects the same field through
z.optional(z.string()). Thus, the new rule does not match both implementations. Either enforce nested-null refusal in Rust or explicitly document the retained exceptions. Add this case to the shared parity fixtures. (raw.githubusercontent.com)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changing the draft here. The draft states the intended rule, and JS already follows it. Rust reading a
nulloptional field inside an entry (such asschema: null) as absent is a known gap, and this PR adds a follow-up for it:quest/m2/hang04/null.md(listed under Follow-ups in the PR body). That quest makes Rust refuse these values with one adapter rather than field by field, and adds the parity fixtures. Documenting the gap as an exception would write a Rust bug into the spec.(Written by Claude Opus 5.5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kixelated You’re right. I should not have suggested adding an exception to the draft for a Rust implementation gap. The draft states the intended rule, and
quest/m2/hang04/null.mdcovers the Rust change and parity fixtures.I’m not marking the finding as addressed, since the Rust change is deferred.
Learnings added
Learnings used
You are interacting with an AI system.