Skip to content

fix(moq-mux): the SI renewal bench times a renewal, not the first catalog advertise - #8970

Merged
kixelated merged 1 commit into
mainfrom
fix/ts-si-renewal-bench-steady-state
Nov 16, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/ts-si-renewal-bench-steady-state

Conversation

@kixelated

@kixelated kixelated commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Nightly run 43909101837 confirmed moq-mux/containers ts_si_renewal_pcr/* regressions of +24 to +341% between 505a86f and 13e593c. Bisecting the bench binaries points to moq-dev/moq#8829 (5b4c01b fast, 2c3eb75 slow).

The renewal itself did not get slower. Each timed iteration starts from a fresh importer whose setup sees each SI section only once. The importer advertises the SI tracks in the catalog on the section's next arrival, which is the timed renewal, and that first publish allocates the catalog track's deflate encoder. Before #8829, the mux-rate hold kept the catalog unpublished for the whole bench, so the publish never ran. Now it adds a constant ~33 µs to every sample.

Approach

SiImport::identities renews every section once in setup (a PCR, then the same sections again), so the advertise happens before timing. Counted with temporary prints: the timed tick and renewal now publish no catalog. The only remaining publish comes from the importer's drop, which is outside timing.

Validation

Patched bench built at each revision, run on one host (criterion, 1 s warmup, 2 s measurement), median of ts_si_renewal_pcr/<retained>/<touches>:

case 5b4c01b (before #8829) 2c3eb75 (#8829) 13e593c (main) main, unpatched bench
1/1 0.89 µs 1.66 µs 1.60 µs 39.4 µs
1/64 25.7 µs 26.4 µs 26.4 µs 60.4 µs
64/16 8.2 µs 9.6 µs 9.5 µs 47.3 µs
4096/64 34.4 µs 33.2 µs 33.9 µs 88.8 µs

What remains of #8829 is under 1.5 µs per PCR, and visible only in the 1-touch cases. I tried an extra PCR alone in setup first, and it changed nothing: the advertise waits for the section's next arrival, not the next PCR.

just check passes.

Impact

  • Public API: none. Wire: none. Bench only. The next Nightly's paired comparison reads these cases as faster against the old bench.

Alternatives

Follow-ups

None.

Caused by

  • moq-dev/moq#8829: dropped the mux-rate hold that had kept the bench's first catalog advertise out of every sample (found by check: Nightly's paired bench comparison).

Models

Size: XS
Implementer: Claude, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 60c2644

  • Base: origin/main at 13e593c

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e5b1-c1de-72e2-972b-049a51d60233, round 1

  • Score: 10/10, The additional untimed PCR interval and SI replay establish the advertised tracks before renewal is measured, matching the importer’s clock and catalog behavior with no identified defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

…alog advertise

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 16, 2026 18:50
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a884e599-1637-483b-a308-723b3038509a
Commits

Reviewing files that changed from the base of the PR and between 13e593c and 60c2644.

Files selected for processing: 1

  • rs/moq-mux/benches/containers.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI) · 60c264429c944267c646989dd91da382bab8f7ac

No blocker. The added PCR and SI replay are in iter_batched_ref setup, so the timed closure still measures one PCR interval plus the configured number of arrivals. The change is scoped to the renewal fixture; the pending and history fixtures are untouched. I'd land this and treat the first paired Nightly comparison against the old fixture as a baseline reset, not an importer speedup. The same-fixture figures are the useful comparison across #8829. Static review; I did not rerun the benchmark.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the single bench change in rs/moq-mux/benches/containers.rs.

  • Untimed catalog advertise: SiImport::identities now ticks a PCR and replays the same SI sections once in setup, so the one-time catalog publish happens before timing rather than in every sample.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 8b36bd7 Nov 16, 2026
7 checks passed
@kixelated
kixelated deleted the fix/ts-si-renewal-bench-steady-state branch November 16, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant