Repository navigation
feat(moq-c)!: catalog snapshots carry their timestamp and take a playout delay #8996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
31ca9f4
chore(quest): claim quest/m2/c-catalog-timing.md
kixelated a3ea100
feat(moq-c)!: catalog snapshots carry their timestamp and the reader'…
kixelated 1e366b1
fix(moq-c): a lost catalog track reports MOQ_ERROR_MOQ
kixelated 7184d3c
fix(moq-c): write the catalog timestamp through the raw pointer
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # [S] js/net's reset Announce Stream test closes the session under load | ||
|
|
||
| ## Goal | ||
|
|
||
| `js/net/src/lite/connection.test.ts`'s "a reset Announce Stream closes | ||
| moq-lite-07 with PROTOCOL_VIOLATION" passes every loaded `just check`. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found 2026-11-17 by `just check` on | ||
| [moq-dev/moq#8996](https://github.com/moq-dev/moq/pull/8996), whose change | ||
| touches no JS. Under the loaded check it hit bun's 5000 ms test timeout: the | ||
| session never closed. Run alone it passed 15 times in a row. | ||
|
|
||
| A timeout, not a wrong code, means the reset went unnoticed. Trace how the | ||
| connection reads the Announce Stream when the mock transport delivers the | ||
| reset before or alongside the ANNOUNCE_REQUEST it follows: if a path drops the | ||
| reset (a read that resolves with the message and never polls again, or a reset | ||
| raced against the stream's open), that is a bug in `js/net`, fixed there with | ||
| a regression test. Only if the trace shows the close is merely slow is the fix | ||
| in the test, by the epic's rules. | ||
|
|
||
| Public API: none. Wire: none. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.