Repository navigation
fix(moq-net): a failed copy never places a reader's time start #9127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4745d6a
chore(quest): claim quest/m0/test-flakes-3/track-replacement-bun.md
kixelated 9edbbca
fix(moq-net): a failed copy never places a reader's time start
kixelated 4b5461c
fix(moq-net): a failed copy places no time start on any path, in Rust…
kixelated 82f4564
fix(net): a range from the oldest group needs no copy to place it
kixelated 631a16a
fix(moq-net): a switch carries no failed copy's resolution to the new…
kixelated c87b6da
fix(net): a failed serving copy reports no start the reader never placed
kixelated 82409a5
fix(moq-net): a new copy's aggregate demand takes no failed copy's pl…
kixelated 242bb11
fix(net): a failed copy holding a group back still reports its failure
kixelated 4a53f28
fix(net): every failed copy holding a group back reports its failure
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # [M] A waiting time start reads its owed group, and a fill reaches subscriptions | ||
|
|
||
| ## Goal | ||
|
|
||
| A Rust reader whose time start is still waiting on the groups held never hands | ||
| out a later group ahead of the one the start resolves to, and a group a | ||
| publisher accepts from a fill is delivered on its live subscriptions the way | ||
| `@moq/net` delivers it, or the difference is documented as intended. | ||
|
|
||
| ## Plan | ||
|
|
||
| Both were seen while chasing the interop hang that | ||
| [moq-dev/moq#9127](https://github.com/moq-dev/moq/pull/9127) fixed, through a | ||
| lite-07 publisher, a relay, and two viewers, all in one simulated test: | ||
|
|
||
| - A viewer that fetched group 67, then subscribed from `Time(66)` before 66 | ||
| was written, read 67 from an `Ordered` reader at once, then reported 66 as an | ||
| `Old` gap once 66 landed, though its budget was unlimited. Its own copy held | ||
| 67 and placed nothing for the time, so the waiting span read from 66, and the | ||
| ordered read did not wait for the group the start would resolve to. | ||
| - With the fetch on the other viewer instead, the subscribing viewer got 66 and | ||
| never 67: neither the Rust publisher nor the relay served the fill-accepted | ||
| group on a subscription, while the `@moq/net` publisher serves one there | ||
| (the interop relay received 69 over its subscription in every passing run). | ||
|
|
||
| Start from a test in `rs/moq-net/tests/integration` with that topology | ||
| (`MockConnectOptions` on `moq-lite-07-wip`, the publisher's `Requests` serving | ||
| 67 only). Decide the second from the draft's Subscribe section: a fill below | ||
| the live edge is history, but one at or past it is the live feed. | ||
|
|
||
| Public API: none expected. Wire: none. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.