Skip to content

fix(moq-srt): the test target builds on its own - #9163

Merged
kixelated merged 5 commits into
mainfrom
quest/m0/test-flakes-3/srt-server-load
Nov 19, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m0/test-flakes-3/srt-server-load

Conversation

@kixelated

@kixelated kixelated commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

moq-srt's test target did not compile alone (cargo test -p moq-srt): ts::tests calls hang::Catalog::subscribe, which needs hang's async feature, and only workspace feature unification turned it on.

Four moq-srt server::tests also hit nextest's 60s timeout in a loaded just check (moq-dev/moq#9123). That cause is outside this repo: the host's global mbx config sets scheduler.tests = true, so each test waits for a host-wide permit inside mbx-test-runner, and nextest counts the wait toward the test's timeout. Per the maintainer's decision, that gets fixed in mbx or the dotfiles config, not here.

Approach

  • rs/moq-srt dev-depends on hang with async (path-only, as internal dev-dependencies are), and nix/Cargo.nix is regenerated.
  • No .mbx.toml: the checked-in opt-out from the earlier head is gone.
  • The quest stays open, rewritten to the remaining cause, with a ## Waiting item on the mbx/dotfiles fix and the one-core reproduction to check it.

Validation

  • Reproduced the timeouts on the earlier head: moq-srt's lib tests in a systemd scope capped at one CPU (CPUQuota=100%, 4 test threads, --stress-count 20, KIO_DENY_HOST_TIMERS=1) timed out 20 tests at 60s, including pure ones, each printing mbx: waiting for machine-wide scheduler capacity before starting this test; nextest counts this wait toward its slow-timeout. With MBX_SCHEDULER_TESTS=false the same run passed 20/20, slowest 3.36s. That reproduction is now the quest's check.
  • cargo test -p moq-srt --lib --no-run failed with E0599 on Catalog::subscribe before the dev-dependency and builds after it.
  • On this head: cargo test -p moq-srt passed 28/28, and just check passed.

Impact

  • Public API: none. Wire: none. Tooling: none (mbx test scheduling is unchanged).

Decisions

  • Maintainer, 2026-11-19: ✅ drop the .mbx.toml opt-out and land only the moq-srt dev-dependency fix (rejected: land the opt-out; raise nextest's terminate-after here). Host-wide test scheduling stays on; the queued-test timeout is fixed in mbx or the dotfiles config.
  • Taken while the maintainer was away, undoable in review: the rewritten quest is sized XS (on this repo's side it is only re-running the reproduction and deleting the quest), and its Waiting item suggests taking the permit before nextest starts the test's clock rather than turning test scheduling off.

Caused by

  • moq-dev/moq#8831 - added a ts::tests call to Catalog::subscribe without enabling hang's async feature in moq-srt's dev-dependencies (found by person).
  • The timeouts: no single PR here; they come from the host's mbx config, not this repo.

Follow-ups

None. The rewritten quest quest/m0/test-flakes-3/srt-server-load.md keeps the remaining work.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, medium effort
Implementer: Claude Code, claude-opus-5-5, medium effort (iterate, XS)

(Written by Claude Opus 5.5 with medium)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: f12bbdc

  • Base: origin/main at 83c9fdd

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f332-e643-7292-a01a-c118e901083e, round 2

  • Score: 9/10, No actionable defects were found in the incremental changes, which remove the scheduler opt-out and document the upstream follow-up; builds and tests were not run as instructed.

  • Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 19, 2026 00:43
…uild alone

nextest starts a test's timeout when it starts mbx's runner, so a test that
waits for a host-wide scheduler permit is killed before it runs. Disable mbx
test scheduling for this workspace; quest gate and nextest's thread count
already bound test load.

moq-srt's ts tests call `Catalog::subscribe`, which needs hang's `async`
feature, so enable it in the dev-dependencies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title moq-srt's server tests hold under load fix(test): tests never queue for an mbx permit, and moq-srt's tests build alone Nov 19, 2026
@kixelated
kixelated marked this pull request as ready for review November 19, 2026 09:46
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The moq-srt package and its generated Nix metadata add hang as an async-enabled development dependency. The quest now describes test timeouts while waiting for an mbx scheduler permit, specifies a one-core reproduction, and directs the fix to mbx or dotfiles while keeping host-wide test scheduling enabled.

Merge Risk: Minimal · up to f12bb

This change lets the moq-srt tests compile on their own by declaring the missing test dependency. It does not change runtime behavior, public APIs or the wire format. No actionable merge risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix(moq-srt): the test target builds on its own" matches the main change: adding hang's async feature as a moq-srt dev-dependency so the moq-srt test target compiles standalone. It is speci…
Description check Passed The description is closely related to the changeset. It explains the standalone compile failure in moq-srt's test target caused by hang's async feature, describes the rs/moq-srt dev-dependency and nix…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(moq-srt): the test target builds on its own" matches the main change: adding hang's async feature as a moq-srt dev-dependency so the moq-srt test target compiles standalone. It is specific and follows conventional commit style. The title does not mention the nix/Cargo.nix regeneration or the quest update, which is acceptable.

Full details: Description check

Explanation

The description is closely related to the changeset. It explains the standalone compile failure in moq-srt's test target caused by hang's async feature, describes the rs/moq-srt dev-dependency and nix/Cargo.nix regeneration, removes the .mbx.toml opt-out, and documents the quest rewrite and validation results.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cf6b7b03-46ad-4bb1-b13f-005a78ad5f75
Commits

Reviewing files that changed from the base of the PR and between 83c9fdd and f12bbdc.

Files selected for processing: 3

  • nix/Cargo.nix
  • quest/m0/test-flakes-3/srt-server-load.md
  • rs/moq-srt/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

pullfrog[bot]
pullfrog Bot previously approved these changes Nov 19, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. It fixes the cause, which is mbx queueing tests for a scheduler permit that counts against nextest's timeout, rather than raising timeouts or patching individual tests.

Reviewed changes

  • .mbx.toml: sets scheduler.tests = false workspace-wide, so direct cargo nextest run calls and CI get it too.
  • rs/moq-srt/Cargo.toml: adds a path-only hang dev-dependency with async, matching how internal dev-dependencies such as workspace-hack are declared, so cargo test -p moq-srt compiles alone.
  • nix/Cargo.nix: regenerated to match the new dev-dependency.
  • quest/m0/test-flakes-3/srt-server-load.md: deletes the finished quest file.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated

Copy link
Copy Markdown
Collaborator Author

Maintainer decision (2026-11-19, /quest-complete): ✅ drop the .mbx.toml opt-out and land only the moq-srt dev-dependency fix (rejected: land the opt-out; raise nextest's terminate-after here). The queued-test timeout gets fixed in mbx or the dotfiles config, so the host-wide test scheduling stays on.

(Written by Claude Opus 5.5 with high)

kixelated and others added 3 commits November 19, 2026 11:43
@kixelated kixelated changed the title fix(test): tests never queue for an mbx permit, and moq-srt's tests build alone fix(moq-srt): the test target builds on its own Nov 19, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Applied the decision in f12bbdc: .mbx.toml is gone, the PR keeps only moq-srt's hang async dev-dependency and the regenerated nix/Cargo.nix, and the quest stays open with a ## Waiting item on the mbx/dotfiles fix and the one-core reproduction to check it.

(Written by Claude Opus 5.5 with medium)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes since the prior pullfrog review (2a1fac9):

  • .mbx.toml removed: the workspace-wide scheduler.tests = false opt-out is gone, so host-wide test scheduling is unchanged.
  • Quest doc rewritten: quest/m0/test-flakes-3/srt-server-load.md now tracks the remaining mbx/dotfiles fix with a ## Waiting item and the one-core reproduction.
  • Kept: the moq-srt hang (async) dev-dependency and the regenerated nix/Cargo.nix, which fix the standalone test build.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge pick (2026-11-19, /quest-complete): ✅ /quest-merge at f12bbdc, applying the maintainer decision above (land the srt fix, fix the scheduler in mbx).

(Written by Claude Opus 5.5 with high)

@kixelated
kixelated added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit d3b632e Nov 19, 2026
6 checks passed
@kixelated
kixelated deleted the quest/m0/test-flakes-3/srt-server-load branch November 19, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant