Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/hakari.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ workspace-members = [
workspace-members = ["kio-macros"]
# Keep native media dependencies out of unrelated test builds. Final excludes
# preserve feature unification for their other dependencies.
third-party = [{ name = "pipewire" }, { name = "libspa" }, { name = "clang-sys" }]
third-party = [{ name = "pipewire" }, { name = "libspa" }, { name = "clang-sys" }, { name = "gstreamer" }, { name = "gstreamer-sys" }]
26 changes: 26 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

144 changes: 143 additions & 1 deletion nix/Cargo.nix

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 0 additions & 17 deletions quest/m1/gst-resume-late-flake.md

This file was deleted.

25 changes: 25 additions & 0 deletions quest/m3/moqsrc-redial-replay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# [S] moqsrc resumes after a redial without replaying what it rendered

## Goal

After `moqsrc`'s session redials and the same broadcast instance returns, its
pads continue at the live edge: no group already rendered plays again, and
playback runs no later than before the redial.

## Plan

Found by [moq-dev/moq#9168](https://github.com/moq-dev/moq/pull/9168), whose
test clock made it visible in
`source::imp::session_tests::a_protocol_violation_redials_after_playback`
(`rs/moq-gst/src/source/imp.rs`): after the relay closes the session, the new
session replays every cached group of the same instance from pts 0 under a
fresh timeline based at the redial, so all later frames play 500ms behind,
up to `max-delay` (1s by default), and each redial can add that again.
A wall clock hid it because the synced sink just waited.

Recommendation: keep the instance's `Timeline` across the redial (the
follower already keeps one per instance in `resumable`) and resume each
rendition after the last group it pushed, so replayed groups are skipped as
stale. Then make `rendered` in that test fail on a frame whose clock wait lies
past the time its stamp places it (the 50ms step), which today it lets the
clock catch up to; a wait at its due time stays valid.
2 changes: 2 additions & 0 deletions rs/moq-gst/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ gst-plugin-version-helper = "0.8"
[dev-dependencies]
criterion = { package = "bench-harness", path = "../bench-harness" }
futures = { workspace = true }
# A test clock for synced sinks, so lateness checks hold however loaded the machine is.
gst-check = { package = "gstreamer-check", version = "0.25", features = ["v1_16"] }
# Decodes the OpusHead the sink publishes, so the surround regression checks playback.
moq-audio = { path = "../moq-audio", default-features = false }
# Runs the tests that need a variable set or unset in a child process given it.
Expand Down
Loading