Repository navigation
quest land: disable the flaky test a-session-close-right-after-a-datagram-tracks-end-keeps-the-2 - #9195
Merged
Conversation
…ks-end-keeps-the-2.md for the disabled flaky test quest land watch writes the follow-up quest for the test the land fixer skipped.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — skips only the flaky ALPN_06 variant via test.skipIf and records a follow-up quest to fix or delete it.
Reviewed changes — the full diff of the PR.
- Test skip —
js/net/src/lite/datagram-tracks.test.tsusestest.skipIf(alpn === ALPN_06)(valid inbun:test), so theALPN_05andALPN_07_WIPvariants still run. - Quest files — adds
quest/m0/flaky/README.mdand the follow-up quest listing the two failing jobs.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The land fixer judged
[at]moq/net moq-lite-06: a session cl·ose right after a datagram tracks end keeps the endflaky 2 times, most recently in themerge_groupbuilds of #9115 (job 1), #9180 (job 1). This pull request skips it and adds its follow-up quest,quest/m0/flaky/a-session-close-right-after-a-datagram-tracks-end-keeps-the-2.md, to fix or delete it. quest land watch enqueues it like any other pull request, and fixes it if the queue drops it.Review
mechanical fix by codex, gpt-6.1-sol, medium effort:
skip the flaky [at]moq/net moq-lite-06: a session cl·ose right after a datagram tracks end keeps the end, and add quest/m0/flaky/a-session-cl·ose-right-after-a-datagram-tracks-end-keeps-the-2.md to fi·x or delete it(head 40b51fd)(written by codex, gpt-6.1-sol, medium effort)